Re: RFR: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

2021-07-02 Thread Michael McMahon
On Fri, 2 Jul 2021 11:58:46 GMT, Julia Boes wrote: >> `com.sun.net.httpserver.HttpServer::createContext` specifies >> `IllegalArgumentException` to be thrown if a context already exists for the >> path provided. The implementation class`sun.net.httpserver.ServerImpl` does >> not comply with th

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

2021-07-02 Thread Brian Burkhalter
On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

2021-07-02 Thread Alan Bateman
On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

2021-07-02 Thread Brian Burkhalter
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: In t

Re: RFR: 8267840: Improve URLStreamHandler.parseURL() [v2]

2021-07-02 Thread Daniel Fuchs
On Wed, 30 Jun 2021 11:47:42 GMT, Сергей Цыпанов wrote: >> There is an optimization opportunity for the widespread use-case when a >> resource is read from classpath using >> `getClass().getClassLoader().getResource()` or >> `getClass().getClassLoader().getResourceAsStream()`. >> >> Pay atte

Re: RFR: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

2021-07-02 Thread Daniel Fuchs
On Fri, 2 Jul 2021 11:56:04 GMT, Julia Boes wrote: > `com.sun.net.httpserver.HttpServer::createContext` specifies > `IllegalArgumentException` to be thrown if a context already exists for the > path provided. The implementation class`sun.net.httpserver.ServerImpl` does > not comply with this,

RFR: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

2021-07-02 Thread Julia Boes
`com.sun.net.httpserver.HttpServer::createContext` specifies `IllegalArgumentException` to be thrown if a context already exists for the path provided. The implementation class`sun.net.httpserver.ServerImpl` does not comply with this, which is fixed by this change. Testing: Tier 1-3 all clear.

Re: RFR: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

2021-07-02 Thread Julia Boes
On Fri, 2 Jul 2021 11:56:04 GMT, Julia Boes wrote: > `com.sun.net.httpserver.HttpServer::createContext` specifies > `IllegalArgumentException` to be thrown if a context already exists for the > path provided. The implementation class`sun.net.httpserver.ServerImpl` does > not comply with this,