Integrated: 8267840: Improve URLStreamHandler.parseURL()

2021-08-05 Thread Сергей Цыпанов
On Fri, 18 Jun 2021 07:31:14 GMT, Сергей Цыпанов wrote: > There is an optimization opportunity for the widespread use-case when a > resource is read from classpath using > `getClass().getClassLoader().getResource()` or > `getClass().getClassLoader().getResourceAsStream()`. > > Pay attention

Re: RFR: 8267840: Improve URLStreamHandler.parseURL() [v3]

2021-08-05 Thread Claes Redestad
On Mon, 5 Jul 2021 13:42:15 GMT, Сергей Цыпанов wrote: >> There is an optimization opportunity for the widespread use-case when a >> resource is read from classpath using >> `getClass().getClassLoader().getResource()` or >> `getClass().getClassLoader().getResourceAsStream()`. >> >> Pay

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value

2021-08-05 Thread Daniel Fuchs
On Fri, 16 Jul 2021 09:16:23 GMT, Jonathan Dowland wrote: > The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` uses > the IP address "1.1.1.1" as a value. I think at the time the address was > picked, the assumption was the address was not valid / not routable. Since >

Integrated: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-05 Thread Julia Boes
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote: > This is a minor change that updates > `sun.net.httpserver.HttpConnection::toString` to never return null. > > Testing: tier 1-3 all clear This pull request has now been integrated. Changeset: 685fc3c6 Author:Julia Boes URL:

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-05 Thread Julia Boes
On Wed, 4 Aug 2021 15:11:59 GMT, Daniel Fuchs wrote: >> Have a marginal preference for HttpConnection.class.getSimpleName(), since >> it is a constant, but don't object to getClass(). > > Right - but then why not use a string literal? If you're going to call a > method to get the class name

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-05 Thread Vyom Tewari
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote: > This is a minor change that updates > `sun.net.httpserver.HttpConnection::toString` to never return null. > > Testing: tier 1-3 all clear Looks good. - Marked as reviewed by vtewari (Committer). PR: