Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Iris Clark
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Revert two fixes Marked as reviewed by iris (Reviewer).

Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Pavel Rappo
> 8273616: Fix trivial doc typos in the java.base module Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Revert two fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/5475/files - new:

Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Pavel Rappo
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert two fixes > > src/java.base/share/classes/java/nio/channels/FileChannel.java line 567: > >> 565: *

Re: RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread Florent Guillaume
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose wrote: >> 8273616: Fix trivial doc typos in the java.base module > > src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java > line 399: > >> 397: * If {@code true} then this method is required to force >> changes

Re: RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread John R Rose
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo wrote: > 8273616: Fix trivial doc typos in the java.base module Approved, except for two changes commented above: the original "it need only force" is correct usage, and "it needs only force" is not good usage, but "it only needs to force" would

RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread Pavel Rappo
8273616: Fix trivial doc typos in the java.base module - Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/5475/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5475=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273616 Stats: 55

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value [v2]

2021-09-10 Thread Daniel Fuchs
On Fri, 6 Aug 2021 19:50:48 GMT, Jonathan Dowland wrote: >> The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` >> uses the IP address "1.1.1.1" as a value. I think at the time the address >> was picked, the assumption was the address was not valid / not routable. >>

RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-10 Thread Masanori Yano
Could you please review the 8233674 bug fixes? This problem is caused by the antivirus software opening the file for a short time, so CreateFile() should be retried. - Commit messages: - 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file