Re: RFR: 8273655: content-types.properties files are missing some common types

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 09:46:21 GMT, Julia Boes wrote: > This change adds some common types to the content-type.properties files, > notably .js, .css, and .jar, as well as some others. > > The duplicated entry for .zip is removed from the Windows properties file. > _Mailing list message from

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v2]

2021-09-15 Thread Michael McMahon
On Wed, 15 Sep 2021 08:42:40 GMT, Julia Boes wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java >> line 152: >> >>> 150: return server; >>> 151: } >>> 152: >> >> Too bad we couldn't simplify the setting up a basic certificate for https. > > That

Re: RFR: 8273655: content-types.properties files are missing some common types

2021-09-15 Thread Anthony Vanelverdinghe
On Tue, 14 Sep 2021 09:46:21 GMT, Julia Boes wrote: > This change adds some common types to the content-type.properties files, > notably .js, .css, and .jar, as well as some others. > > The duplicated entry for .zip is removed from the Windows properties file.

Re: RFR: 8273655: content-types.properties files are missing some common types

2021-09-15 Thread Bernd Eckenfels
In the Test List .xml is not mentioned, that looks like a major format. However I am not sure if it maybe needs extra handling because of possible different mime types for application/xml and text/xml? -- http://bernd.eckenfels.net Von: net-dev im Auftrag von

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v2]

2021-09-15 Thread Julia Boes
On Wed, 15 Sep 2021 03:14:04 GMT, Jaikiran Pai wrote: >> FWIW `.z` is the extension of the old Unix `compress` program. > >> FWIW `.z` is the extension of the old Unix `compress` program. > > Thank you Florent, I wasn't aware of that. related PR for reference:

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v2]

2021-09-15 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is

RFR: 8273655: content-types.properties files are missing some common types

2021-09-15 Thread Julia Boes
This change adds some common types to the content-type.properties files, notably .js, .css, and .jar, as well as some others. The duplicated entry for .zip is removed from the Windows properties file. - Commit messages: - add basic test - initial change Changes:

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 15:56:28 GMT, Jim Laskey wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Wed, 15 Sep 2021 07:49:38 GMT, Michael McMahon wrote: >> Or maybe - which would be more accurate: >> >> >> with the given {@code statusCode} and the body bytes' length (or {@code -1} >> if the body is empty). > > I agree with your second suggestion. It's better not to refer to the >

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 16:45:08 GMT, Daniel Fuchs wrote: >> Just a rewording, maybe. > > Hmm... Maye that should be "The response headers *are sent*". The non-obvious > technical details is that the response headers are sent before the body - as > soon as you call `sendResponseHeaders`. The link

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 13:38:27 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line >> 106: >> >>> 104: var h = headers.entrySet().stream() >>> 105: .collect(Collectors.toUnmodifiableMap( >>> 106:

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Michael McMahon
On Tue, 14 Sep 2021 16:51:40 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java >> line 129: >> >>> 127: * response body bytes are a {@code UTF-8} encoded byte >>> sequence of >>> 128: * {@code body}. The response {@linkplain >>>