Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-16 Thread Bernd Eckenfels
I also wonder if it makes sense to either only serve files with public permissions, or at least Filter some critical files like .ssh/* and *.jks. Those command-line servers are often started „accidentially“ in the home directory. -- http://bernd.eckenfels.net V

RFR: 8273910: Redundant condition and assignment in java.net.URI

2021-09-16 Thread Andrey Turbanov
1. Assignment `ru.host = child.host;` is duplicated and hence redundant. 2. Condition `q > p` is always `true`, because it just bellow inverse check if (q <= p) break; - Commit messages: - [PATCH] Cleanup redundant assignment and condition in URI

Re: RFR: 8273655: content-types.properties files are missing some common types [v2]

2021-09-16 Thread Phil Race
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated th

Re: RFR: 8273655: content-types.properties files are missing some common types [v2]

2021-09-16 Thread Julia Boes
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated th

Re: RFR: 8273655: content-types.properties files are missing some common types [v2]

2021-09-16 Thread Julia Boes
> This change adds some common types to the content-type.properties files, > notably .js, .css, and .jar, as well as some others. > > The duplicated entry for .zip is removed from the Windows properties file. Julia Boes has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-16 Thread Jaikiran Pai
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-16 Thread Daniel Fuchs
On Tue, 14 Sep 2021 10:14:45 GMT, Masanori Yano wrote: >> test/jdk/com/sun/nio/sctp/SctpChannel/CloseDescriptors.java line 29: >> >>> 27: * @summary Potential leak file descriptor for SCTP >>> 28: * @requires (os.family == "linux") >>> 29: * @run main CloseDescriptors >> >> The test SctpMult

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-16 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is th