Re: New candidate JEP: 418: Internet-Address Resolution SPI

2021-09-17 Thread mark . reinhold
2021/9/17 3:03:25 -0700, aleksej.efi...@oracle.com: > We had a discussion about the naming and decided to go with > InetAddressResolverProvider​​ and InetAddressResolver​​ names. > I will update the JEP​ text to reflect that. That sounds fine. - Mark

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-17 Thread Alan Bateman
On Fri, 17 Sep 2021 08:46:52 GMT, Masanori Yano wrote: > Thank you for your comment. According to Microsoft KB316609, CreateFile() > should be tried again a short time later. I think JarURLConnection should > also be retried when antivirus software holds some files. > https://www.betaarchive.co

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Jaikiran Pai
Hello Bernd, On 17/09/21 3:37 am, Bernd Eckenfels wrote: I also wonder if it makes sense to either only serve files with public permissions, or at least Filter some critical files like .ssh/* and *.jks. FWIW - From what I can see in the proposed implementation as well as the JEP text, hidden

Re: New candidate JEP: 418: Internet-Address Resolution SPI

2021-09-17 Thread Aleksej Efimov
We had a discussion about the naming and decided to go with InetAddressResolverProvider​​ and InetAddressResolver​​ names. I will update the JEP​ text to reflect that. With Kind Regards, Aleksei From: Aleksej Efimov Sent: Thursday, September 9, 2021 9:12 PM To: M

Re: RFR: 8273655: content-types.properties files are missing some common types [v2]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 18:06:53 GMT, Phil Race wrote: > I don't understand why these files are platform-specific. > And if each platform port does need one, where is the one for macOS ? I'm not an expert in the area, it's probably down to historic reasons? The Unix version would be for all Unix va

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Jaikiran Pai
Hello Julia, On 17/09/21 3:14 pm, Julia Boes wrote: On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote: Julia Boes has updated the pull request incrementally with one additional commit since the last revision: correct path handling src/jdk.httpserver/share/classes/module-info.java lin

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> correct path handling > > src/jdk.httpserver/share/classes/module-info.java line 55: > >> 53: *

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-17 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. Thank you for your comment. According to Microsoft KB316609, CreateF