Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Michael McMahon
On Wed, 29 Sep 2021 13:45:43 GMT, Mahendra Chhipa wrote: >> test/jdk/sun/net/www/protocol/http/B6296310.java line 103: >> >>> 101: try(PrintWriter pw = new >>> PrintWriter(trans.getResponseBody())) { >>> 102: pw.print(""); >>> 103: } >> >> Not sure what the purpo

Re: RFR: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress

2021-09-29 Thread Daniel Fuchs
On Wed, 29 Sep 2021 15:41:06 GMT, Aleksei Efimov wrote: > The following fix proposes to remove usages of `"impl.prefix"` JDK system > property from the `java.net.InetAddress` class. > This system property is used to locate concrete implementations of the > package private "java.net.InetAddress

Integrated: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings

2021-09-29 Thread Aleksey Shipilev
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote: > Recently added test fails on my desktop in the course of newly added `tier4` > runs. The reason is simple: the test verifies that lsof outputs no more than > LIMIT_LINES (2) lines. And on my machine, lsof prints some warnings that blow

Re: RFR: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress

2021-09-29 Thread Alan Bateman
On Wed, 29 Sep 2021 15:41:06 GMT, Aleksei Efimov wrote: > The following fix proposes to remove usages of `"impl.prefix"` JDK system > property from the `java.net.InetAddress` class. > This system property is used to locate concrete implementations of the > package private "java.net.InetAddress

Re: RFR: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings

2021-09-29 Thread Aleksey Shipilev
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote: > Recently added test fails on my desktop in the course of newly added `tier4` > runs. The reason is simple: the test verifies that lsof outputs no more than > LIMIT_LINES (2) lines. And on my machine, lsof prints some warnings that blow

RFR: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress

2021-09-29 Thread Aleksei Efimov
The following fix proposes to remove usages of `"impl.prefix"` JDK system property from the `java.net.InetAddress` class. This system property is used to locate concrete implementations of the package private "java.net.InetAddressImpl" interface. The list of changes: - `impl.prefix` usages ar

Re: RFR: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings

2021-09-29 Thread Alan Bateman
On Wed, 29 Sep 2021 15:05:21 GMT, Aleksey Shipilev wrote: > Ok, thanks. @AlanBateman, want to ack? I don't have anything to add except to say that close and async close implementations in the SCTP classes needs to be re-written and brought into line with the implementation in NIO. Also I'm not

Re: RFR: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings

2021-09-29 Thread Aleksey Shipilev
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote: > Recently added test fails on my desktop in the course of newly added `tier4` > runs. The reason is simple: the test verifies that lsof outputs no more than > LIMIT_LINES (2) lines. And on my machine, lsof prints some warnings that blow

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Mahendra Chhipa
On Wed, 29 Sep 2021 10:54:52 GMT, Michael McMahon wrote: >> Mahendra Chhipa has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v8]

2021-09-29 Thread Daniel Fuchs
On Wed, 29 Sep 2021 11:02:05 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Michael McMahon
On Wed, 22 Sep 2021 21:05:34 GMT, Mahendra Chhipa wrote: >> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed >> from following tests: >> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java >> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.j

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v8]

2021-09-29 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is th

Re: RFR: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings

2021-09-29 Thread Daniel Fuchs
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote: > Recently added test fails on my desktop in the course of newly added `tier4` > runs. The reason is simple: the test verifies that lsof outputs no more than > LIMIT_LINES (2) lines. And on my machine, lsof prints some warnings that blow

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-29 Thread Julia Boes
On Tue, 28 Sep 2021 10:30:21 GMT, Bernd Eckenfels wrote: > * For all interfaces use "-b 0.0.0.0" (IPv4) or "-b ::" (IPv6) > > Instead of: > > * For 0.0.0.0 (all interfaces) use -b 0.0.0.0 or -b ::0 > > In the usage? > > (I think ?::? is canon?) Good point, "::" is recommended, e.g. in RFC59