Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-03 Thread David Holmes
On 4/11/2021 12:14 am, Pavel Rappo wrote: On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: This PR follows up one of the recent PRs, where I used a non-canonical modifier order. Since the problem was noticed [^1], why not to address it en masse? As far as I remember, the first

Integrated: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Daniel Fuchs
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a trivial cleanup change that updates classes in the > `java.net.http` module to use the "blessed modifier order". > > The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh >

Re: RFR: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Mark Sheppard
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a trivial cleanup change that updates classes in the > `java.net.http` module to use the "blessed modifier order". > > The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh >

Re: RFR: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Daniel Fuchs
Hi Mark, On 03/11/2021 14:30, Mark Sheppard wrote: a general comment on the static abstract class changes to abstract static class. For me the former and current declarations seems more appropriate, that is, static abstract class, as the static modifier immediately conveys a significant

Re: RFR: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Mark Sheppard
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a trivial cleanup change that updates classes in the > `java.net.http` module to use the "blessed modifier order". > > The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh >

Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-03 Thread Pavel Rappo
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it en > masse? > > As far as I remember, the first mass-canonicalization of modifiers took

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v12]

2021-11-03 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: >

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v11]

2021-11-03 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: >

Re: RFR: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Pavel Rappo
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a trivial cleanup change that updates classes in the > `java.net.http` module to use the "blessed modifier order". > > The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh >

Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-03 Thread Pavel Rappo
On Tue, 2 Nov 2021 20:34:44 GMT, Martin Buchholz wrote: >>> Pragmatically, fix the script to ignore those keywords on comment lines. >>> Learn Perl, its just a regular expression pattern match and replace >>> expression. >> >> I understand in principle how to modify that script to ignore doc

RFR: 8276401: Use blessed modifier order in java.net.http

2021-11-03 Thread Daniel Fuchs
Hi, Please find here a trivial cleanup change that updates classes in the `java.net.http` module to use the "blessed modifier order". The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh src/java.net.http`. best regards, -- daniel - Commit messages: -

Integrated: 8276348: Use blessed modifier order in java.base

2021-11-03 Thread Pavel Rappo
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it en > masse? > > As far as I remember, the first mass-canonicalization of modifiers took