Re: RFR: 8277459: Add jwebserver tool [v6]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge branch 'ma

Re: RFR: 8277459: Add jwebserver tool [v5]

2021-11-29 Thread Daniel Fuchs
On Mon, 29 Nov 2021 13:57:13 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-29 Thread Julia Boes
On Thu, 25 Nov 2021 10:09:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix whitespace error, add missing code tag > > src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java

Re: RFR: 8277459: Add jwebserver tool [v5]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: update comment about exit code

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-11-29 Thread Daniel Jeliński
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Restore support for IPv6-only operati

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-29 Thread Daniel Fuchs
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8262442 (windows) use all proxy configuration sources when java.net.useSystemProxies=true

2021-11-29 Thread Daniel Fuchs
On Mon, 18 Oct 2021 19:25:12 GMT, Daniel Jeliński wrote: > With this patch DefaultProxySelector first attempts to use proxy config > autodetection (http://wpad/wpad.dat) when that is configured and available. > If proxy config autodetection is unavailable, selector tries to use > configured pro

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-11-29 Thread Daniel Fuchs
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Restore support for IPv6-only operati

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
On Wed, 24 Nov 2021 14:05:03 GMT, Julia Boes wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java >> line 110: >> >>> 108: * >>> 109: * A simple HTTP file server implementation is provided via the >>> 110: * {@code jwebserver} tool. >> >> Maybe an `@toolGu

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - add toolGuide ta

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
> Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 827

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
On Sat, 27 Nov 2021 22:50:55 GMT, Michael Bien wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.