Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2021-12-17 Thread Jaikiran Pai
On Fri, 17 Dec 2021 16:21:12 GMT, Daniel Jeliński wrote: >> Can I please get a review for this test only change which proposes to enable >> debug logs from the test that failed intermittently? This change addresses >> https://bugs.openjdk.java.net/browse/JDK-8278961. >> >> The change passes

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2021-12-17 Thread Jaikiran Pai
On Fri, 17 Dec 2021 16:21:59 GMT, Daniel Jeliński wrote: >> Can I please get a review for this test only change which proposes to enable >> debug logs from the test that failed intermittently? This change addresses >> https://bugs.openjdk.java.net/browse/JDK-8278961. >> >> The change passes

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2021-12-17 Thread Mark Sheppard
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2021-12-17 Thread Daniel Jeliński
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v6]

2021-12-17 Thread Roger Riggs
On Thu, 9 Dec 2021 13:03:39 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request

RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2021-12-17 Thread Jaikiran Pai
Can I please get a review for this test only change which proposes to enable debug logs from the test that failed intermittently? This change addresses https://bugs.openjdk.java.net/browse/JDK-8278961. The change passes the (test specific) `-d` option to enable logs from that test by default.