Integrated: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote: > In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the > return statement says that "The array is ordered based on protocol > preference, with protocols[0] being the most preferred.". However, there is > no

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 15:31:55 GMT, Daniel Fuchs wrote: >> Hm, much better. Thanks! > >> The phrase "descending order" seems more appropriate for numerical values. I >> think the previous wording was more clear, with a small change: "The array >> is ordered based on protocol preference, with

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Daniel Fuchs
On Thu, 20 Jan 2022 14:42:56 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 619: >> >>> 617: * >>> 618: * @return a non-null, possibly zero-length array of application >>> protocol >>> 619: * {@code String}s. The

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Sean Mullan
On Thu, 20 Jan 2022 14:46:28 GMT, Xue-Lei Andrew Fan wrote: >> In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the >> return statement says that "The array is ordered based on protocol >> preference, with protocols[0] being the most preferred.". However, there is >> no

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 14:16:43 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update per feedback > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 619: > >> 617: *

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-20 Thread Sean Mullan
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote: > In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the > return statement says that "The array is ordered based on protocol > preference, with protocols[0] being the most preferred.". However, there is > no

Integrated: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException

2022-01-20 Thread Julia Boes
On Wed, 19 Jan 2022 17:01:22 GMT, Julia Boes wrote: > Small test-only fix that generalizes the expected exception type from > SSLHandshakeException to SSLException (a super class of the former). > > Testing: tier 1-3 and repeated runs of test in question all clear This pull request has now

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-20 Thread Daniel Fuchs
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote: > In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the > return statement says that "The array is ordered based on protocol > preference, with protocols[0] being the most preferred.". However, there is > no

Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]

2022-01-20 Thread Daniel Fuchs
On Thu, 20 Jan 2022 09:20:25 GMT, Julia Boes wrote: >> Small test-only fix that generalizes the expected exception type from >> SSLHandshakeException to SSLException (a super class of the former). >> >> Testing: tier 1-3 and repeated runs of test in question all clear > > Julia Boes has

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v3]

2022-01-20 Thread Michael Osipov
On Thu, 20 Jan 2022 10:58:27 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v3]

2022-01-20 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The

Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]

2022-01-20 Thread Julia Boes
On Wed, 19 Jan 2022 17:16:30 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address PR comment: remove bug id in test > >

Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]

2022-01-20 Thread Julia Boes
> Small test-only fix that generalizes the expected exception type from > SSLHandshakeException to SSLException (a super class of the former). > > Testing: tier 1-3 and repeated runs of test in question all clear Julia Boes has updated the pull request incrementally with one additional commit

Integrated: 8276166: Remove dead code from MimeTable and MimeEntry

2022-01-20 Thread Сергей Цыпанов
On Fri, 29 Oct 2021 11:20:57 GMT, Сергей Цыпанов wrote: > There are unused methods/constructors in mentioned classes that can be safely > removed. This pull request has now been integrated. Changeset: cf977e88 Author:Sergey Tsypanov Committer: Julia Boes URL:

Re: RFR: 8276166: Remove dead code from MimeTable and MimeEntry

2022-01-20 Thread Сергей Цыпанов
On Wed, 19 Jan 2022 16:55:44 GMT, Julia Boes wrote: >> Not now > > Happy to /sponsor once you /integrate, @stsypanov. @FrauBoes thanks! - PR: https://git.openjdk.java.net/jdk/pull/6169