Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v7]

2022-01-25 Thread Jaikiran Pai
> This change proposes to implement the enhancement noted in > https://bugs.openjdk.java.net/browse/JDK-8209137. > > The change introduces a new API to allow applications to build a > `java.net.http.HTTPClient` configured with a specific local address that will > be used while creating

Re: RFR: 8278263: Remove redundant synchronized from URLStreamHandler.openConnection methods

2022-01-25 Thread Florent Guillaume
On Fri, 12 Nov 2021 19:35:10 GMT, Andrey Turbanov wrote: > All this Handler's are stateless and there is nothing to protect via > synchronization. In theory a subclass overloading using a non-synchronized `openConnection(URL u, Proxy p)` could have relied on `openConnection(URL u)` delegating

Re: RFR: 8278263: Remove redundant synchronized from URLStreamHandler.openConnection methods

2022-01-25 Thread Daniel Fuchs
On Fri, 12 Nov 2021 19:35:10 GMT, Andrey Turbanov wrote: > All this Handler's are stateless and there is nothing to protect via > synchronization. LGTM. Please integrate and drop me a note and I will sponsor it. - Marked as reviewed by dfuchs (Reviewer). PR:

Integrated: 8280414: Memory leak in DefaultProxySelector

2022-01-25 Thread Daniel Jeliński
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. This pull request has now been integrated.

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v8]

2022-01-25 Thread Michael Osipov
On Tue, 25 Jan 2022 12:47:26 GMT, Michael McMahon wrote: >> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 150: >> >>> 148: * "domain:a,c.d,*.e.f" (sent to host a, or c.d or to the domain >>> e.f and any of its subdomains). This is >>> 149: * a comma separated list

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v8]

2022-01-25 Thread Michael McMahon
On Tue, 25 Jan 2022 11:34:57 GMT, Michael Osipov wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> final review update (pre CSR) > > src/java.base/share/classes/sun/net/www/http/HttpClient.java line 150: > >>

Integrated: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC

2022-01-25 Thread Daniel Jeliński
On Fri, 21 Jan 2022 16:51:20 GMT, Daniel Jeliński wrote: > Fix RFC compliance. > Tier1 and tier2 passed. This pull request has now been integrated. Changeset: 28796cbd Author:Daniel Jeliński Committer: Michael McMahon URL:

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v8]

2022-01-25 Thread Daniel Fuchs
On Tue, 25 Jan 2022 10:30:20 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v8]

2022-01-25 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The