On Wed, 26 Jan 2022 18:25:19 GMT, Daniel Fuchs wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commit
On Wed, 26 Jan 2022 16:25:24 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed ^M from test
>
> test/jdk/sun/security/krb5/auto/HttpsCB.java line 120:
>
>> 118:
>> 119: boolean
On Wed, 26 Jan 2022 16:27:29 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed ^M from test
>
> test/jdk/sun/security/krb5/auto/HttpsCB.java line 201:
>
>> 199: return reader
On Wed, 19 Jan 2022 08:15:24 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> br
On Fri, 12 Nov 2021 19:11:36 GMT, Andrey Turbanov wrote:
> All this manually written code actually can be replaced with single
> String.isBlank() call.
> `file` variable is guaranteed to be non-null.
LGTM. Testing didn't reveal any issue.
-
Marked as reviewed by dfuchs (Reviewer).
On Wed, 26 Jan 2022 16:02:09 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Fri, 12 Nov 2021 19:11:36 GMT, Andrey Turbanov wrote:
> All this manually written code actually can be replaced with single
> String.isBlank() call.
> `file` variable is guaranteed to be non-null.
I'm running tier1-3 and will approve if the results come green.
-
PR: https://git
On Wed, 26 Jan 2022 09:38:58 GMT, Alan Bateman wrote:
> Are you thinking about code that extends the sun.* classes?
Yes that was my idea, but indeed if there's no way for them to be extended by
user code it's probably not an issue.
-
PR: https://git.openjdk.java.net/jdk/pull/6373
On Tue, 25 Jan 2022 21:01:42 GMT, Florent Guillaume
wrote:
> In theory a subclass overloading using a non-synchronized `openConnection(URL
> u, Proxy p)` could have relied on `openConnection(URL u)` delegating to it
> and having been synchronized. So maybe this requires a small CSR?
The chang
11 matches
Mail list logo
