Integrated: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-31 Thread Michael McMahon
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote: > Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a

Re: RFR: 8280494: (D)TLS signature schemes [v7]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 21:55:18 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rollback to use captialized S > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 727: > >>

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 21:26:46 GMT, Sean Mullan wrote: >> As there is increasing number of SSL parameters, applications may just use >> the constructor with no argument, and use the set methods individually. > > Ok. You should specify what the default value of the signature schemes > parameter

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-01-31 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-31 Thread Joe Darcy
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-31 Thread Sean Mullan
On Sat, 29 Jan 2022 05:26:33 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94: >> >>> 92: >>> 93: /** >>> 94: * Constructs SSLParameters. >> >> Would it be useful to add another ctor that takes a signature schemes array >>

Re: RFR: 8280494: (D)TLS signature schemes [v7]

2022-01-31 Thread Sean Mullan
On Mon, 31 Jan 2022 20:24:47 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE:

Integrated: 8280949: Correct the references for the Java Security Standard Algorithm Names specification

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 15:37:38 GMT, Xue-Lei Andrew Fan wrote: > In the JSSE specification, the reference to "Java Security Standard Algorithm > Names" specification is documented as "Java Cryptography Architecture > Standard Algorithm Name Documentation". As should be corrected. This pull

Re: RFR: 8280494: (D)TLS signature schemes [v7]

2022-01-31 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 20:05:45 GMT, Sean Mullan wrote: > > > Please capitalize "specification" (i.e. "Specification") to be consistent > > > with other references in the javadoc. Looks good otherwise. > > > > > > OK. Just curious, why we want to use capitalized "specification"? This word > >

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Sean Mullan
On Mon, 31 Jan 2022 19:19:28 GMT, Xue-Lei Andrew Fan wrote: > > Please capitalize "specification" (i.e. "Specification") to be consistent > > with other references in the javadoc. Looks good otherwise. > > OK. Just curious, why we want to use capitalized "specification"? This word >

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 16:39:34 GMT, Sean Mullan wrote: > Please capitalize "specification" (i.e. "Specification") to be consistent > with other references in the javadoc. Looks good otherwise. OK. Just curious, why we want to use capitalized "specification"? This word "specification" is not a

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v3]

2022-01-31 Thread Xue-Lei Andrew Fan
> In the JSSE specification, the reference to "Java Security Standard Algorithm > Names" specification is documented as "Java Cryptography Architecture > Standard Algorithm Name Documentation". As should be corrected. Xue-Lei Andrew Fan has updated the pull request incrementally with one

RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification

2022-01-31 Thread Xue-Lei Andrew Fan
In the JSSE specification, the reference to "Java Security Standard Algorithm Names" specification is documented as "Java Cryptography Architecture Standard Algorithm Name Documentation". As should be corrected. - Commit messages: - 8280949: Correct the references for the Java

Re: RFR: 8280494: (D)TLS signature schemes [v6]

2022-01-31 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:08:22 GMT, Bernd wrote: >> Yes, it does. Do you like to use a for-loop, without new object allocation? > > Yes, static helper Thanks for confirm. Updated to use a static helper method. - PR: https://git.openjdk.java.net/jdk/pull/7252

Integrated: 8278263: Remove redundant synchronized from URLStreamHandler.openConnection methods

2022-01-31 Thread Andrey Turbanov
On Fri, 12 Nov 2021 19:35:10 GMT, Andrey Turbanov wrote: > All this Handler's are stateless and there is nothing to protect via > synchronization. This pull request has now been integrated. Changeset: c6ed2046 Author:Andrey Turbanov URL: