Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Xue-Lei Andrew Fan
On Mon, 28 Feb 2022 19:44:19 GMT, Jamil Nimeh wrote: >> src/java.base/share/classes/sun/security/ssl/CompressionAlgorithm.java line >> 49: >> >>> 47: } >>> 48: >>> 49: static CompressionAlgorithm nameOf(String name) { >> >> Shouldn't this be valueOf? We're not consistent in the metho

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Mon, 28 Feb 2022 19:41:59 GMT, Jamil Nimeh wrote: >> Hi, >> >> Please review the implementation of RFC 8879, TLS Certificate Compression, >> in JDK. The TLS Certificate Compression standard is an essential part for >> QUIC connections and performance improvement for TLS connections. More

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Wed, 23 Feb 2022 20:15:24 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > Please review the implementation of RFC 8879, TLS Certificate Compression, in > JDK. The TLS Certificate Compression standard is an essential part for QUIC > connections and performance improvement for TLS connections. Mor

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v13]

2022-02-28 Thread Jaikiran Pai
> This change proposes to implement the enhancement noted in > https://bugs.openjdk.java.net/browse/JDK-8209137. > > The change introduces a new API to allow applications to build a > `java.net.http.HTTPClient` configured with a specific local address that will > be used while creating `Socket`

Re: RFR: JDK-8280498: jdk/java/net/Inet4Address/PingThis.java fails on AIX [v3]

2022-02-28 Thread Daniel Fuchs
On Sun, 27 Feb 2022 14:11:28 GMT, Michael Felt wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild psu

Re: RFR: JDK-8280498: jdk/java/net/Inet4Address/PingThis.java fails on AIX [v2]

2022-02-28 Thread Daniel Fuchs
On Sun, 27 Feb 2022 14:07:57 GMT, Michael Felt wrote: >> Michael Felt has refreshed the contents of this pull request, and previous >> commits have been removed. Incremental views are not available. > > Force pushed - too many typos - so 'erased' the mess-ups @aixtools Thanks for the detailed a