Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v2]

2022-03-09 Thread Sibabrata Sahoo
> Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update HttpsCB.java - Chang

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Joe Wang
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For the bundles in java.xml: For files with Oracle copyright, update the year to 2022 and @LastModified Mar 2022. Take XPATHErrorResources_ja.java as an example, the copyright year was updated to 2021 and @

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Naoto Sato
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 `src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties` `src/java.base/share/classes/sun/util/resources/CurrencyNames_ja.properties` `src/java.base/share/classes/sun/util/resources/Currenc

RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Alisen Chung
msg drop for jdk19, Mar 9, 2022 - Commit messages: - open jdk19 l10n msg drop Changes: https://git.openjdk.java.net/jdk/pull/7765/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7765&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280400 Stats: 13775 lines

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-09 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed hal

Integrated: 8280494: (D)TLS signature schemes

2022-03-09 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Daniel Fuchs
On Wed, 9 Mar 2022 15:18:02 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthen

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Daniel Fuchs
On Wed, 9 Mar 2022 14:23:38 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system prop

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Weijun Wang
On Wed, 9 Mar 2022 14:23:38 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system prop

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Daniel Fuchs
On Wed, 9 Mar 2022 14:23:38 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system prop

RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

2022-03-09 Thread Sibabrata Sahoo
Domain value for system property jdk.https.negotiate.cbt is case-insensitive now. Included Test has been updated to address the change. - Commit messages: - 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive Changes: https://git.openjdk.j

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Michael McMahon
On Mon, 7 Mar 2022 20:35:13 GMT, Sean Mullan wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthent

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value M

Re: RFR: 8280494: (D)TLS signature schemes [v20]

2022-03-09 Thread Sean Mullan
On Wed, 9 Mar 2022 08:25:48 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Daniel Fuchs
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote: > These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Daniel Fuchs
On Wed, 9 Mar 2022 10:04:57 GMT, Jaikiran Pai wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling reque

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Jaikiran Pai
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote: > These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests

Re: RFR: 8280494: (D)TLS signature schemes [v20]

2022-03-09 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 > Release-note: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8280494: (D)TLS signature schemes [v19]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 16:13:08 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test for DTLS > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 501: > >> 499: >> 5