Re: RFR: 8284890: Support for Do not fragment IP socket options [v8]

2022-04-20 Thread Daniel Fuchs
On Wed, 20 Apr 2022 14:30:21 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following PR review please? It adds a new JDK specific >> extended socket option >> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 >> and IPv6 >> UDP sockets (NIO

Re: RFR: 8284890: Support for Do not fragment IP socket options [v8]

2022-04-20 Thread Michael McMahon
> Hi, > > Could I get the following PR review please? It adds a new JDK specific > extended socket option > called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 > and IPv6 > UDP sockets (NIO DatagramChannels). For IPv4 in particular, it sets the DF > (Dont Fragment) bit

Integrated: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-04-20 Thread Daniel Fuchs
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote: > These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-20 Thread Daniel Fuchs
On Sat, 16 Apr 2022 11:06:21 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-20 Thread Michael McMahon
On Sat, 16 Apr 2022 11:06:21 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling

RFR: release note for HTTPS Channel binding feature

2022-04-20 Thread Michael McMahon
Hi, https://bugs.openjdk.java.net/browse/JDK-8285240 contains the release note for the TLS Channel binding enhancement in JDK 19 added in: https://bugs.openjdk.java.net/browse/JDK-8279842 (PR: https://github.com/openjdk/jdk/pull/7065) The release note uses the explanatory text from the CSR

Re: RFR: 8284890: Support for Do not fragment IP socket options [v7]

2022-04-20 Thread Michael McMahon
> Hi, > > Could I get the following PR review please? It adds a new JDK specific > extended socket option > called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 > and IPv6 > UDP sockets (NIO DatagramChannels). For IPv4 in particular, it sets the DF > (Dont Fragment) bit

Re: RFR: 8284890: Support for Do not fragment IP socket options [v5]

2022-04-20 Thread Michael McMahon
On Tue, 19 Apr 2022 16:07:29 GMT, Daniel Fuchs wrote: >> I'm not sure there is value in testing all of these permutations. >> Distinguishing DatagramChannel and DatagramSocket probably made sense, but >> it's all the same implementation under the hood. > > 1. `DatagramChannel.open()` => opens