On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote:
> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - drop branches that are never executed
>
On Thu, 19 May 2022 09:38:40 GMT, Kevin Walls wrote:
>> Alexey Ivanov has updated the pull request incrementally with seven
>> additional commits since the last revision:
>>
>> - ...set to the values...
>> - ...will result in a Zip64 Extra (EXT) header
>> - ...in addition to the main attribu
On Thu, 19 May 2022 08:47:47 GMT, Kevin Walls wrote:
>> Alexey Ivanov has updated the pull request incrementally with seven
>> additional commits since the last revision:
>>
>> - ...set to the values...
>> - ...will result in a Zip64 Extra (EXT) header
>> - ...in addition to the main attribu
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Alexey Ivanov has updated the pull request incrementally with seven additional
commits since the last revision:
- ...set to the values...
- ..
On Thu, 19 May 2022 12:19:25 GMT, ExE Boss wrote:
>> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - drop branches that are never executed
>>
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
The security/crypto parts look good to me.
-
Marked as reviewed by xuelei (
On Thu, 19 May 2022 09:31:07 GMT, Kevin Walls wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> Also, I fixed a couple of spelling mistakes.
>
> test/jdk/sun/security/tools/jarsigner/OldSig.java line 32:
>
>> 30: /*
>> 31: * Se
On Tue, 17 May 2022 12:45:52 GMT, Daniel Jeliński wrote:
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests or
On Thu, 19 May 2022 12:05:45 GMT, Daniel Jeliński wrote:
>> This PR improves the execution time of jdk_net tests (and, by extension,
>> tier2) by about 3 minutes.
>>
>> Tests located under `jdk/java/net/httpclient/websocket` are never run in
>> parallel. Each of the 8 modified `Pending***` tes
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote:
> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - drop branches that are never executed
>
On Thu, 19 May 2022 10:46:35 GMT, Pavel Rappo wrote:
> > > What looks questionable is rearrangement of asserts: when `assertHangs`
> > > moves down. assertNotDone(cfClose) can transitorry pass even if ping has
> > > not hung.
> >
> >
> > `assertHangs` either waits for 5 seconds or throws an e
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests originally required 40
> seconds to complete. After the prop
On Thu, 19 May 2022 09:42:05 GMT, Daniel Jeliński wrote:
> > What looks questionable is rearrangement of asserts: when `assertHangs`
> > moves down. assertNotDone(cfClose) can transitorry pass even if ping has
> > not hung.
>
> `assertHangs` either waits for 5 seconds or throws an exception, s
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests originally required 40
> seconds to complete. After the prop
On Thu, 19 May 2022 09:22:57 GMT, Pavel Rappo wrote:
> What looks questionable is rearrangement of asserts: when `assertHangs` moves
> down. assertNotDone(cfClose) can transitorry pass even if ping has not hung.
`assertHangs` either waits for 5 seconds or throws an exception, so
`assertNotDone
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
OK. I started with serviceability but then went through everything as it's
hard to reco
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 84:
> 82:
> 83: /**
> 84:
On Tue, 17 May 2022 14:55:11 GMT, Daniel Fuchs wrote:
> I am a bit less sure about moving the post-asserts inside the loop
I moved them because they too can fail if the original blocked future suddenly
completes.
Side effect of this change is that any failures that happen after
websocket.abort
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/cds/filemap.cpp line 1914:
> 1912:
> 1913: // the current value o
On Tue, 17 May 2022 12:45:52 GMT, Daniel Jeliński wrote:
> This PR improves the execution time of jdk_net tests (and, by extension,
> tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in
> parallel. Each of the 8 modified `Pending***` tests or
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/interpreter/bytecodeUtils.cpp line 186:
> 184: static const int _max
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/opto/graphKit.cpp line 3626:
> 3624: // The optional arguments are for
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348:
> 346:
> 347: /**
>
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.sctp/share/classes/com/sun/nio/sctp/ShutdownNotification.java line 28:
> 26:
>
24 matches
Mail list logo
