Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Mon, 28 Feb 2022 19:41:59 GMT, Jamil Nimeh wrote: >> Hi, >> >> Please review the implementation of RFC 8879, TLS Certificate Compression, >> in JDK. The TLS Certificate Compression standard is an essential part for >> QUIC connections and performance improvem

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Jamil Nimeh
On Wed, 23 Feb 2022 20:15:24 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > Please review the implementation of RFC 8879, TLS Certificate Compression, in > JDK. The TLS Certificate Compression standard is an essential part for QUIC > connections and performance improvement for TLS connections. Mor

Re: RFR: 8281289: Improve with List.copyOf

2022-02-04 Thread Jamil Nimeh
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote: > Please review this trivial code clean up, for a little bit better performance. Looks good to me. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7356

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Jamil Nimeh
On Fri, 28 Jan 2022 15:44:16 GMT, Sean Mullan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710: >> >>> 708: * Signature Schemes section of the Java Cryptography >>> 709: * Architecture Standard Algorithm Name Documentation, and may also >>> 710: * in

Re: RFR: 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl

2021-11-08 Thread Jamil Nimeh
On Mon, 8 Nov 2021 22:59:30 GMT, Bradford Wetmore wrote: > Minor typos. Looks good - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6301

Re: RFR: 8267750: Incomplete fix for JDK-8267683

2021-05-25 Thread Jamil Nimeh
On Wed, 26 May 2021 01:12:14 GMT, Bradford Wetmore wrote: > Missed updating today's changeset with the new variable name. > > It's a "one character fix." Looks good. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4196