On Thu, 24 Feb 2022 16:01:57 GMT, Mahendra Chhipa wrote:
> Updated following remaining tests to remove depenedies of TestHttpServer,
> HttpTransaction, HttpCallback
> open/test/jdk/java/net/ProxySelector/LoopbackAddresses.java
> open/test/jdk/java/net/ProxySelector/ProxyTest.java
>
On Tue, 15 Feb 2022 13:06:29 GMT, Julia Boes wrote:
> This change adds a check for URI path segments that look like a root drive on
> Windows, e.g. "C:". Such path segments are not supported because a request
> path should really be relative to the working direct
ecific helper class, some
> additional test cases are included.
>
> Testing: tier 1-3, common Windows versions.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
fix package hierarchy
-
Changes:
- all: https://git.op
This change adds a check for URI path segments that look like a root drive on
Windows, e.g. "C:". Such path segments are not supported because a request path
should really be relative to the working directory.
The check is implemented with a platform-specific helper class, some additional
test
On Thu, 3 Feb 2022 09:24:46 GMT, Julia Boes wrote:
> This change updates the tests in question to handle the case where sym link
> creation is not supported, as observed on Windows 11 where additional
> privileges are required to create sym links.
>
> Testing: tier 1-3 across
> specifically
Julia Boes has updated the pull request incrementally with two additional
commits since the last revision:
- refactor test helper method
- change jtreg.SkippedException to testng.SkipException
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7335/fi
On Thu, 3 Feb 2022 16:16:32 GMT, Michael McMahon wrote:
>> This change updates the tests in question to handle the case where sym link
>> creation is not supported, as observed on Windows 11 where additional
>> privileges are required to create sym links.
>>
>> Testing: tier 1-3 across
This change updates the tests in question to handle the case where sym link
creation is not supported, as observed on Windows 11 where additional
privileges are required to create sym links.
Testing: tier 1-3 across platforms, plus tests in question on Windows 11
specifically
-
On Fri, 21 Jan 2022 14:38:08 GMT, Julia Boes wrote:
> This change adds the classpath exception to the copyright header of the files
> in question. As source files, they should have both the GPL and the classpath
> exception.
This pull request has now been integrated.
Changeset:
This change adds the classpath exception to the copyright header of the files
in question. As source files, they should have both the GPL and the classpath
exception.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk18/pull/111/files
Webrev:
On Wed, 19 Jan 2022 17:01:22 GMT, Julia Boes wrote:
> Small test-only fix that generalizes the expected exception type from
> SSLHandshakeException to SSLException (a super class of the former).
>
> Testing: tier 1-3 and repeated runs of test in question all clear
This pull req
On Wed, 19 Jan 2022 17:16:30 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address PR comment: remove bug id in test
>
> test/jdk/com/sun/net/http
> Small test-only fix that generalizes the expected exception type from
> SSLHandshakeException to SSLException (a super class of the former).
>
> Testing: tier 1-3 and repeated runs of test in question all clear
Julia Boes has updated the pull request incrementally with one additi
Small test-only fix that generalizes the expected exception type from
SSLHandshakeException to SSLException (a super class of the former).
Testing: tier 1-3 and repeated runs of test in question all clear
-
Commit messages:
- initial commit
Changes:
On Fri, 24 Dec 2021 20:12:39 GMT, Сергей Цыпанов wrote:
>> There are unused methods/constructors in mentioned classes that can be
>> safely removed.
>
> Not now
Happy to /sponsor once you /integrate, @stsypanov.
-
PR: https://git.openjdk.java.net/jdk/pull/6169
On Wed, 12 Jan 2022 16:59:14 GMT, Julia Boes wrote:
> This new test confirms that the jwebserver does not wait indefinitely for a
> request to arrive, but instead closes the connection when the maximum request
> time is reached. To facilitate this, Exchange::run is amended t
On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address PR comments:
>> * remove redundant null check
>> * use try-fin
rrent thread is the dispatcher thread
> (which is the case for the jwebserver).
>
> Testing: tier 1-3 all clear.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
address PR comments:
* remove redundant null check
* use try-fi
This new test confirms that the jwebserver does not wait indefinitely for a
request to arrive, but instead closes the connection when the maximum request
time is reached. To facilitate this, Exchange::run is amended to process
cancelled keys in the case where the current thread is the
On Fri, 29 Oct 2021 11:20:57 GMT, Сергей Цыпанов wrote:
> There are unused methods/constructors in mentioned classes that can be safely
> removed.
The changes look good to me. I also ran tier 1-3 across platforms - all clear.
-
PR: https://git.openjdk.java.net/jdk/pull/6169
This change sets a maximum request time for the `jwebserver` (and `java -m
jdk.httpserver`), unless it has already been set.
While here, I removed a comment from the implementation classes, a left-over
from the pre-module era that is not needed and should not have been included in
the first
On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote:
> This doc-only change amends the method-level documentation of
> SimpleFileServer#createFileServer() to specify the state of the returned
> server.
This pull request has now been integrated.
Changeset: 53df9ffb
Author: Julia
On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote:
> This doc-only change amends the method-level documentation of
> SimpleFileServer#createFileServer() to specify the state of the returned
> server.
CSR: https://bugs.openjdk.java.net/browse/JDK-8278159
-
This doc-only change amends the method-level documentation of
SimpleFileServer#createFileServer() to specify the state of the returned server.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk/pull/6674/files
Webrev:
Hi Jaikiran,
I agree, a sentence like "The returned server is not started." should be added,
similar to the API doc of the new HttpServer::create. I filed an issue for it:
https://bugs.openjdk.java.net/browse/JDK-8278154
While here, I'll fix the typo in the first line, too.
Regards,
Julia
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote:
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
This pull request has now been integrated.
Changeset: f505396c
Author: Jul
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 16 commits:
-
On Thu, 25 Nov 2021 10:09:21 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix whitespace error, add missing code tag
>
> src/jdk.httpserver/share/classes/s
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
update comment abo
On Wed, 24 Nov 2021 14:05:03 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java
>> line 110:
>>
>>> 108: *
>>> 109: * A simple HTTP file server implementation is provided via the
>>>
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 14 commits:
- a
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
fix whitespace error, add miss
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
address PR comments:
* u
On Wed, 24 Nov 2021 11:57:16 GMT, Daniel Fuchs wrote:
>> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
>> Server.
>>
>> A description is provided in a follow-up comment.
>
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java
> line 110:
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote:
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
This change adds a dedicated command-line tool for the Simple Web Server, to
improve
This change introduces jwebserver, a dedicated JDK tool for the Simple Web
Server.
A description is provided in a follow-up comment.
-
Commit messages:
- update module summary
- Merge branch 'master' into jwebserver
- add version option, consolidate tests, update module and
Hi Jaikiran,
On 22/11/2021 09:29, Jaikiran Pai wrote:
> The newly introduced simple webserver when launched from a directory
> does necessary checks to disallow serving of hidden files (and
> symlinks). So if I do something like:
>
> cd ~/
>
> java -m jdk.httpserver
>
> and then issue a HTTP
On Thu, 11 Nov 2021 17:08:37 GMT, Julia Boes wrote:
> This change corrects the server configuration in `testBindAllInterfaces` to
> specify the port. Additionally, a manual test is added for the case where the
> port is not specified and the server uses the default port 8000, wh
On Thu, 11 Nov 2021 14:58:45 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they
st. To avoid this scenario and the resulting
> BindException, the test is made manual.
>
> Testing: Tier 1-3
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
add jtreg bug id
-
Changes:
- all: https://git.openjdk.java.ne
On Fri, 12 Nov 2021 04:30:31 GMT, Jaikiran Pai wrote:
> Is it intentional that this new manual test and the existing tests in
> "simpleserver" don't have a `@bug` id noted on their test definition?
I don't think the `@bug` tag is necessary for tests that are added as part of a
JEP, but I
This change corrects the server configuration in `testBindAllInterfaces` to
specify the port. Additionally, a manual test is added for the case where the
port is not specified and the server uses the default port 8000, which might
already be in use by another test. To avoid this scenario and
On Tue, 26 Oct 2021 12:46:31 GMT, Julia Boes wrote:
> This change ensures that the realm string passed to the BasicAuthenticator
> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added to
> jdk.httpserver/sun.net.httpserver that holds the new isQuotedString
Testing: tier 1-3.
>
> [1] https://datatracker.ietf.org/doc/html/rfc7230
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
address PR comments
* change method name to isQuotedStringContent
* update api note and throws declaration
On Tue, 26 Oct 2021 13:56:25 GMT, Daniel Fuchs wrote:
>> This change ensures that the realm string passed to the BasicAuthenticator
>> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added
>> to jdk.httpserver/sun.net.httpserver that holds the new isQuotedString()
>>
This change ensures that the realm string passed to the BasicAuthenticator
constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added to
jdk.httpserver/sun.net.httpserver that holds the new isQuotedString() method
and the pre-existing isValidName() method (previously in
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class wh
On Mon, 18 Oct 2021 11:38:22 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 24 commits:
>>
>> - Minor rewording of bind address output
>> - Merge bra
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 24 commits:
- Minor rewording of bind address output
- Mer
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
update output for all interfaces
-
Changes:
- all: htt
On Tue, 28 Sep 2021 10:30:21 GMT, Bernd Eckenfels
wrote:
> * For all interfaces use "-b 0.0.0.0" (IPv4) or "-b ::" (IPv6)
>
> Instead of:
>
> * For 0.0.0.0 (all interfaces) use -b 0.0.0.0 or -b ::0
>
> In the usage?
>
> (I think ?::? is canon?)
Good point, "::" is recommended, e.g. in
On Tue, 28 Sep 2021 10:08:29 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 20 commits:
- use ipv4/ipv6 specific loopback address and add a
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote:
> Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is
> common default for Apache httpd [1], Ngnix [2], the Python web server [3].
> This being said, I want to make sure we're taking the right decision here so
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with two additional
commits since the last revision:
- change default bind address from anylocal to loopback
- address PR com
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 16:18:54 GMT, Daniel Fuchs wrote:
>> The problem I was referring to was not about printing to the console. I
>> hadn't thought about that, I agree the default locale should be used there.
>> I was referring to `Last-modified` HTTP headers with a non-English date
>> value,
On Mon, 20 Sep 2021 16:16:10 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java
>> line 340:
>>
>>> 338: }
>>> 339: }
>>> 340: return false;
>>
>> This will start checking from the root of
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' into simpleserver
- Merg
On Tue, 14 Sep 2021 09:46:21 GMT, Julia Boes wrote:
> This change adds some common types to the content-type.properties files,
> notably .js, .css, and .jar, as well as some others.
>
> The duplicated entry for .zip is removed from the Windows properties file.
This pull request
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 12 commits:
- Merge branch 'master' into simpleserver
- check
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
On Thu, 16 Sep 2021 18:06:53 GMT, Phil Race wrote:
> I don't understand why these files are platform-specific.
> And if each platform port does need one, where is the one for macOS ?
I'm not an expert in the area, it's probably down to historic reasons? The Unix
version would be for all Unix
On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> correct path handling
>
> src/jdk.httpserver/share/classes/modu
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote:
>> This change adds some common types to the content-type.properties files,
>> notably .js, .css, and .jar, as well as some others.
>>
>> The duplicated entry for .zip is removed from the Windows properties file.
&g
> This change adds some common types to the content-type.properties files,
> notably .js, .css, and .jar, as well as some others.
>
> The duplicated entry for .zip is removed from the Windows properties file.
Julia Boes has updated the pull request incrementally with one additi
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
correct path handling
-
Changes:
- all: https://git.openjd
On Tue, 14 Sep 2021 09:46:21 GMT, Julia Boes wrote:
> This change adds some common types to the content-type.properties files,
> notably .js, .css, and .jar, as well as some others.
>
> The duplicated entry for .zip is removed from the Windows properties file.
> _Mailing li
On Wed, 15 Sep 2021 03:14:04 GMT, Jaikiran Pai wrote:
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
> Thank you Florent, I wasn't aware of that.
related PR for reference:
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with three additional
commits since the last revision:
- small spec rewording
- add module main class to symbolgen
This change adds some common types to the content-type.properties files,
notably .js, .css, and .jar, as well as some others.
The duplicated entry for .zip is removed from the Windows properties file.
-
Commit messages:
- add basic test
- initial change
Changes:
On Tue, 14 Sep 2021 15:56:28 GMT, Jim Laskey wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Wed, 15 Sep 2021 07:49:38 GMT, Michael McMahon wrote:
>> Or maybe - which would be more accurate:
>>
>>
>> with the given {@code statusCode} and the body bytes' length (or {@code -1}
>> if the body is empty).
>
> I agree with your second suggestion. It's better not to refer to the
>
On Tue, 14 Sep 2021 16:45:08 GMT, Daniel Fuchs wrote:
>> Just a rewording, maybe.
>
> Hmm... Maye that should be "The response headers *are sent*". The non-obvious
> technical details is that the response headers are sent before the body - as
> soon as you call `sendResponseHeaders`. The link
On Tue, 14 Sep 2021 13:38:27 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line
>> 106:
>>
>>> 104: var h = headers.entrySet().stream()
>>> 105: .collect(Collectors.toUnmodifiableMap(
>>> 106:
On Tue, 14 Sep 2021 13:47:48 GMT, Andrey Turbanov
wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose
On Tue, 14 Sep 2021 15:42:06 GMT, Jaikiran Pai wrote:
>> src/java.base/windows/classes/sun/net/www/content-types.properties line 30:
>>
>>> 28: application/octet-stream: \
>>> 29: description=Generic Binary Stream;\
>>> 30:
This change implements a simple web server that can be run on the command-line
with `java -m jdk.httpserver`.
This is facilitated by adding an entry point for the `jdk.httpserver` module,
an implementation class whose main method is run when the above command is
executed. This is the first
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes wrote:
> This is a doc-only fix that improves the wording of the API doc of
> `getRequestHeaders()`. The other changes are trivial cleanup.
This pull request has now been integrated.
Changeset: 1c80f078
Author: Julia Boes
URL:
> This is a doc-only fix that improves the wording of the API doc of
> `getRequestHeaders()`. The other changes are trivial cleanup.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
small fix of tense
-
Changes:
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes wrote:
> This is a doc-only fix that improves the wording of the API doc of
> `getRequestHeaders()`. The other changes are trivial cleanup.
CSR https://bugs.openjdk.java.net/browse/JDK-8272565
-
PR: https://git.openjdk.java.n
This is a doc-only fix that improves the wording of the API doc of
`getRequestHeaders()`. The other changes are trivial cleanup.
-
Commit messages:
- cleanup
- Add note on multiple header fields
- initial commit
Changes: https://git.openjdk.java.net/jdk/pull/5100/files
Webrev:
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
This pull request has now been integrated.
Changeset: 685fc3c6
Author: Jul
On Wed, 4 Aug 2021 15:11:59 GMT, Daniel Fuchs wrote:
>> Have a marginal preference for HttpConnection.class.getSimpleName(), since
>> it is a constant, but don't object to getClass().
>
> Right - but then why not use a string literal? If you're going to call a
> method to get the class name
On Wed, 28 Jul 2021 17:23:51 GMT, Emmanuel Bourg
wrote:
>> @ebourg for future PRs please do not force push after the PR is out for
>> review. Just push incremental commits normally. The Skara tooling will
>> squash them all into a single commit.
>
> @kevinrushforth I'll do that, thank you for
This is a minor change that updates
`sun.net.httpserver.HttpConnection::toString` to never return null.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk/pull/4928/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4928=00
Issue:
On Thu, 15 Jul 2021 09:24:17 GMT, Julia Boes wrote:
> This is a cleanup fix that replaces the deprecated method
> `Class::newInstance()` with `cls.getDeclaredConstructor().newInstance()` when
> loading the provider.
This pull request has now been integrated.
Changeset: 50bb73
This is a cleanup fix that replaces the deprecated method
`Class::newInstance()` with `cls.getDeclaredConstructor().newInstance()` when
loading the provider.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk/pull/4789/files
Webrev:
On Fri, 2 Jul 2021 11:56:04 GMT, Julia Boes wrote:
> `com.sun.net.httpserver.HttpServer::createContext` specifies
> `IllegalArgumentException` to be thrown if a context already exists for the
> path provided. The implementation class`sun.net.httpserver.ServerImpl` does
>
`com.sun.net.httpserver.HttpServer::createContext` specifies
`IllegalArgumentException` to be thrown if a context already exists for the
path provided. The implementation class`sun.net.httpserver.ServerImpl` does not
comply with this, which is fixed by this change.
Testing: Tier 1-3 all clear.
On Fri, 2 Jul 2021 11:56:04 GMT, Julia Boes wrote:
> `com.sun.net.httpserver.HttpServer::createContext` specifies
> `IllegalArgumentException` to be thrown if a context already exists for the
> path provided. The implementation class`sun.net.httpserver.ServerImpl` does
>
On Fri, 18 Jun 2021 10:43:06 GMT, Julia Boes wrote:
> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
> following format: First character uppercase, all other characters lowercase,
> for example `"foo" -> "Foo"`. This behaviour is not
ype check and add a `toString()`
> implementation.
>
> Additionally, the Headers class is updated to disallow null values for keys
> and values.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
revert equals, update toStri
On Thu, 24 Jun 2021 15:15:07 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> confirm HttpExchange::sendResponseHeaders fails if key/value null
>
> src/jdk.httpse
ype check and add a `toString()`
> implementation.
>
> Additionally, the Headers class is updated to disallow null values for keys
> and values.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
confirm HttpExchange::sendR
ype check and add a `toString()`
> implementation.
>
> Additionally, the Headers class is updated to disallow null values for keys
> and values.
Julia Boes has updated the pull request incrementally with two additional
commits since the last revision:
- disallow
`com.sun.net.httpserver.Headers` normalizes its keys to adhere to the following
format: First character uppercase, all other characters lowercase, for example
`"foo" -> "Foo"`. This behaviour is not consistent across the mutator methods
of the class, in particular `putAll()` and `replaceAll()`
1 - 100 of 200 matches
Mail list logo
