Re: RFR: 8278028: [test-library] Warnings cleanup of the test library

2021-12-13 Thread Mandy Chung
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote: > Compilation warnings of the test library introduce noise in test output and > should be addressed or suppressed. > Changes include: > - SuppressWarnings("deprecation") and SuppressWarnings("removal") > - Adding type parameters to Raw types

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Fri, 19 Nov 2021 18:15:46 GMT, Brent Christian wrote: >> src/java.base/share/classes/java/lang/Object.java line 481: >> >>> 479: * system resources or to perform other cleanup. >>> 480: * >>> 481: * When running in a Java virtual machine in which finalization >>> has been >>

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Mandy Chung
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28

Re: RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

2021-05-18 Thread Mandy Chung
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote: > Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need > `-Djava.secu

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream

2021-03-22 Thread Mandy Chung
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote: > Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

2020-11-06 Thread Mandy Chung
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Marked as reviewed by mchung (Reviewer

Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Mandy Chung
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/814

Re: Fix for Javadoc errors in java.base

2020-08-18 Thread Mandy Chung
Looks fine. Thanks Mandy On 8/18/20 10:02 AM, Julia Boes wrote: Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/jav

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-17 Thread Mandy Chung
On 7/17/19 3:25 AM, Claes Redestad wrote: Hi Peter, On 2019-07-17 10:29, Peter Levart wrote: Hi Claes, Am I reading correct that package-private ClassLoader.loadLibrary(Class fromClass, String name, boolean isAbsolute) wouldn't need to consult SecurityManager wasn't it for accessing syst

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-16 Thread Mandy Chung
On 7/16/19 6:48 AM, Claes Redestad wrote: Hi, refactored to use a BootLoader::loadLibrary API that is only visible within the java.base module: http://cr.openjdk.java.net/~redestad/8227587/open.03/ Looks good. Nit:  in JavaLangAccess    321 void loadLibrary(Class klass, String librar

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-12 Thread Mandy Chung
wrap the call with doPriv; otherwise, just call the shared secret loadLibrary method. Then we can investigate in the future to refactor the native library loading implementation to jdk.internal.loader. what do you think? Mandy On 7/12/19 8:25 AM, Mandy Chung wrote: Claes, Thanks for exploring

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-12 Thread Mandy Chung
Claes, Thanks for exploring this.  I would like to see if we can avoid introducing an internal @CS method (keep @CSM only for public APIs will help security analysis). There are other alternatives to improve the footprint performance. One idea is java.base and java.desktop each has its own util

Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 7:52 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch that updates jdk.httpserver to use > System.Logger. > > As a result jdk.httpserver no longer requires java.logging. > > webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8157965/webrev.00 > issue: https:/

Re: Review request JDK-8165180: Provide a shared secret to access non-public ServerSocket constructor

2016-09-06 Thread Mandy Chung
> On Sep 5, 2016, at 12:19 AM, Peter Levart wrote: > > I'm thinking of the Class::getDeclaredConstructor method. > > If the implClass's class loader is not the bootstrap loader, > "accessDeclaredMembers" permission will be checked. I don't know about which > implClass(es) will be passed to th

Re: Review request JDK-8165180: Provide a shared secret to access non-public ServerSocket constructor

2016-09-02 Thread Mandy Chung
Impl() will do that? > > Regards, Peter > > On 08/31/2016 10:48 PM, Mandy Chung wrote: >> This patch introduces JavaNetSocketAccess to allow access to non-public >> ServerSocket constructor that is accessed by some other area as a clean up. >> >> Webrev: &

Review request JDK-8165180: Provide a shared secret to access non-public ServerSocket constructor

2016-08-31 Thread Mandy Chung
This patch introduces JavaNetSocketAccess to allow access to non-public ServerSocket constructor that is accessed by some other area as a clean up. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165180/webrev.00/ Mandy

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Mandy Chung
> On Apr 27, 2016, at 11:16 AM, Chris Hegarty wrote: > > > On 27 Apr 2016, at 17:27, Mandy Chung wrote: > >> >>> On Apr 27, 2016, at 2:04 AM, Chris Hegarty wrote: >>> >>> This works out quite nice. Webrev updated in-place: >>> h

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Mandy Chung
> On Apr 27, 2016, at 2:04 AM, Chris Hegarty wrote: > > This works out quite nice. Webrev updated in-place: > http://cr.openjdk.java.net/~chegar/8044773/jdk/ One comment on the qualified exports of sun.security.action.GetPropertyAction to jdk.net module. This is a simple utility method used

Re: RFR 8151281: Module java.httpclient could use System.Logger instead of PlatformLogger

2016-03-14 Thread Mandy Chung
> On Mar 14, 2016, at 6:41 AM, Daniel Fuchs wrote: > > Hi Mandy, > > On 06/03/16 00:01, Mandy Chung wrote: >> Hi Daniel, >> >>> On Mar 4, 2016, at 8:05 AM, Daniel Fuchs wrote: >>> >>> Please find below a patch for: >>> &

Re: RFR 8151281: Module java.httpclient could use System.Logger instead of PlatformLogger

2016-03-05 Thread Mandy Chung
Hi Daniel, > On Mar 4, 2016, at 8:05 AM, Daniel Fuchs wrote: > > Please find below a patch for: > > https://bugs.openjdk.java.net/browse/JDK-8151281 > 8151281: Module java.httpclient could use System.Logger > instead of PlatformLogger > > http://cr.openjdk.java.net/~dfuchs/webrev_81512

Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-08 Thread Mandy Chung
On 4/8/2014 6:15 AM, Chris Hegarty wrote: Updated webrev to include Mandy’s and Alan’s comments: http://cr.openjdk.java.net/~chegar/8039362/02/webrev/ Thanks for the update. line 238: I wonder if this should fall back to use the default built-in table - really minor one as this happens

Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Mandy Chung
On 4/7/14 11:54 AM, Chris Hegarty wrote: Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/ Thanks for doing this. Some minor comments: line 225: since content-types.properties is moved to the same package as MimeType class, you can simply use the relative path "conte

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread Mandy Chung
On 1/10/2014 7:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev: http://cr.openjdk.java.net/~rriggs/webrev-check-exceptio

hg: jdk8/tl/langtools: 8029216: (jdeps) Provide a specific option to report JDK internal APIs

2013-12-04 Thread mandy . chung
Changeset: 4a2ed1900428 Author:mchung Date: 2013-12-04 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a2ed1900428 8029216: (jdeps) Provide a specific option to report JDK internal APIs Reviewed-by: alanb ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! s

hg: jdk8/tl/jdk: 8029552: Remove java/lang/management/MemoryMXBean/CollectionUsageThreshold.java from ProblemList.txt

2013-12-04 Thread mandy . chung
Changeset: 4345e3e82c55 Author:mchung Date: 2013-12-04 13:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4345e3e82c55 8029552: Remove java/lang/management/MemoryMXBean/CollectionUsageThreshold.java from ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

2013-12-04 Thread mandy . chung
Changeset: a3b804e3d5f7 Author:mchung Date: 2013-12-04 09:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3b804e3d5f7 7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently Reviewed-by: mchung Contributed-by: yiming.w...@oracl

hg: jdk8/tl/jdk: 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt

2013-11-20 Thread mandy . chung
Changeset: 90e27a47ff28 Author:mchung Date: 2013-11-20 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90e27a47ff28 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Reviewed-by: sla, chegar ! test/ProblemList.txt ! test/sun/m

hg: jdk8/tl/jdk: 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt

2013-11-19 Thread mandy . chung
Changeset: 48c61808374f Author:mchung Date: 2013-11-19 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48c61808374f 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Reviewed-by: sla ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread mandy . chung
Changeset: 7c55fecfae65 Author:mchung Date: 2013-11-13 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c55fecfae65 8028234: Remove unused methods in sun.misc.JavaAWTAccess Reviewed-by: art, dfuchs, lancea ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/

hg: jdk8/tl/jdk: 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-08 Thread mandy . chung
Changeset: 40ca9e4866de Author:mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! m

hg: jdk8/tl/jdk: 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351

2013-11-08 Thread mandy . chung
Changeset: 1c9ba18198d5 Author:mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c

hg: jdk8/tl/jdk: 8027351: (ref) Private finalize method invoked in preference to protected superclass method

2013-11-08 Thread mandy . chung
Changeset: 41d7ce111bd8 Author:mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles

hg: jdk8/tl/corba: 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45

2013-11-07 Thread mandy . chung
Changeset: b99535e22efe Author:mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! s

hg: jdk8/tl/jdk: 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java; ...

2013-11-05 Thread mandy . chung
Changeset: 85fd2ae0a845 Author:mchung Date: 2013-11-05 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85fd2ae0a845 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java 6944188: ThreadMXBean/ThreadStateTest.java fails intermittently Reviewed-by: d

hg: jdk8/tl/langtools: 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.*

2013-10-30 Thread mandy . chung
Changeset: aa91bc6e8480 Author:mchung Date: 2013-10-30 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa91bc6e8480 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.* Reviewed-by: alanb, dfuchs ! src/share/classes/c

hg: jdk8/tl/jdk: 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided

2013-10-17 Thread mandy . chung
Changeset: 042a473535aa Author:mchung Date: 2013-10-17 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/042a473535aa 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided Reviewed-by: alanb, forax, dholmes, twisti ! makefiles/ma

hg: jdk8/tl/jdk: 8015912: jdeps support to output in dot file format; ...

2013-10-17 Thread mandy . chung
Changeset: 3735d81552a7 Author:mchung Date: 2013-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3735d81552a7 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! test/sun/reflect/Ca

hg: jdk8/tl/langtools: 8015912: jdeps support to output in dot file format; ...

2013-10-17 Thread mandy . chung
Changeset: defadd528513 Author:mchung Date: 2013-10-17 13:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/defadd528513 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! src/share/cla

hg: jdk8/tl/jdk: 8026027: Level.parse should return the custom Level instance instead of the mirrored Level

2013-10-09 Thread mandy . chung
Changeset: cf6e39cfdf50 Author:mchung Date: 2013-10-09 06:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf6e39cfdf50 8026027: Level.parse should return the custom Level instance instead of the mirrored Level Reviewed-by: dfuchs, chegar ! src/share/classes/java/util/logg

hg: jdk8/tl/jdk: 8014890: (ref) Reference queues may return more entries than expected

2013-07-12 Thread mandy . chung
Changeset: 858c75eb83b5 Author:mchung Date: 2013-07-08 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858c75eb83b5 8014890: (ref) Reference queues may return more entries than expected Summary: When enqueuing references check whether the j.l.r.Reference has already bee

hg: jdk8/tl/jdk: 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which)

2013-07-02 Thread mandy . chung
Changeset: cf7202b32a34 Author:mchung Date: 2013-07-02 15:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf7202b32a34 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which) Reviewed-by: jrose, alanb, dfuchs ! src/share/classes/java/lang/

hg: jdk8/tl/jdk: 8016117: New sun.misc.FDBigInteger class as part of 7032154

2013-06-06 Thread mandy . chung
Changeset: f5f54e493a64 Author:bpb Date: 2013-06-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5f54e493a64 8016117: New sun.misc.FDBigInteger class as part of 7032154 Reviewed-by: martin, iris Contributed-by: Sergey Kuksenko , Brian Burkhalter , Dmitry Nadezhin ,

hg: jdk8/tl/jdk: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

2013-06-06 Thread mandy . chung
Changeset: 986793409b2b Author:bpb Date: 2013-06-05 21:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/986793409b2b 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal Summary: Performance improvements for double/float -> String and decimal/hex

hg: jdk8/tl/jdk: 8014097: add doPrivileged methods with limited privilege scope

2013-06-04 Thread mandy . chung
Changeset: bd84bad9ee99 Author:jdn Date: 2013-06-04 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84bad9ee99 8014097: add doPrivileged methods with limited privilege scope Reviewed-by: mchung ! src/share/classes/java/security/AccessControlContext.java ! src/share/cl

hg: jdk8/tl/jdk: 4487672: (proxy) Proxy constructor should check for null argument

2013-05-16 Thread mandy . chung
Changeset: 5e8959ab64af Author:mchung Date: 2013-05-16 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8959ab64af 4487672: (proxy) Proxy constructor should check for null argument Reviewed-by: alanb, lancea ! src/share/classes/java/lang/reflect/Proxy.java ! test/java/

hg: jdk8/tl/langtools: 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references

2013-04-30 Thread mandy . chung
Changeset: 57648bad3287 Author:mchung Date: 2013-04-30 15:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57648bad3287 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! src/share/classes/com/sun/tools/cl

hg: jdk8/tl/jdk: 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references

2013-04-30 Thread mandy . chung
Changeset: 4a82d2b86c75 Author:mchung Date: 2013-04-30 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a82d2b86c75 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! test/sun/reflect/CallerSensitive/CallerS

hg: jdk8/tl/jdk: 7123493: (proxy) Proxy.getProxyClass doesn't scale under high load

2013-04-26 Thread mandy . chung
Changeset: 5e7ae178b24d Author:plevart Date: 2013-04-26 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e7ae178b24d 7123493: (proxy) Proxy.getProxyClass doesn't scale under high load Reviewed-by: mchung ! src/share/classes/java/lang/reflect/Proxy.java + src/share/class

hg: jdk8/tl/jdk: 8010939: Deadlock in LogManager

2013-04-19 Thread mandy . chung
Changeset: e8f1dc6d0c0c Author:jgish Date: 2013-04-19 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8f1dc6d0c0c 8010939: Deadlock in LogManager Summary: re-order locks to avoid deadlock Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java + test/

hg: jdk8/tl/jdk: 8012005: LogManager needs test to ensure stack trace is not being done to find bundle

2013-04-18 Thread mandy . chung
Changeset: 3e4a0fddeb00 Author:jgish Date: 2013-04-18 16:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e4a0fddeb00 8012005: LogManager needs test to ensure stack trace is not being done to find bundle Reviewed-by: mchung + test/java/util/logging/bundlesearch/ClassPathT

hg: jdk8/tl/jdk: 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters

2013-04-18 Thread mandy . chung
Changeset: 3b81fac25d26 Author:mchung Date: 2013-04-18 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b81fac25d26 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters Reviewed-by: mchung Contributed-by: Yasumasa Suenaga ! src/share/classes/su

hg: jdk8/tl/jdk: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

2013-04-18 Thread mandy . chung
Changeset: 32c3a580812b Author:mchung Date: 2013-04-18 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32c3a580812b 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt Reviewed-by: lancea, alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces

2013-04-17 Thread mandy . chung
Changeset: 73e3b474125e Author:mchung Date: 2013-04-17 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73e3b474125e 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces Reviewed-by: alanb, jrose, jdn ! src/share/classes/java/la

hg: jdk8/tl/nashorn: 8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive

2013-04-16 Thread mandy . chung
Changeset: 222a72df2f42 Author:mchung Date: 2013-04-16 22:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/222a72df2f42 8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive Reviewed-by: jrose, alanb, twisti, sundar ! src/jdk/nashorn/api/scrip

hg: jdk8/tl/jdk: 8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive

2013-04-16 Thread mandy . chung
Changeset: da6addef956e Author:mchung Date: 2013-04-16 21:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da6addef956e 8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive Reviewed-by: jrose, alanb, twisti ! make/java/java/FILES_c.gmk ! make/jav

hg: jdk8/tl/jdk: 8011380: FX dependency on PlatformLogger broken by 8010309

2013-04-05 Thread mandy . chung
Changeset: b62a76763bf3 Author:mchung Date: 2013-04-05 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b62a76763bf3 8011380: FX dependency on PlatformLogger broken by 8010309 Reviewed-by: alanb ! src/share/classes/java/util/logging/LoggingProxyImpl.java ! src/share/clas

hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

2013-03-28 Thread mandy . chung
Changeset: e433ed08b733 Author:mchung Date: 2013-03-28 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level Reviewed-by: mchung Contributed-by: peter.lev...@gmail.c

hg: jdk8/tl/jdk: 8010787: changeset for 8007703 is missing the deleted files

2013-03-25 Thread mandy . chung
Changeset: 335d2156222e Author:mchung Date: 2013-03-25 18:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/335d2156222e 8010787: changeset for 8007703 is missing the deleted files Reviewed-by: dholmes, alanb, erikj - make/com/sun/servicetag/Makefile - src/share/classes/com/

hg: jdk8/tl/jdk: 8007703: Remove com.sun.servicetag API

2013-03-25 Thread mandy . chung
Changeset: 5e383a73386a Author:mchung Date: 2013-03-25 17:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e383a73386a 8007703: Remove com.sun.servicetag API Reviewed-by: dholmes, alanb, erikj ! make/com/sun/Makefile ! make/common/Release.gmk ! makefiles/CopyFiles.gmk ! ma

hg: jdk8/tl/jdk: 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration

2013-03-20 Thread mandy . chung
Changeset: ccd9f53377c4 Author:mchung Date: 2013-03-20 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccd9f53377c4 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration Reviewed-by: alanb ! test/java/util/logging/CustomLogManage

hg: jdk8/tl/langtools: 8005428: Update jdeps to read the same profile information as by javac

2013-03-14 Thread mandy . chung
Changeset: fd3fdaff0257 Author:mchung Date: 2013-03-14 10:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd3fdaff0257 8005428: Update jdeps to read the same profile information as by javac Reviewed-by: alanb ! make/netbeans/langtools/nbproject/project.xml ! src/shar

hg: jdk8/tl/jdk: 8002070: Remove the stack search for a resource bundle for Logger to use

2013-03-13 Thread mandy . chung
Changeset: 94335b6ffb32 Author:jgish Date: 2013-03-13 11:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32 8002070: Remove the stack search for a resource bundle for Logger to use Summary: The fragile, vulnerable, stack crawling has been eliminated from findReso

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

2013-02-21 Thread Mandy Chung
On 2/21/2013 10:46 AM, Alan Bateman wrote: Joe Darcy recently added @jdk.Supported [1] to make it possible to identify JDK-specific APIs. I'd like to add this to a number of APIs in the com.sun namespace to make it obvious these are "supported". It's nice to be able to mark what is suppor

hg: jdk8/tl/jdk: 8007736: VerifyError for use of static method in interface

2013-02-14 Thread mandy . chung
Changeset: 1405ad6afb1e Author:bharadwaj Date: 2013-02-14 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1405ad6afb1e 8007736: VerifyError for use of static method in interface Reviewed-by: mchung ! src/share/native/common/check_code.c + test/vm/verifier/TestStaticIF.j

hg: jdk8/tl/langtools: 8006225: tools/jdeps/Basic.java failes with AssertionError

2013-02-14 Thread mandy . chung
Changeset: 88286a36bb34 Author:mchung Date: 2013-02-14 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/88286a36bb34 8006225: tools/jdeps/Basic.java failes with AssertionError Reviewed-by: alanb + src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/clas

hg: jdk8/tl/jdk: 6355704: (fmt) %f formatting of BigDecimals is incorrect

2013-01-31 Thread mandy . chung
Changeset: a09a37cff333 Author:mchung Date: 2013-01-31 14:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a09a37cff333 6355704: (fmt) %f formatting of BigDecimals is incorrect Reviewed-by: darcy Contributed-by: brian.burkhal...@oracle.com ! test/java/util/Formatter/Basic-X

hg: jdk8/tl/jdk: 7103957: NegativeArraySizeException while initializing class IntegerCache

2013-01-09 Thread mandy . chung
Changeset: 4c8b37f159f9 Author:mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhal...@oracle.com ! src/sha

hg: jdk8/tl/langtools: 8003562: Provide a CLI tool to analyze class dependencies

2012-12-28 Thread mandy . chung
Changeset: 0c244701188e Author:mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtool

hg: jdk8/tl: 8003562: Provide a CLI tool to analyze class dependencies

2012-12-28 Thread mandy . chung
Changeset: c37401e77c80 Author:mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl

hg: jdk8/tl/langtools: 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init

2012-12-17 Thread mandy . chung
Changeset: ef537bcc825a Author:mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.j

hg: jdk8/tl/jdk: 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html

2012-12-10 Thread mandy . chung
Changeset: cac1bfaceaaa Author:mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description

hg: jdk8/tl/jdk: 2 new changesets

2012-11-28 Thread mandy . chung
Changeset: 09bef1e118e3 Author:mchung Date: 2012-11-28 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09bef1e118e3 8003851: MethodHandleNatives dependency on java.sql.DriverManager Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/MethodHandleNatives.jav

hg: jdk8/tl/jdk: 7178922: (props) re-visit how os.name is determined on Mac

2012-11-16 Thread mandy . chung
Changeset: 6f20caa6e1e9 Author:bchristi Date: 2012-11-16 17:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f20caa6e1e9 7178922: (props) re-visit how os.name is determined on Mac Reviewed-by: alanb, mchung, skovatch, serb ! src/solaris/native/java/lang/java_props_macosx.c

hg: jdk8/tl/jdk: 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread mandy . chung
Changeset: 6156b9235758 Author:mchung Date: 2012-10-17 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6156b9235758 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Reviewed-by: alanb, ohair ! make/common/internal/Defs-jaxws.gmk

hg: jdk8/tl/jdk: 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-18 Thread mandy . chung
Changeset: 045a0962b430 Author:mchung Date: 2012-09-18 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/045a0962b430 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties Reviewed-by: alanb ! src/share/classes/com/sun/jmx/mbeanserver/DefaultM

hg: jdk8/tl/jdk: 7193302: Remove ConstructorProperties annotation from java.lang.management.LockInfo

2012-09-14 Thread mandy . chung
Changeset: 22d7a9f73a59 Author:mchung Date: 2012-09-14 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22d7a9f73a59 7193302: Remove ConstructorProperties annotation from java.lang.management.LockInfo Reviewed-by: alanb, sla, egahlin ! src/share/classes/java/lang/manage

hg: jdk8/tl/jdk: 7193339: Prepare system classes be defined by a non-null module loader

2012-08-24 Thread mandy . chung
Changeset: d52081a08d11 Author:mchung Date: 2012-08-24 22:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d52081a08d11 7193339: Prepare system classes be defined by a non-null module loader Reviewed-by: alanb, dholmes, dsamersoff, sspitsyn, psandoz ! src/share/classes/com/

hg: jdk8/tl/jdk: 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary

2012-05-01 Thread mandy . chung
Changeset: 46e0bd218fcc Author:mchung Date: 2012-05-01 19:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e0bd218fcc 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Reviewed-by: alanb, mullan, prr ! src/macosx/classes/apple/launcher

hg: jdk8/tl/jdk: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-17 Thread mandy . chung
Changeset: 2f096eb72520 Author:mchung Date: 2012-01-17 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f096eb72520 7117570: Warnings in sun.mangement.* and its subpackages Reviewed-by: mchung, dsamersoff Contributed-by: kurchi.subhra.ha...@oracle.com ! src/share/classe

hg: jdk8/tl/jdk: 7117585: Eliminate java.lang.instrument, java.lang.management warnings

2011-12-02 Thread mandy . chung
Changeset: 98502d7a3f98 Author:mchung Date: 2011-12-02 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98502d7a3f98 7117585: Eliminate java.lang.instrument, java.lang.management warnings Reviewed-by: mchung Contributed-by: Jon VanAlten ! src/share/classes/java/lang/ins

hg: jdk8/tl/jdk: 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently

2011-11-17 Thread mandy . chung
Changeset: 3cd7dcf4a302 Author:mchung Date: 2011-11-17 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cd7dcf4a302 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung Contributed-by: gary.ad...@or

hg: jdk8/tl/jdk: 6915797: Remove sun.tools.jar.JarImageSource that is not used; ...

2011-09-14 Thread mandy . chung
Changeset: 04672e957da0 Author:mchung Date: 2011-09-14 08:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04672e957da0 6915797: Remove sun.tools.jar.JarImageSource that is not used 7090178: Move java.util.XMLUtils to another package to avoid split package Reviewed-by: alanb

hg: jdk8/tl/langtools: 7090297: Remove com.sun.tools.javac.Launcher from tools.jar

2011-09-13 Thread mandy . chung
Changeset: ca2e2b85f437 Author:mchung Date: 2011-09-13 16:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca2e2b85f437 7090297: Remove com.sun.tools.javac.Launcher from tools.jar Reviewed-by: jjg - src/share/classes/com/sun/tools/javac/Launcher.java

hg: jdk8/tl/jdk: 7078024: Update JDK service tag for JDK 8

2011-09-07 Thread mandy . chung
Changeset: be949e12cab0 Author:mchung Date: 2011-09-07 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be949e12cab0 7078024: Update JDK service tag for JDK 8 Reviewed-by: paulk ! make/com/sun/servicetag/Makefile ! src/share/classes/com/sun/servicetag/Installer.java + sr

hg: jdk8/tl/jdk: 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return null

2011-08-23 Thread mandy . chung
Changeset: 4e53fc6bcac0 Author:mchung Date: 2011-08-23 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e53fc6bcac0 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return null Reviewed-by: alanb Contributed-by: spo...@uk.ibm.com ! src/share/classe

hg: jdk8/tl/jdk: 2 new changesets

2011-08-08 Thread mandy . chung
Changeset: 0f1b4b3bc833 Author:mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/bas

hg: jdk7/tl/jdk: 7039809: Remove @ConstructorProperties annotation from java.io.File class

2011-04-29 Thread mandy . chung
Changeset: 24ad188dc46c Author:mchung Date: 2011-04-29 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24ad188dc46c 7039809: Remove @ConstructorProperties annotation from java.io.File class Reviewed-by: alanb, malenkov ! src/share/classes/java/io/File.java - test/java/b

hg: jdk7/tl/langtools: 7037081: Remove com.sun.tracing from NON_CORE_PKGS

2011-04-28 Thread mandy . chung
Changeset: c7841bbe1227 Author:mchung Date: 2011-04-28 08:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c7841bbe1227 7037081: Remove com.sun.tracing from NON_CORE_PKGS Reviewed-by: ohair, jjg, jmasa ! src/share/classes/com/sun/tools/javac/resources/legacy.propertie

hg: jdk7/tl/jdk: 7037081: Remove com.sun.tracing from NON_CORE_PKGS

2011-04-28 Thread mandy . chung
Changeset: c3f5333e10e3 Author:mchung Date: 2011-04-28 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c3f5333e10e3 7037081: Remove com.sun.tracing from NON_CORE_PKGS Reviewed-by: ohair, jjg, jmasa ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk

hg: jdk7/tl/jdk: 6381464: SimpleFormatter should use one single line format

2011-04-26 Thread mandy . chung
Changeset: d2bbdd709307 Author:mchung Date: 2011-03-29 15:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d2bbdd709307 6381464: SimpleFormatter should use one single line format Summary: Define a new logging properties to support custom output format Reviewed-by: alanb ! s

hg: jdk7/tl/jdk: 7032589: FileHandler leaking file descriptor of the file lock

2011-04-15 Thread mandy . chung
Changeset: 54d9513f87a4 Author:mchung Date: 2011-04-15 23:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/54d9513f87a4 7032589: FileHandler leaking file descriptor of the file lock Reviewed-by: forax, dcubed ! src/share/classes/java/util/logging/FileHandler.java

hg: jdk7/tl/jdk: 7024172: Move BufferPoolMXBean and PlatformLoggingMXBean java.lang.management

2011-03-29 Thread mandy . chung
Changeset: 3e001dd50408 Author:mchung Date: 2011-03-29 15:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e001dd50408 7024172: Move BufferPoolMXBean and PlatformLoggingMXBean java.lang.management Reviewed-by: alanb + src/share/classes/java/lang/management/BufferPoolMXBean

hg: jdk7/tl/jdk: 7016707: Remove the BootClassLoaderHook for jkernel support

2011-02-25 Thread mandy . chung
Changeset: 5dc98de2a35e Author:mchung Date: 2011-02-25 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5dc98de2a35e 7016707: Remove the BootClassLoaderHook for jkernel support Reviewed-by: alanb, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/awt/color/I

hg: jdk7/tl/jdk: 7021939: com.oracle.net is not a NON_CORE_PKGS

2011-02-25 Thread mandy . chung
Changeset: 32dc1cb2b995 Author:mchung Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32dc1cb2b995 7021939: com.oracle.net is not a NON_CORE_PKGS Reviewed-by: ohair, alanb ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk

hg: jdk7/tl/jdk: 2 new changesets

2011-01-21 Thread mandy . chung
Changeset: f26d1a7fe4d2 Author:mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h ! src/sha

hg: jdk7/tl/jdk: 7013739: jdk_rmi target is missing in the top repo's test/Makefile

2011-01-20 Thread mandy . chung
Changeset: cc195c981ae2 Author:mchung Date: 2011-01-20 22:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cc195c981ae2 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/ProblemList.txt

hg: jdk7/tl: 7013739: jdk_rmi target is missing in the top repo's test/Makefile

2011-01-20 Thread mandy . chung
Changeset: f722c246ce71 Author:mchung Date: 2011-01-20 22:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f722c246ce71 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/Makefile

hg: jdk7/tl/jdk: 6977034: Thread.getState() very slow

2010-12-08 Thread mandy . chung
Changeset: acce526a49a7 Author:mchung Date: 2010-12-08 10:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/acce526a49a7 6977034: Thread.getState() very slow Summary: Directly map the threadStatus value to Thread.State Reviewed-by: emcmanus, dholmes ! src/share/classes/java/

  1   2   >