Re: RFR: 8263561: Re-examine uses of LinkedList

2021-05-21 Thread Maurizio Cimadamore
On Fri, 21 May 2021 14:22:47 GMT, Daniel Fuchs wrote: >> The usage of `LinkedList` is senseless and can be replaced with either >> `ArrayList` or `ArrayDeque` which are both more compact and effective. >> >> jdk:tier1 and jdk:tier2 are both ok > > I don't remember all the comments you have rece

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Maurizio Cimadamore
On Mon, 15 Feb 2021 18:33:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Ref

hg: jdk8/tl/langtools: 2 new changesets

2013-08-16 Thread maurizio . cimadamore
Changeset: ec77c7b46c37 Author:jlahoda Date: 2013-08-15 22:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec77c7b46c37 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression Summary: Producing individual errors for uncaught unde

hg: jdk8/tl/langtools: 2 new changesets

2013-08-12 Thread maurizio . cimadamore
Changeset: f7f271bd74a2 Author:mcimadamore Date: 2013-08-12 17:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f7f271bd74a2 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods) Summary: Hiding check does not

hg: jdk8/tl/langtools: 8020689: Missing LineNumberTable entries in compiled class files

2013-07-29 Thread maurizio . cimadamore
Changeset: 8c4b2987edac Author:jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac 8020689: Missing LineNumberTable entries in compiled class files Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.j

hg: jdk8/tl/langtools: 8021338: Diamond finder may mark a required type argument as unnecessary

2013-07-29 Thread maurizio . cimadamore
Changeset: cd9e8cea1b3c Author:jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd9e8cea1b3c 8021338: Diamond finder may mark a required type argument as unnecessary Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr

hg: jdk8/tl/langtools: 3 new changesets

2013-07-25 Thread maurizio . cimadamore
Changeset: 3155e77d2676 Author:mcimadamore Date: 2013-07-25 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676 8020804: javac crashes when speculative attribution infers intersection type with array component Summary: Assertion is causing javac to crash

hg: jdk8/tl/langtools: 8020586: Warning produced for an incorrect file

2013-07-17 Thread maurizio . cimadamore
Changeset: 10711bd8bb2d Author:jlahoda Date: 2013-07-17 15:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d 8020586: Warning produced for an incorrect file Summary: Always using DeferredLintHandler.immediateHandler when processing import classes Reviewed-

hg: jdk8/tl/langtools: 10 new changesets

2013-07-17 Thread maurizio . cimadamore
Changeset: 44e27378f523 Author:mcimadamore Date: 2013-07-17 14:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523 8012242: Lambda compatibility and checked exceptions Summary: Inference variables in 'throws' clause with no constraints should be inferred as

hg: jdk8/tl/langtools: 8013404: Unclear spec for target typing with conditional operator (?:)

2013-07-11 Thread maurizio . cimadamore
Changeset: 87a951c88a33 Author:mcimadamore Date: 2013-07-11 15:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87a951c88a33 8013404: Unclear spec for target typing with conditional operator (?:) Summary: Fix previously ignored test Reviewed-by: jjg, vromero ! test/to

hg: jdk8/tl/langtools: 5 new changesets

2013-07-05 Thread maurizio . cimadamore
Changeset: 7b756b307e12 Author:mcimadamore Date: 2013-07-05 11:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7b756b307e12 8017618: NullPointerException in RichDiagnosticFormatter for bad input program Summary: RDF crashes when diagnostic contains type 'void' Reviewe

hg: jdk8/tl/langtools: 7034798: Ambiguity error for abstract method call is too eager

2013-07-01 Thread maurizio . cimadamore
Changeset: f559ef7568ce Author:mcimadamore Date: 2013-07-01 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f559ef7568ce 7034798: Ambiguity error for abstract method call is too eager Summary: Javac should wait and see if ambiguous methods can be reconciled at the

hg: jdk8/tl/langtools: 8013576: Add stat support to LambdaToMethod

2013-06-10 Thread maurizio . cimadamore
Changeset: 3582b62dccb2 Author:mcimadamore Date: 2013-06-10 15:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3582b62dccb2 8013576: Add stat support to LambdaToMethod Summary: LambdaToMethod should emit info to help diagnose/test lambda metafactory problems Reviewed

hg: jdk8/tl/langtools: 6 new changesets

2013-06-06 Thread maurizio . cimadamore
Changeset: 6e30a513c945 Author:mcimadamore Date: 2013-06-06 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e30a513c945 6360970: javac erroneously accept ambiguous field reference Summary: clash between ambiguous fields in superinterface and unambiguous field in

hg: jdk8/tl/langtools: 3 new changesets

2013-06-04 Thread maurizio . cimadamore
Changeset: 5cd3cb69c8b3 Author:mcimadamore Date: 2013-06-04 11:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5cd3cb69c8b3 7116676: RichDiagnosticFormatter throws NPE when formatMessage is called directly Summary: Fix NPE in RichDiagnosticFormatter.formatMessage Rev

hg: jdk8/tl/langtools: 3 new changesets

2013-05-24 Thread maurizio . cimadamore
Changeset: 58329d9f6b68 Author:mcimadamore Date: 2013-05-24 15:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68 8014643: Parser regression in JDK 8 when compiling super.x Summary: Fixed latent bug in JavacParser.analyzeParens() Reviewed-by: jjg, vromero !

hg: jdk8/tl/langtools: 3 new changesets

2013-05-15 Thread maurizio . cimadamore
Changeset: 05ec778794d0 Author:mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention error

hg: jdk8/tl/langtools: 6 new changesets

2013-04-15 Thread maurizio . cimadamore
Changeset: b26f36a7ae3b Author:mcimadamore Date: 2013-04-15 14:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b26f36a7ae3b 8011383: Symbol.getModifiers omits ACC_ABSTRACT from interface with default methods Summary: Fixup for default method modifiers erroneously app

hg: jdk8/tl/langtools: 5 new changesets

2013-04-08 Thread maurizio . cimadamore
Changeset: b71a61d39cf7 Author:mcimadamore Date: 2013-04-08 15:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b71a61d39cf7 8010922: Cleanup: add support for ad-hoc method check logic Summary: Support pluggable method checkers Reviewed-by: jjg ! src/share/classes/com

hg: jdk8/tl/langtools: 2 new changesets

2013-03-28 Thread maurizio . cimadamore
Changeset: 7bebe17ff323 Author:mcimadamore Date: 2013-03-28 11:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bebe17ff323 8010469: Bad assertion in LambdaToMethod Summary: Add assertion in LambdaToMethod.serializedLambdaName Reviewed-by: jjg ! src/share/classes/com

hg: jdk8/tl/langtools: 5 new changesets

2013-03-22 Thread maurizio . cimadamore
Changeset: cc38a6723663 Author:mcimadamore Date: 2013-03-22 12:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc38a6723663 8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods Summary: Private lambda methods

hg: jdk8/tl/langtools: 2 new changesets

2013-03-12 Thread maurizio . cimadamore
Changeset: 6db9a3b1a93f Author:mcimadamore Date: 2013-03-12 16:02 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6db9a3b1a93f 8008540: Constructor reference to non-reifiable array should be rejected 8008539: Spurious error when constructor reference mention an interface

hg: jdk8/tl/langtools: 3 new changesets

2013-03-06 Thread maurizio . cimadamore
Changeset: d0178bd8125c Author:mcimadamore Date: 2013-03-06 15:29 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c 8009299: Javac crashes when compiling method reference to static interface method Summary: Assertion in Check.checMethod is too strict Reviewed

hg: jdk8/tl/langtools: 4 new changesets

2013-03-05 Thread maurizio . cimadamore
Changeset: 69cd2bfd4a31 Author:mcimadamore Date: 2013-03-05 14:04 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/69cd2bfd4a31 8004962: Code generation crash with lambda and local classes Summary: Translation info should be propagated from LambdaToMethod to Lower Reviewe

hg: jdk8/tl/langtools: 3 new changesets

2013-02-28 Thread maurizio . cimadamore
Changeset: 133a0a0c2cbc Author:mcimadamore Date: 2013-02-28 14:00 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133a0a0c2cbc 8008723: Graph Inference: bad graph calculation leads to assertion error Summary: Dependencies are not propagated correctly through merged nodes

hg: jdk8/tl/langtools: 8008708: Regression: separate compilation causes crash in wildcards inference logic

2013-02-22 Thread maurizio . cimadamore
Changeset: 94e67bed460d Author:mcimadamore Date: 2013-02-22 18:19 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/94e67bed460d 8008708: Regression: separate compilation causes crash in wildcards inference logic Summary: Invalid use of WildcardType.bound in Types.removeW

hg: jdk8/tl/langtools: 8008337: Write test to check for compiler error when static method in interface is called via super()

2013-02-22 Thread maurizio . cimadamore
Changeset: 8e82e4f225e4 Author:mcimadamore Date: 2013-02-22 13:31 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e82e4f225e4 8008337: Write test to check for compiler error when static method in interface is called via super() Reviewed-by: mcimadamore Contributed-by:

hg: jdk8/tl/langtools: 6 new changesets

2013-02-21 Thread maurizio . cimadamore
Changeset: d686d8a7eb78 Author:mcimadamore Date: 2013-02-21 15:19 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d686d8a7eb78 8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler Summary: Disentangle cyclic dependency between static-ness of syn

hg: jdk8/tl/langtools: 8008309: TargetType60 fails because of bad golden file

2013-02-15 Thread maurizio . cimadamore
Changeset: da2f7dd53915 Author:mcimadamore Date: 2013-02-15 18:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/da2f7dd53915 8008309: TargetType60 fails because of bad golden file Summary: bad golden file Reviewed-by: jjg ! test/tools/javac/lambda/TargetType60.out

hg: jdk8/tl/langtools: 6 new changesets

2013-02-15 Thread maurizio . cimadamore
Changeset: 0baaae675b19 Author:mcimadamore Date: 2013-02-15 16:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0baaae675b19 8006749: compiler does not allow Object protected methods to be used in lambda Summary: Check.checkFunctionalInterface should take into account

hg: jdk8/tl/langtools: 8006345: Report Synthesized Parameters in java.lang.reflect.Parameter API; ...

2013-02-13 Thread maurizio . cimadamore
Changeset: d04960f05593 Author:mcimadamore Date: 2013-02-13 17:04 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d04960f05593 8006345: Report Synthesized Parameters in java.lang.reflect.Parameter API 8006896: ClassReader doesn't see MethodParameters attr for method of a

hg: jdk8/tl/langtools: 8007464: Add graph inference support

2013-02-12 Thread maurizio . cimadamore
Changeset: 2154ed9ff6c8 Author:mcimadamore Date: 2013-02-12 19:25 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2154ed9ff6c8 8007464: Add graph inference support Summary: Add support for more aggressive type-inference scheme Reviewed-by: jjg ! src/share/classes/com/su

hg: jdk8/tl/langtools: 2 new changesets

2013-02-06 Thread maurizio . cimadamore
Changeset: 1df20330f6bd Author:mcimadamore Date: 2013-02-06 14:03 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1df20330f6bd 8007463: Cleanup inference related classes Summary: Make Infer.InferenceContext an inner class; adjust bound replacement logic in Type.UndetVar

hg: jdk8/tl/langtools: 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile

2013-01-23 Thread maurizio . cimadamore
Changeset: 97bd5e7151bc Author:mcimadamore Date: 2013-01-23 15:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-

hg: jdk8/tl/langtools: 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack

2013-01-22 Thread maurizio . cimadamore
Changeset: b61e5f801f7c Author:mcimadamore Date: 2013-01-22 16:39 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b61e5f801f7c 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack Summary: Lambda desugaring generates spurious references to 'this' i

hg: jdk8/tl/langtools: 8006673: TargetType52 fails because of bad golden file

2013-01-22 Thread maurizio . cimadamore
Changeset: be443002e970 Author:mcimadamore Date: 2013-01-22 16:23 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be443002e970 8006673: TargetType52 fails because of bad golden file Summary: Fix golden file in negative test Reviewed-by: jjg ! test/tools/javac/lambda/Tar

hg: jdk8/tl/langtools: 4 new changesets

2013-01-21 Thread maurizio . cimadamore
Changeset: 7873d37f5b37 Author:mcimadamore Date: 2013-01-21 20:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-

hg: jdk8/tl/langtools: 8006561: Langtools test failure: missing diags/examples

2013-01-18 Thread maurizio . cimadamore
Changeset: 3d84ae209919 Author:mcimadamore Date: 2013-01-18 15:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/Unde

hg: jdk8/tl/langtools: 8005852: Treatment of '_' as identifier

2013-01-17 Thread maurizio . cimadamore
Changeset: 2d2b2be57c78 Author:mcimadamore Date: 2013-01-17 18:15 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/

hg: jdk8/tl/langtools: 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure

2013-01-16 Thread maurizio . cimadamore
Changeset: 1afdf1f1472b Author:mcimadamore Date: 2013-01-16 17:40 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1afdf1f1472b 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure Summary: Wrong implementation of ResolveError.access

hg: jdk8/tl/langtools: 2 new changesets

2013-01-16 Thread maurizio . cimadamore
Changeset: f785dcac17b7 Author:mcimadamore Date: 2013-01-16 16:27 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f785dcac17b7 8005854: Add support for array constructor references Summary: Support constructor references of the kind int[]::new Reviewed-by: jjg ! src/sha

hg: jdk8/tl/langtools: 3 new changesets

2013-01-08 Thread maurizio . cimadamore
Changeset: 38d3d1027f5a Author:mcimadamore Date: 2013-01-08 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38d3d1027f5a 8005243: Restructure method check code to allow pluggable checkers Summary: Add interface to perform a method check - to be implemented by helpe

hg: jdk8/tl/langtools: 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails

2012-12-18 Thread maurizio . cimadamore
Changeset: 250f0acf880c Author:mcimadamore Date: 2012-12-18 22:16 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! tes

hg: jdk8/tl/langtools: 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method

2012-12-17 Thread maurizio . cimadamore
Changeset: f20568328a57 Author:mcimadamore Date: 2012-12-17 16:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use

hg: jdk8/tl/langtools: 8004094: Javac compiler error - synthetic method accessor generated with duplicate name

2012-12-10 Thread maurizio . cimadamore
Changeset: c78acf6c2f3e Author:mcimadamore Date: 2012-12-10 12:10 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods m

hg: jdk8/tl/langtools: 8004360: regression test DefaultMethodRegressionTests fails in langtools

2012-12-04 Thread maurizio . cimadamore
Changeset: 0e70eb71fec0 Author:mcimadamore Date: 2012-12-04 17:19 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg - test/tools/java

hg: jdk8/tl/langtools: 4 new changesets

2012-11-30 Thread maurizio . cimadamore
Changeset: 4f9853659bf1 Author:mcimadamore Date: 2012-11-30 15:14 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4f9853659bf1 8004105: Expression statement lambdas should be void-compatible Summary: Fix lambda compatibility rules as per latest EDR Reviewed-by: jjg ! sr

hg: jdk8/tl/langtools: 8003663: lambda test fails on Windows

2012-11-20 Thread maurizio . cimadamore
Changeset: 7538e419a588 Author:mcimadamore Date: 2012-11-20 15:43 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7538e419a588 8003663: lambda test fails on Windows Summary: fix path separator issue in test Reviewed-by: jjg ! test/tools/javac/lambda/abort/Abort.java

hg: jdk8/tl/langtools: 8003280: Add lambda tests

2012-11-17 Thread maurizio . cimadamore
Changeset: 01c9d4161882 Author:mcimadamore Date: 2012-11-17 19:01 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/01c9d4161882 8003280: Add lambda tests Summary: Turn on lambda expression, method reference and default method support Reviewed-by: jjg ! src/share/classes/

hg: jdk8/tl/langtools: 8002286: Regression: Fix for 8000931 causes a JCK test failure

2012-11-06 Thread maurizio . cimadamore
Changeset: 9b85813d2262 Author:mcimadamore Date: 2012-11-06 14:45 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9b85813d2262 8002286: Regression: Fix for 8000931 causes a JCK test failure Summary: Wrong type used as 'site' in Resolve.resolveMethod Reviewed-by: jjg ! s

hg: jdk8/tl/langtools: 2 new changesets

2012-11-04 Thread maurizio . cimadamore
Changeset: d7d932236fee Author:mcimadamore Date: 2012-11-04 10:59 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7d932236fee 7192246: Add type-checking support for default methods Summary: Add type-checking support for default methods as per Featherweight-Defender doc

hg: jdk8/tl/langtools: 7192245: Add parser support for default methods

2012-10-17 Thread maurizio . cimadamore
Changeset: 12cf6bfd8c05 Author:mcimadamore Date: 2012-10-17 16:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/12cf6bfd8c05 7192245: Add parser support for default methods Summary: Add support for 'default' keyword in modifier position Reviewed-by: jjg ! src/share/cl

hg: jdk8/tl/langtools: 7177386: Add attribution support for method references

2012-10-06 Thread maurizio . cimadamore
Changeset: d4b3cb1ece84 Author:mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmit

hg: jdk8/tl/langtools: 7177385: Add attribution support for lambda expressions

2012-10-05 Thread maurizio . cimadamore
Changeset: 573ceb23beeb Author:mcimadamore Date: 2012-10-05 14:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573ceb23beeb 7177385: Add attribution support for lambda expressions Summary: Add support for function descriptor lookup, functional interface inference and

hg: jdk8/tl/langtools: 7177387: Add target-typing support in method context

2012-10-04 Thread maurizio . cimadamore
Changeset: 1408af4cd8b0 Author:mcimadamore Date: 2012-10-04 13:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1408af4cd8b0 7177387: Add target-typing support in method context Summary: Add support for deferred types and speculative attribution Reviewed-by: jjg, dlsmi

hg: jdk8/tl/langtools: 8000233: Fix issues in recent push

2012-09-28 Thread maurizio . cimadamore
Changeset: 1a65d6565b45 Author:mcimadamore Date: 2012-09-28 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1a65d6565b45 8000233: Fix issues in recent push Summary: Forgot to incorporate review comments in pushed changesets Reviewed-by: jjg ! src/share/classes/com

hg: jdk8/tl/langtools: 7188968: New instance creation expression using diamond is checked twice

2012-09-26 Thread maurizio . cimadamore
Changeset: db36841709e4 Author:mcimadamore Date: 2012-09-26 14:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/db36841709e4 7188968: New instance creation expression using diamond is checked twice Summary: Unify method and constructor check logic Reviewed-by: jjg ! s

hg: jdk8/tl/langtools: 4 new changesets

2012-09-25 Thread maurizio . cimadamore
Changeset: 99983a4a593b Author:mcimadamore Date: 2012-09-25 11:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99983a4a593b 7193913: Cleanup Resolve.findMethod Summary: Refactor method lookup logic in Resolve.findMethod Reviewed-by: jjg ! src/share/classes/com/sun/to

hg: jdk8/tl/langtools: 3 new changesets

2012-08-03 Thread maurizio . cimadamore
Changeset: cddc2c894cc6 Author:mcimadamore Date: 2012-08-02 18:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cddc2c894cc6 7175911: Simplify error reporting API in Check.CheckContext interface Summary: Make error messages generated during Check.checkType more uniform

hg: jdk8/tl/langtools: 7181578: javac reports uninitialized variable with nested try...finally blocks

2012-07-13 Thread maurizio . cimadamore
Changeset: 934a89402f85 Author:mcimadamore Date: 2012-07-13 12:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/934a89402f85 7181578: javac reports uninitialized variable with nested try...finally blocks Summary: regression introduced in refactoring of Flow.java Review

hg: jdk8/tl/langtools: 7177701: error: Filling jar message during javax/imageio/metadata/IIOMetadataFormatImpl compilation

2012-06-19 Thread maurizio . cimadamore
Changeset: 34e254ffd0e7 Author:mcimadamore Date: 2012-06-19 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/34e254ffd0e7 7177701: error: Filling jar message during javax/imageio/metadata/IIOMetadataFormatImpl compilation Summary: Recent JDK hash changes affected o

hg: jdk8/tl/langtools: 2 new changesets

2012-05-31 Thread maurizio . cimadamore
Changeset: af6a4c24f4e3 Author:mcimadamore Date: 2012-05-31 17:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af6a4c24f4e3 7166552: Inference: cleanup usage of Type.ForAll Summary: Remove hack to callback into type-inference from assignment context Reviewed-by: dlsmi

hg: jdk8/tl/langtools: 7154127: Inference cleanup: remove bound check analysis from visitors in Types.java

2012-04-11 Thread maurizio . cimadamore
Changeset: 6f0ed5a89c25 Author:mcimadamore Date: 2012-04-11 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6f0ed5a89c25 7154127: Inference cleanup: remove bound check analysis from visitors in Types.java Summary: Remove bound checking rules from recursive subtype

hg: jdk8/tl/langtools: 2 new changesets

2012-03-30 Thread maurizio . cimadamore
Changeset: 379bc17d9a26 Author:mcimadamore Date: 2012-03-30 19:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379bc17d9a26 7157688: Regression: common compiler diagnostic features swapped required/found types Summary: bug in resource key in compiler.properties Revie

hg: jdk8/tl/langtools: 3 new changesets

2012-03-26 Thread maurizio . cimadamore
Changeset: 568e70bbd9aa Author:mcimadamore Date: 2012-03-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/568e70bbd9aa 7151580: Separate DA/DU logic from exception checking logic in Flow.java Summary: DA/DU analysis and exception checking analysis should live in

hg: jdk8/tl/langtools: 7151802: compiler update caused sqe test failed

2012-03-09 Thread maurizio . cimadamore
Changeset: 97bec6ab1227 Author:mcimadamore Date: 2012-03-09 17:10 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bec6ab1227 7151802: compiler update caused sqe test failed Summary: Fix regression caused by 7144506 Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun

hg: jdk8/tl/langtools: 2 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: c2234816495f Author:mcimadamore Date: 2012-03-06 16:48 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2234816495f 7151070: NullPointerException in Resolve.isAccessible Summary: Spurious accessibility check in TransTypes Reviewed-by: jjg ! src/share/classes/

hg: jdk8/tl/langtools: 3 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: dda6a5b15580 Author:mcimadamore Date: 2012-03-06 13:26 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dda6a5b15580 7148622: Some diagnostic methods do not go through Log.report Summary: Deferred lint diagnostics ignore Log settings such as deferred diagnosti

hg: jdk8/tl/langtools: 3 new changesets

2012-03-02 Thread maurizio . cimadamore
Changeset: 161230ec7c73 Author:mcimadamore Date: 2012-03-02 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/161230ec7c73 7132880: Resolve should support nested resolution contexts Summary: Overload resolution routine should be updated so that it can be called recu

hg: jdk8/tl/langtools: 7142086: performance problem in Check.checkOverrideClashes(...)

2012-02-14 Thread maurizio . cimadamore
Changeset: 84b61130cbed Author:mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSy

hg: jdk8/tl/langtools: 7129801: Merge the two method applicability routines

2012-01-24 Thread maurizio . cimadamore
Changeset: 51fb17abfc32 Author:mcimadamore Date: 2012-01-24 17:52 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check rout

hg: jdk8/tl/langtools: 7123100: javac fails with java.lang.StackOverflowError

2012-01-12 Thread maurizio . cimadamore
Changeset: 133744729455 Author:mcimadamore Date: 2012-01-12 15:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133744729455 7123100: javac fails with java.lang.StackOverflowError Summary: Inference of under-constrained type-variables creates erroneous recursive wildc

hg: jdk8/tl/langtools: 7126754: Generics compilation failure casting List to List

2012-01-11 Thread maurizio . cimadamore
Changeset: 70d92518063e Author:mcimadamore Date: 2012-01-11 18:23 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70d92518063e 7126754: Generics compilation failure casting List to List Summary: Problems with Types.rewriteQuantifiers not preserving variance Reviewed-by:

hg: jdk8/tl/langtools: 7120463: Fix method reference parser support in order to avoid ambiguities

2011-12-19 Thread maurizio . cimadamore
Changeset: 1ae5988e201b Author:mcimadamore Date: 2011-12-19 12:07 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ae5988e201b 7120463: Fix method reference parser support in order to avoid ambiguities Summary: Add lookahead routine to disambiguate between method referen

hg: jdk8/tl/langtools: 7120266: javac fails to compile hotspot code

2011-12-11 Thread maurizio . cimadamore
Changeset: e55270a7a022 Author:mcimadamore Date: 2011-12-11 17:48 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e55270a7a022 7120266: javac fails to compile hotspot code Summary: Parser changes for method references cause bad intercation with method call syntax Review

hg: jdk8/tl/jdk: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread maurizio . cimadamore
Changeset: 89130611b178 Author:mcimadamore Date: 2011-12-01 18:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb, ch

hg: jdk8/tl/langtools: 2 new changesets

2011-11-28 Thread maurizio . cimadamore
Changeset: 9448fe783fd2 Author:mcimadamore Date: 2011-11-28 15:56 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9448fe783fd2 7115050: Add parser support for lambda expressions Summary: Add support for parsing lambda expressions to JavacParser Reviewed-by: jjg ! src/sh

hg: jdk8/tl/langtools: 2 new changesets

2011-11-24 Thread maurizio . cimadamore
Changeset: c896d95e7469 Author:mcimadamore Date: 2011-11-24 13:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c896d95e7469 7115046: Add AST node for lambda expressions Summary: Add tree nodes for representing lambda expressions and update relevant visitors interface

hg: jdk8/tl/langtools: 7104201: Refactor DocCommentScanner

2011-11-04 Thread maurizio . cimadamore
Changeset: 56830d5cb5bb Author:mcimadamore Date: 2011-11-04 12:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/

hg: jdk8/tl/langtools: 7104618: MessageInfo.java is failing after lexer changes

2011-10-25 Thread maurizio . cimadamore
Changeset: b73a9be0b993 Author:mcimadamore Date: 2011-10-25 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b73a9be0b993 7104618: MessageInfo.java is failing after lexer changes Summary: Two langtools regression tests cannot be built due to a bad import statement

hg: jdk8/tl/langtools: 2 new changesets

2011-10-24 Thread maurizio . cimadamore
Changeset: d346ab55031b Author:mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d346ab55031b 7096014: Javac tokens should retain state Summary: Refactor javac tokens from enum constants to stateful instances (to keep track of position,

hg: jdk8/tl/langtools: 7102515: javac running very very long and not returning

2011-10-19 Thread maurizio . cimadamore
Changeset: 366c233eb838 Author:mcimadamore Date: 2011-10-19 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/366c233eb838 7102515: javac running very very long and not returning Summary: Verbose resolution diagnostics slow down with operator resolution Reviewed-by:

hg: jdk8/tl/langtools: 2 new changesets

2011-10-17 Thread maurizio . cimadamore
Changeset: b5d0b8effc85 Author:mcimadamore Date: 2011-10-17 12:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b5d0b8effc85 7097436: Project Coin: duplicate varargs warnings on method annotated with @SafeVarargs Summary: Duplicate aliasing check during subtyping lead

hg: jdk8/tl/langtools: 7090499: missing rawtypes warnings in anonymous inner class

2011-10-06 Thread maurizio . cimadamore
Changeset: 47147081d5b4 Author:mcimadamore Date: 2011-10-06 18:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/47147081d5b4 7090499: missing rawtypes warnings in anonymous inner class Summary: javac does not detect raw types inside anonymous inner classes Reviewed-by:

hg: jdk8/tl/langtools: 7086586: Inference producing null type argument

2011-09-16 Thread maurizio . cimadamore
Changeset: c0835c8489b0 Author:mcimadamore Date: 2011-09-16 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 7086586: Inference producing null type argument Summary: Inference should fail in 15.12.2.7 when inference variables with 'nulltype' upper boun

hg: jdk8/tl/langtools: 3 new changesets

2011-09-13 Thread maurizio . cimadamore
Changeset: ed338593b0b6 Author:mcimadamore Date: 2011-09-13 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6 7086595: Error message bug: name of initializer is 'null' Summary: Implementation of MethodSymbol.location() should take into account static/in

hg: jdk8/tl/langtools: 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper

2011-09-02 Thread maurizio . cimadamore
Changeset: ec27e5befa53 Author:mcimadamore Date: 2011-09-02 17:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec27e5befa53 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper Summary: Missing override for toSt

hg: jdk8/tl/langtools: 2 new changesets

2011-08-31 Thread maurizio . cimadamore
Changeset: b86277584776 Author:mcimadamore Date: 2011-08-31 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 7085024: internal error; cannot instantiate Foo Summary: Types.isConvertible does not handle erroneous types correctly Reviewed-by: jjg ! src/s

hg: jdk8/tl/langtools: 3 new changesets

2011-07-27 Thread maurizio . cimadamore
Changeset: 0b5beb9562c6 Author:mcimadamore Date: 2011-07-27 19:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0b5beb9562c6 7062745: Regression: difference in overload resolution when two methods are maximally specific Summary: Fix most specific when two methods are

hg: jdk7/tl/langtools: 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface

2011-05-23 Thread maurizio . cimadamore
Changeset: 6bb526ccf5ff Author:mcimadamore Date: 2011-05-23 11:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6bb526ccf5ff 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface Summary: Types.implementation forces unnecessary

hg: jdk7/tl/langtools: 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor

2011-05-16 Thread maurizio . cimadamore
Changeset: 5faa9eedc44e Author:mcimadamore Date: 2011-05-16 09:38 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5faa9eedc44e 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor Summary: Attributing a constructor

hg: jdk7/tl/langtools: 2 new changesets

2011-05-11 Thread maurizio . cimadamore
Changeset: a2d422d480cb Author:mcimadamore Date: 2011-05-11 13:10 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2d422d480cb 7042566: Regression: new ambiguity between varargs method Summary: Erroneous ambiguity error when choosing most specific varargs method Reviewed

hg: jdk7/tl/langtools: 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface"

2011-05-02 Thread maurizio . cimadamore
Changeset: 384ea9a98912 Author:mcimadamore Date: 2011-05-02 12:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/384ea9a98912 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface" Summary: Fix of 7034511 (now backed out) is caus

hg: jdk7/tl/langtools: 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments

2011-04-30 Thread maurizio . cimadamore
Changeset: 4caf17560ae0 Author:mcimadamore Date: 2011-04-30 11:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4caf17560ae0 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments Summary: diamond should be disallowed in cases w

hg: jdk7/tl/langtools: 4 new changesets

2011-04-29 Thread maurizio . cimadamore
Changeset: 4c03383f6529 Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; Summary: When a null literal is found on top of stack, if expected type is 1-dimensio

hg: jdk7/tl/langtools: 7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to subscopes

2011-04-19 Thread maurizio . cimadamore
Changeset: 671bb63f3ed5 Author:mcimadamore Date: 2011-04-19 13:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/671bb63f3ed5 7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to subscopes Summary: CompoundScope.getElements() is not filtering elemen

hg: jdk7/tl/langtools: 2 new changesets

2011-04-12 Thread maurizio . cimadamore
Changeset: f00986f55961 Author:mcimadamore Date: 2011-04-12 20:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f00986f55961 7034511: Loophole in typesafety Summary: Type-variable substutution takes upper bound of replaced captured type-variable Reviewed-by: dlsmith

hg: jdk7/tl/langtools: 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource

2011-04-01 Thread maurizio . cimadamore
Changeset: b945b846c979 Author:mcimadamore Date: 2011-04-01 12:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b945b846c979 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource Summary: missing name check before calling MethodSymbol.

hg: jdk7/tl/langtools: 4 new changesets

2011-03-29 Thread maurizio . cimadamore
Changeset: 2007998f89f2 Author:mcimadamore Date: 2011-03-29 16:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2007998f89f2 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class Summary: Diamond accepts non-parameterized

hg: jdk7/tl/langtools: 6558548: The compiler needs to be aligned with clarified specification of throws

2011-03-16 Thread maurizio . cimadamore
Changeset: 5b29f2a85085 Author:mcimadamore Date: 2011-03-16 11:12 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5b29f2a85085 6558548: The compiler needs to be aligned with clarified specification of throws Summary: Javac should issue unconditional warnings when 'dead'

  1   2   >