Looks fine to me.
Mike
On Apr 17 2014, at 08:56 , Claes Redestad claes.redes...@oracle.com wrote:
Hi,
could I get a review of the following small patch to address 8040837:
http://cr.openjdk.java.net/~lagergren/8040837/
https://bugs.openjdk.java.net/browse/JDK-8040837
A simple JMH
Changeset: 8e133b86b9f8
Author:mduigou
Date: 2013-12-17 09:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e133b86b9f8
8029795: LinkedHashMap.getOrDefault() doesn't update access order.
Reviewed-by: psandoz
! src/share/classes/java/util/LinkedHashMap.java
!
Changeset: a7ed72627c3f
Author:mduigou
Date: 2013-12-13 13:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7ed72627c3f
8029055: Map.merge implementations should refuse null value param
Reviewed-by: briangoetz, dl
! src/share/classes/java/util/HashMap.java
!
Changeset: 1298e476729c
Author:michaelm
Date: 2013-12-11 15:26 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1298e476729c
8029944: Primitive Stream reduce method documentation pseudo code misidentifies
apply method
Reviewed-by: mduigou
Contributed-by:
Changeset: 2aae624bb833
Author:briangoetz
Date: 2013-12-03 21:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aae624bb833
8028816: Add value-type notice to Optional* classes
Reviewed-by: mduigou, smarks
Contributed-by: bitterf...@gmail.com
+
Changeset: 9c30cbc316e9
Author:mduigou
Date: 2013-11-05 19:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c30cbc316e9
8021309: replace test/Makefile jdk_* targets with jtreg groups
8015068: Use jtreg -exclude for handling problemList.txt exclusions
Reviewed-by: jjg,
A couple minor quibbles
- Since the length is know the StringBuilder can be created with a size.
- sb.toString() is probably more efficient than new String(sb)
- I would like to see some IDN URL cases in the tests.
Mike
On Nov 1 2013, at 07:46 , Michael McMahon michael.x.mcma...@oracle.com
Changeset: f4129fcfacdc
Author:mduigou
Date: 2013-10-23 14:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4129fcfacdc
8024688: further split Map and ConcurrentMap defaults eliminating looping from
Map defaults, Map.merge fixes and doc fixes.
Reviewed-by: psandoz,
Changeset: 9ec6626d43bb
Author:mduigou
Date: 2013-10-17 14:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/9ec6626d43bb
8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, open
bug, -l and wxfile support
Reviewed-by: weijun, dsamersoff, darcy, jrose, tbell
Changeset: cf9cb3d241a3
Author:mduigou
Date: 2013-10-16 13:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf9cb3d241a3
8025910: rename substream(long) - skip and remove substream(long,long)
Reviewed-by: psandoz, henryjen
!
Changeset: 3f9873789d44
Author:mduigou
Date: 2013-10-11 15:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/3f9873789d44
8025796: hgforest.sh could trigger unbuffered output from hg without
complicated machinations
Reviewed-by: mduigou
Contributed-by: Dmitry Samersoff
Changeset: eab3c09745b6
Author:bchristi
Date: 2013-10-09 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab3c09745b6
8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position
Summary: Override remove() method in DescendingKeyIterator
Reviewed-by:
Changeset: 8cfb2bddd95e
Author:mduigou
Date: 2013-09-30 15:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfb2bddd95e
7057785: Add note about optional support of recursive methods for
self-referential Collection/Map
Reviewed-by: scolebourne, darcy, mduigou
Changeset: c32ab940a183
Author:mduigou
Date: 2013-10-01 10:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c32ab940a183
8025686: Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8
support
Reviewed-by: lancea, chegar
!
Changeset: 914f8d4570df
Author:mduigou
Date: 2013-09-27 10:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914f8d4570df
8025595: Remove alt-rt.jar, used by +AggressiveOps (jdk repo portion of
JDK-8024826)
Reviewed-by: alanb, chegar, dholmes, ksrini
!
Changeset: 4ed8565fa536
Author:mduigou
Date: 2013-09-27 11:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ed8565fa536
8024842: Define ABS_TEST_OUTPUT_DIR via TEST_OUTPUT_DIR
Reviewed-by: ihse, erikj, vromero
! test/Makefile
Changeset: fbe6f5dbb24f
Author:mduigou
Date: 2013-09-27 13:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbe6f5dbb24f
8023339: Refined Collection.removeIf UOE conditions
Reviewed-by: mduigou
Contributed-by: paul.san...@oracle.com
!
Changeset: d921ce805abe
Author:mduigou
Date: 2013-09-27 17:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d921ce805abe
8025610: Add explicit @throws NPE documentation to Optional constructor and
Optional.of
Reviewed-by: briangoetz, chegar, alanb
!
Changeset: 8f27030686a6
Author:bchristi
Date: 2013-09-26 11:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f27030686a6
8025173: HashMap.put() replacing an existing key can trigger a resize()
Summary: Ensure that HashMap is not resized if we're just replacing a value
Changeset: c65848f2b6a1
Author:mduigou
Date: 2013-09-13 11:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c65848f2b6a1
8021591: Additional explicit null checks
Reviewed-by: psandoz, alanb
! src/share/classes/java/util/Collections.java
!
Changeset: 67f64101616e
Author:mduigou
Date: 2013-09-13 12:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/67f64101616e
8024201: Update bugdatabase url
Reviewed-by: wetmore
! make/scripts/webrev.ksh
Changeset: 4bdbe25b1e04
Author:mduigou
Date: 2013-09-03 11:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bdbe25b1e04
8024015: TEST.groups: move jdk/lambda tests from jdk_other to jdk_lang
Reviewed-by: alanb, mchung
! test/TEST.groups
Changeset: 6d7f27953da6
Author:mduigou
Date: 2013-09-03 15:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/6d7f27953da6
8024200: handle hg wrapper with space after #!
Reviewed-by: tbell
! common/bin/hgforest.sh
Changeset: 51a61778a99d
Author:mduigou
Date: 2013-08-29 16:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/51a61778a99d
8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to
put output.
Reviewed-by: erikj, vromero, henryjen
! test/Makefile
Changeset: f643fee2b40f
Author:mduigou
Date: 2013-08-26 10:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/f643fee2b40f
8023491: Remove target names from test/Makefile and defer to sub-repo makefiles.
Reviewed-by: erikj
! common/makefiles/Main.gmk
! test/Makefile
Changeset: fad3b6673159
Author:mduigou
Date: 2013-08-21 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad3b6673159
8023306: Add replace() implementations to TreeMap
Reviewed-by: psandoz, alanb, chegar, bpb
! src/share/classes/java/util/TreeMap.java
Changeset:
Changeset: c8da1b6a9762
Author:mduigou
Date: 2013-08-20 17:44 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c8da1b6a9762
8023433: Improve 'make help'
Reviewed-by: tbell
! NewMakefile.gmk
I've been confused through this discussion as to why a trailing dot would be
regarded as illegal.
Historically a trailing dot has been frequently (though not universally) used
to denote a fully qualified domain name.
https://en.wikipedia.org/wiki/Fully_qualified_domain_name
Is this use now
Changeset: 17dfbb3f60d3
Author:bpb
Date: 2013-08-12 10:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17dfbb3f60d3
8022109: Evaluate adding incrementExact, decrementExact, negateExact to
java.lang.Math
Summary: Add the methods for parameter types int and long.
Changeset: e117fcdd2176
Author:mduigou
Date: 2013-08-06 18:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e117fcdd2176
8022476: cleanup some raw types and unchecked warnings in java.util.stream
Reviewed-by: darcy
Contributed-by: mike.dui...@oracle.com,
Changeset: 5d4a35823071
Author:mduigou
Date: 2013-07-27 12:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d4a35823071
8021588: Remove explicit othervm execution from jdk/test/Makefile
Reviewed-by: alanb
! test/Makefile
Changeset: f056728871f8
Author:mduigou
Date: 2013-07-26 17:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f056728871f8
8021601: Add unit test for PriorityQueue(Comparator) constructor
Reviewed-by: darcy, alanb
! src/share/classes/java/util/PriorityQueue.java
!
Changeset: 8156630c1ed3
Author:mduigou
Date: 2013-07-23 13:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8156630c1ed3
8019840: Spec updates for java.util.function
Reviewed-by: mduigou, chegar
Contributed-by: brian.go...@oracle.com
!
Changeset: a6cbb9808e4b
Author:mduigou
Date: 2013-07-22 12:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6cbb9808e4b
6799426: Adds constructor PriorityQueue(Comparator)
Reviewed-by: lancea
! src/share/classes/java/util/PriorityQueue.java
Changeset: fe6e4e2c367d
Author:mduigou
Date: 2013-07-12 11:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe6e4e2c367d
7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
!
Changeset: 9b17939958e7
Author:henryjen
Date: 2013-07-12 15:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b17939958e7
8015320: Pull spliterator() up from Collection to Iterable
Reviewed-by: psandoz, mduigou
Contributed-by: brian.go...@oracle.com
!
Changeset: 49b78ec058fb
Author:mduigou
Date: 2013-06-20 07:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49b78ec058fb
8017088: Map/HashMap.compute() incorrect with key mapping to null value
Reviewed-by: dl, dholmes, plevart
! src/share/classes/java/util/HashMap.java
!
Changeset: ba544aab1fcd
Author:bpb
Date: 2013-06-18 11:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba544aab1fcd
8015395: NumberFormatException during startup if JDK-internal property
java.lang.Integer.IntegerCache.high set to bad value
Summary: Fall back to default if
, psandoz
Contributed-by: Mike Duigou mike.dui...@oracle.com, Remi Forax
fo...@univ-mlv.fr
! src/share/classes/java/util/HashMap.java
! src/share/classes/java/util/Hashtable.java
! src/share/classes/java/util/IdentityHashMap.java
! src/share/classes/java/util/LinkedHashMap.java
! src/share/classes/java
Changeset: f8770fe60d53
Author:mduigou
Date: 2013-06-17 09:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/f8770fe60d53
8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile
Reviewed-by: alanb, erikj
! common/makefiles/Main.gmk
Changeset: c9f5a2fd7d3d
Author:bchristi
Date: 2013-06-12 11:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9f5a2fd7d3d
8010325: Remove hash32() method and hash32 int field from java.lang.String
Reviewed-by: alanb, mduigou
! src/share/classes/java/lang/String.java
!
Changeset: ce8fbca80bbc
Author:henryjen
Date: 2013-06-12 14:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce8fbca80bbc
8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by
8015895
Reviewed-by: mduigou
!
Changeset: 7f697d028937
Author:mduigou
Date: 2013-06-11 15:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f697d028937
8016213: Convert j2se NetBeans project to use top-level make targets
Reviewed-by: chegar
! make/netbeans/common/shared.xml
!
Changeset: 69d566198fe4
Author:henryjen
Date: 2013-06-05 15:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d566198fe4
8015522: CharSequence.codePoints can be faster
Reviewed-by: martin, psandoz, alanb
Contributed-by: henry@oracle.com
!
Changeset: 62d3c82b4509
Author:shade
Date: 2013-06-03 22:09 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62d3c82b4509
8014966: Add the proper Javadoc to @Contended
Summary: more extensive description.
Reviewed-by: dholmes, mduigou, martin
!
stevenschlans...@gmail.com, Mike Duigou
mike.dui...@oracle.com
! src/share/classes/java/lang/Integer.java
! src/share/classes/java/lang/Long.java
+ test/java/lang/IntegralPrimitiveToString.java
Changeset: fc0b3e86fdcf
Author:mduigou
Date: 2013-05-31 11:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0b3e86fdcf
8015686: {Int|Long}SummaryStatistics toString() throws
IllegalFormatConversionException
Reviewed-by: dholmes, alanb, psandoz
!
to
tidy up other areas of the JavaDoc.
Reviewed-by: plevart, darcy
Contributed-by: John Rose john.r.r...@oracle.com, Mike Duigou
mike.dui...@oracle.com, Paul Sandoz paul.san...@oracle.com
! src/share/classes/java/util/Spliterator.java
Changeset: 6bbc2816d936
Author:psandoz
Date: 2013-05
Changeset: 2490769abdfa
Author:mduigou
Date: 2013-05-10 09:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2490769abdfa
8014316: Use Method Refs in j.u.stream.MatchOps
Reviewed-by: dholmes
! src/share/classes/java/util/stream/MatchOps.java
Changeset: 9891e4d7d5b3
Author:
Changeset: 498ea4c3a4c6
Author:psandoz
Date: 2013-05-01 18:40 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/498ea4c3a4c6
8012646: Pattern.splitAsStream
Reviewed-by: forax, plevart, alanb
Contributed-by: Ben Evans benjamin.john.ev...@gmail.com, Paul Sandoz
Changeset: fe4e9bc2186f
Author:mduigou
Date: 2013-05-07 12:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe4e9bc2186f
4802647: Throw required NPEs from removeAll()/retainAll()
Reviewed-by: mduigou, chegar, dholmes
Contributed-by: Brandon Passanisi
, Paul Sandoz
paul.san...@oracle.com, Mike Duigou mike.dui...@oracle.com, Robert Field
robert.fi...@oracle.com, Jim Gish jim.g...@oracle.com
! test/Makefile
+ test/java/util/concurrent/atomic/AtomicReferenceTest.java
+ test/java/util/stream/bootlib/TEST.properties
+ test/java/util/stream/bootlib/java
Changeset: e13cf31e5a96
Author:mduigou
Date: 2013-05-06 20:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e13cf31e5a96
8013712: Add Objects.nonNull and Objects.isNull
Reviewed-by: mchung, darcy
! src/share/classes/java/util/Objects.java
!
Changeset: fc156b925259
Author:mduigou
Date: 2013-05-03 10:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc156b925259
8013528: Provide SharedSecrets access to String(char[], boolean) constructor
Reviewed-by: martin, alanb, chegar, plevart
!
Changeset: 5045eb04a579
Author:mduigou
Date: 2013-05-02 09:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5045eb04a579
8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile
Reviewed-by: mduigou, henryjen, alanb, martin, psandoz
Contributed-by:
Changeset: c6aef650e615
Author:mduigou
Date: 2013-05-01 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6aef650e615
8012665: add CharSequence.chars, CharSequence.codePoints
Reviewed-by: martin, alanb, ulfzibis, mduigou
Contributed-by: Stuart Marks
Changeset: 0e6f412f5536
Author:mduigou
Date: 2013-04-30 12:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e6f412f5536
8011814: Add testng.jar to Netbeans projects test compile classpath
8013271: Add MacOS sources to J2SE Netbeans project
8013272: JDK Netbeans projects
Changeset: 7857129859bd
Author:briangoetz
Date: 2013-04-20 18:53 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7857129859bd
8012650: Arrays streams methods
8011918: java.util.stream.Streams
Reviewed-by: alanb, mduigou, darcy, henryjen
Contributed-by: brian.go...@oracle.com,
://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cb55846c9bb
8011920: Main streams implementation
8012542: Stream methods on Collection
Reviewed-by: dholmes, mduigou
Contributed-by: Brian Goetz brian.go...@oracle.com, Mike Duigou
mike.dui...@oracle.com, Paul Sandoz paul.san...@oracle.com
! make/docs/CORE_PKGS.gmk
! src
/CollectionSupplier.java
Changeset: 2a78d8f1fec1
Author:briangoetz
Date: 2013-04-17 14:39 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a78d8f1fec1
8008682: Inital Streams public API
Reviewed-by: mduigou, dholmes, darcy
Contributed-by: Brian Goetz brian.go...@oracle.com, Mike
Changeset: 6139f8fb0137
Author:mduigou
Date: 2013-04-16 22:50 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6139f8fb0137
8008670: Initial java.util.stream putback -- internal API classes
Reviewed-by: mduigou, dholmes
Contributed-by: Brian Goetz brian.go...@oracle.com, Doug
Changeset: d9f9040554d6
Author:mduigou
Date: 2013-04-17 11:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f9040554d6
8010953: Add primitive summary statistics utils
Reviewed-by: mduigou, dholmes, chegar, darcy
Contributed-by: Brian Goetz brian.go...@oracle.com
+
Changeset: 674880648db4
Author:briangoetz
Date: 2013-04-16 13:51 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/674880648db4
8010096: Initial java.util.Spliterator putback
Reviewed-by: mduigou, alanb, chegar, darcy
Contributed-by: Paul Sandoz paul.san...@oracle.com, Brian
, ulfzibis
Contributed-by: Doug Lea d...@cs.oswego.edu, Henry Jen
henry@oracle.com, Akhil Arora akhil.ar...@oracle.com, Peter Levart
peter.lev...@gmail.com, Mike Duigou mike.dui...@oracle.com
! src/share/classes/java/util/Collections.java
! src/share/classes/java/util/HashMap.java
! src/share
...@oracle.com, John Rose
john.r.r...@oracle.com, Mike Duigou mike.dui...@oracle.com
! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/HashMap.java
+ test/java/util/Map/BasicSerialization.java
Changeset: 575f2ca947ab
Author:mduigou
Date: 2013-04-03 16:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/575f2ca947ab
8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells
Reviewed-by: tbell, katleman, dholmes
! common/bin/hgforest.sh
Changeset: 7320922b694e
Author:mduigou
Date: 2013-04-02 14:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7320922b694e
8011342: hgforest.sh : 'python --version' not supported on older python
Reviewed-by: wetmore
! common/bin/hgforest.sh
Changeset: 2241a2d34085
Author:mduigou
Date: 2013-03-19 16:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2241a2d34085
8001642: Add OptionalT, OptionalDouble, OptionalInt, OptionalLong
Reviewed-by: mduigou, darcy, alanb, jjb
Contributed-by: Brian Goetz
Changeset: e38b46041049
Author:mduigou
Date: 2013-03-08 15:45 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e38b46041049
8001667: Comparator combinators and extension methods
Reviewed-by: mduigou, briangoetz
Contributed-by: henry@oracle.com
!
Changeset: b35d986ff276
Author:mduigou
Date: 2013-03-06 08:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276
8009162: root repo make test target should run against image
Reviewed-by: alanb, martin, erikj
! common/makefiles/Main.gmk
Changeset: f4b01f4e8f35
Author:mduigou
Date: 2013-02-27 11:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4b01f4e8f35
8008785: IdentityHashMap.values().toArray(V[]) broken by JDK-8008167
Reviewed-by: alanb
! src/share/classes/java/util/IdentityHashMap.java
+
Changeset: 16efb7ba188f
Author:mduigou
Date: 2013-02-19 11:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16efb7ba188f
8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and Bi (two
Changeset: e57019d2f34a
Author:mduigou
Date: 2013-02-13 14:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e57019d2f34a
8008167: IdentityHashMap.[keySet|values|entrySet].toArray speed-up
Reviewed-by: mduigou, martin
Contributed-by: Peter Levart peter.lev...@gmail.com
!
Changeset: 168dd033604a
Author:mduigou
Date: 2013-02-06 11:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/168dd033604a
8004726: Link bug ids to jbs rather than monaco.
Reviewed-by: ohair, chegar, katleman
! make/scripts/webrev.ksh
Changeset: cff8d7768d72
Author:mduigou
Date: 2013-01-31 13:27 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cff8d7768d72
8006709: Add minimal support of MacOSX platform for NetBeans Projects
Summary: Adds support for MacOSX platform and architecture detection. Other
minor
Changeset: 4209b3936a7f
Author:mduigou
Date: 2013-01-25 16:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4209b3936a7f
8005632: Extend java.util.Logger to use SupplierString for messages
Reviewed-by: briangoetz, mduigou
Contributed-by: henry@oracle.com
!
Looks good to me. The alternative port example at line 68 uses port 80 which is
the default. 1080 or 8080 perhaps?
Mike
On Jan 24 2013, at 09:27 , Kurchi Hazra wrote:
Apologies, but I have a new suggestion. It is safer to redirect to an archived
version of the document that we want to link
Changeset: c4bd81de2868
Author:akhil
Date: 2012-12-11 15:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bd81de2868
8003246: Add InitialValue Supplier to ThreadLocal
Reviewed-by: mduigou, forax, dl, chegar, briangoetz
! src/share/classes/java/lang/ThreadLocal.java
+
Changeset: fb1bf5e5bc9e
Author:henryjen
Date: 2012-12-06 15:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/fb1bf5e5bc9e
8004685: add java.util.function to CORE_PKGS.gmk
Reviewed-by: mduigou
! common/makefiles/javadoc/CORE_PKGS.gmk
Changeset: bf6ceb6b8f80
Author:mduigou
Date: 2012-11-29 14:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf6ceb6b8f80
7175464: entrySetView field is never updated in NavigableSubMap
Summary: The method entrySet() in AscendingSubMap and DescendingSubMap failed
to cache
Changeset: e24123de581c
Author:mduigou
Date: 2012-11-13 20:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e24123de581c
7088952: Add size in bytes constant BYTES to primitive type wrapper types
Summary: Adds a constant BYTES to each of the primitive wrapper classes (Byte,
Changeset: be1fb42ef696
Author:mduigou
Date: 2012-11-13 20:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be1fb42ef696
7088913: Add compatible static hashCode(primitive) to primitive wrapper classes
Summary: Adds static utility methods to each primitive wrapper class to
We should also nuke gopher and netdoc (in sun.net.www.protocol package)
I am not sure if mailto should continue as there are better solutions.
Mike
On Oct 15 2012, at 09:14 , Alan Bateman wrote:
java.net.URL guarantees that 5 protocol handlers are present: http, https,
ftp, file and jar.
Changeset: e7add6d98729
Author:mduigou
Date: 2012-09-18 11:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7add6d98729
7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D
definitions
Reviewed-by: alanb
! test/java/util/Map/Collisions.java
Changeset: e20a2e6a92f7
Author:mduigou
Date: 2012-09-17 11:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e20a2e6a92f7
7198988: re-order paramaters for Collision.java @run
Reviewed-by: alanb
! test/java/util/Map/Collisions.java
On Sep 14 2012, at 09:27 , Chris Hegarty wrote:
On 14/09/12 12:20, Alan Bateman wrote:
On 14/09/2012 01:21, Brad Wetmore wrote:
Netbean's automatic formatting does a pretty good job with new code.
However, I think the general advice is to not change existing code
just because. When you're
On Aug 15 2012, at 09:06 , Michael McMahon wrote:
HttpClientProvider::
- HttpClientProvider JavaDoc uses inconsistent capitalization of HTTP.
- createAsynchronousHttpClient() Since there's only one create method why
bother to mention that it's Asynchronous?
- It's not clear how
Hi Michael!
I really look forward to using this API! It looks like you have made a lot of
progress. Sorry for having so many comments on just one round.
Mike
General::
- It's probably already been mentioned but having the classes in the httpclient
package and most of them begin with Http
Changeset: 184da100cf45
Author:jgish
Date: 2012-07-27 16:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184da100cf45
6914123: (str) Missing synchronization in
java.lang.String#contentEquals(CharSequence)
Summary: Change contentEquals( CharSequence cs ) to do
Changeset: 9e15068b6946
Author:jgish
Date: 2012-06-29 15:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e15068b6946
7100996: (spec str) IndexOutOfBoundsException when using a StringBuffer from
multiple threads
Summary: add usage note to clarify thread safety
Changeset: 505455116320
Author:mduigou
Date: 2012-06-13 16:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/505455116320
7173919: Minor optimization of hashing methods
Summary: several minor optimizations to hashing methods used by hash map classes
Reviewed-by: dholmes
!
Changeset: fc0e508b713f
Author:mduigou
Date: 2012-06-07 01:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f
7174736: JCK test api/java_util/HashMap/index_EntrySet failing
Summary: Corrects a problem with HashMap.removeEntry() that caused a JCK test
to fail
Changeset: 7baa22e6a6b3
Author:mduigou
Date: 2012-06-01 00:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7baa22e6a6b3
7173432: Handle null key at HashMap resize
Summary: If the key to be inserted into a HashMap is null and the table needs
to be resized as part of the
Changeset: 2c773daa825d
Author:mduigou
Date: 2012-05-17 10:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d
6924259: Remove offset and count fields from java.lang.String
Summary: Removes the use of shared character array buffers by String along with
the two
Changeset: 43bd5ee0205e
Author:mduigou
Date: 2012-05-30 22:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e
7126277: Alternative String hashing implementation
Summary: All of the hashing based Map implementations: HashMap, Hashtable,
LinkedHashMap, WeakHashMap
Changeset: 944676ef3c58
Author:mduigou
Date: 2012-05-11 11:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/944676ef3c58
7071826: Avoid benign race condition in initialization of UUID
Summary: Avoids mostly benign but sometimes expensive race condition on
initialization of
Changeset: 2900d4ae2d39
Author:mduigou
Date: 2012-03-08 13:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2900d4ae2d39
7151595: Disable creation of db demos if NO_DEMOS is specified
Reviewed-by: weijun, dholmes
! make/common/Release.gmk
Changeset: 971a86421f51
Author:mduigou
Date: 2012-03-01 09:40 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/971a86421f51
7149320: Move sun.misc.VM.booted() to the end of System.initializeSystemClass()
Summary: Ensure that sun.misc.VM.booted() is the last action in
Changeset: 323abe0e8973
Author:mduigou
Date: 2012-02-27 18:10 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/323abe0e8973
7143162: Allow disable building of jdk demos and samples
Reviewed-by: ohair
! make/Makefile
! make/common/Release.gmk
!
Changeset: 28f2fe471725
Author:mduigou
Date: 2012-02-27 18:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/28f2fe471725
7143162: Allow disable building of jdk demos and samples
Reviewed-by: ohair
! make/sanity-rules.gmk
1 - 100 of 128 matches
Mail list logo
