hg: jdk8/tl/jdk: 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour

Changeset: 5eed4a92ca8c Author:ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Ha

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

/ On Wed, 2012-07-04 at 21:34 +0100, Chris Hegarty wrote: > Seems like a reasonable candidate for a backport. Are you encountering it in > 7? > > -Chris > > On 4 Jul 2012, at 15:19, Neil Richards wrote: > > > On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote: >

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote: > > > Hi, > > The CookieStore.add() method throws a Null Pointer Exception when > null is passed as the uri parameter, although this is allowed > according to the method spec. > > The exception is thrown because uri.getHost() is c

Re: GC closes my ServerSocket

On Wed, 2012-06-13 at 17:23 +0800, Weijun Wang wrote: > Please anyone take a review: > > http://cr.openjdk.java.net/~weijun/7176574/webrev.00/ > > By assigning to a local variable hopefully it stays alive on the stack > during the whole method. > > Noreg-self. > > *Chris*: I didn't indente

hg: jdk8/tl/jdk: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h

Changeset: 13978750cb87 Author:ngmr Date: 2012-01-31 10:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/l

hg: jdk8/tl/jdk: 7123229: (coll) EnumMap.containsValue(null) returns true

Contributed-by: Neil Richards ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/UniqueNullValue.java

Re: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface.

On Thu, 2011-12-08 at 10:54 +, Chris Hegarty wrote: > On 08/12/2011 03:16, Charles Lee wrote: > > > > Hi Alan, hi Chris, > > > > Thank you for reviewing this and creating a bug id for me. I have put a > > revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/ > >

hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH

Changeset: c508f38245f8 Author:ngmr Date: 2011-12-12 11:41 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/sola

hg: jdk8/tl/jdk: 7094995: Trailing daemon thread causes continuous GC in agentvm mode

, chegar, dholmes, darcy Contributed-by: Neil Richards ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java

hg: jdk8/tl/jdk: 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found

Changeset: 955aae8c1106 Author:ngmr Date: 2011-11-24 11:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/955aae8c1106 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solari

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Tue, 2011-11-22 at 10:49 +, Chris Hegarty wrote: > Neil, > > I filed: > CR 7114558: "Inet4AddressImpl should use memset (rather than bzero) and > NI_MAXHOST (rather than MAXHOSTNAMELEN)" > > And also reviewed your webrev. Looks fine. > > -Chris. Hi Chris, Thanks for reviewing this for m

hg: jdk8/tl/jdk: 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN)

Changeset: ee2fa62fb09f Author:ngmr Date: 2011-11-22 09:51 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Tue, 2011-11-22 at 09:38 +, Chris Hegarty wrote: > Let me know the details synopsis/descriptions/etc and I'll file a new > CR. I'm guessing its just some cleanup/style issues, right? > > -Chris. I've uploaded a webrev with the gap between the two [1]. The differences are the use of memse

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Wed, 2011-11-16 at 20:57 +, Chris Hegarty wrote: > Thank you Charles, and Neil. > > I ran some builds and tests and all looks good to me. Thanks for fixing > the warnings, I know they were not caused by your changes. > > Just noticed that we haven't just filed a bug for this, so I just cr

hg: jdk8/tl/jdk: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo

Changeset: 81987765cb81 Author:ngmr Date: 2011-11-11 14:40 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/jav

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: > On 11/15/2011 07:10 PM, Chris Hegarty wrote: > > On 11/15/11 06:57 AM, Charles Lee wrote: > >> > > >>> > >> Sigh. Chris, I still fail to see those warnings, even if I do a very > >> clean remove of my build directory and rebuild the

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: > On 11/09/2011 03:25 AM, Chris Hegarty wrote: > > Charles, > > > > Is it possible to fix up the style issues, etc that Neil pointed out, > > and have the webrev updated? > > > Hi Chris, > > Here it is. (attached) > And here it is, in webre

Re: Question about getaddrinfo in Inet4AddressImpl.c

On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: > On 10/26/2011 06:31 PM, Chris Hegarty wrote: > > On 26/10/2011 10:36, Alan Bateman wrote: > >> On 26/10/2011 10:24, Charles Lee wrote: > >>> > >>> > >>> />>> I don't think this code has changed too much since then and > >>> probably could do w

hg: jdk8/tl/jdk: 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h

Changeset: c3da0672a882 Author:ngmr Date: 2011-10-13 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3da0672a882 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h

Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

On Thu, 2011-10-20 at 17:12 +0800, Jonathan Lu wrote: > On 10/20/2011 02:35 PM, Steve Poole wrote: > Thanks Steve, I've updated the test case and patch, see the attachments. > I've added IBM portions copyright comment to both headers. > > - Jonathan For ease of review, I've uploaded the suggested

hg: jdk8/tl/jdk: 2 new changesets

Changeset: dd55467dd1f2 Author:ngmr Date: 2011-10-10 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2 7099119: Remove unused dlinfo local variable in launcher code Reviewed-by: ohair, chegar, ngmr Contributed-by: Steve Poole ! src/solaris/bin/java_md.c Cha

Re: JDK 8 Code review: 7073491

On Thu, 2011-09-15 at 13:46 +0100, Michael McMahon wrote: > Hi, > > Could I get the following code change reviewed please? > > The problem is in AbstractPlainDatagramSocket.create(). If > ResourceManager.beforeUdpCreate() > throws an exception then fd is left set in the impl object. And if the

Re: SocketPermission's implies() interesting behavior

On Wed, 2011-03-16 at 10:43 +, Neil Richards wrote: > On 11 March 2011 14:39, Chris Hegarty wrote: > > As Michael (cc'ed) mentioned in an earlier mail, he is going to be making > > some significant changes in this area in the next week or two. He will > > include

Re: SocketPermission's implies() interesting behavior

On 10 March 2011 03:18, Charles Lee wrote: > With a quick search in the SocketPermission using "cname =" as search word, > cname always seems to be lower cases. But hostname does not. It may need > some rework on the patch. I think using String.regionMatches() [1] for the comparison (with 'ignore

Re: SocketPermission's implies() interesting behavior

On 11 March 2011 14:39, Chris Hegarty wrote: > As Michael (cc'ed) mentioned in an earlier mail, he is going to be making > some significant changes in this area in the next week or two. He will > include this change with the other one, so their impact can be considered > together, if that is ok?

Re: SocketPermission's implies() interesting behavior

On 1 March 2011 09:18, Chris Hegarty wrote: > Michael, > > Can you please take a look at this change, CR 7021280: "SocketPermission > trustProxy should accept wildcards". > > This patch came from Charles (cc'ed), and I agree with the changes. Can you > please take a look and give your feedback. >