On Fri, 15 Oct 2021 14:47:18 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>>
On Tue, 25 May 2021 18:03:51 GMT, Bradford Wetmore wrote:
> Simple typo fix. Somehow the trailing "u" got omitted, so the code won't
> parse when fed into the compiler.
>
> Resulting javadoc output now compiles.
Looks good!
-
Marked as reviewed by coffeys (Reviewer).
PR:
On Tue, 17 Nov 2020 17:55:19 GMT, Sean Mullan wrote:
>> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the
>> jdk.tls.disabledAlgorithms security property in the java.security file.
>> These protocols use weak algorithms and are being deprecated by the IETF.
>> They
Looking for review for this simple edit. Testcase should run in ovm mode.
https://bugs.openjdk.java.net/browse/JDK-8165711
patch :
diff --git
a/test/java/net/SetFactoryPermission/SetFactoryPermission.java
b/test/java/net/SetFactoryPermission/SetFactoryPermission.java
---
Michael,
just a comment from the supportability side of things. I think the
exception handling can be improved with better exception messages which
convey state.
e.g
Changeset: 0683ee308085
Author:coffeys
Date: 2014-02-26 23:04 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0683ee308085
8035618: Four api/org_omg/CORBA TCK tests fail under plugin only
Reviewed-by: mchung, chegar
! src/share/classes/com/sun/corba/se/spi/orb/ORB.java
Changeset: 46c727d6ecc2
Author:aefimov
Date: 2013-12-30 16:46 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2
8025051: Update resource files for TimeZone display names
Reviewed-by: okutsu, mfang
! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java
!
Changeset: 5ca1b4c282b8
Author:ssides
Date: 2013-12-23 18:42 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5ca1b4c282b8
8029231: Update copyright years for files in corba repository for 2013
Reviewed-by: mchung, coffeys
!
Changeset: 0f1332dd805c
Author:coffeys
Date: 2013-12-04 17:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1332dd805c
8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly
intermittently
Reviewed-by: alanb
!
Changeset: cd56de5896b4
Author:aefimov
Date: 2013-11-15 15:06 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4
8027848: The ZoneInfoFile doesn't honor future GMT offset changes
Reviewed-by: sherman, coffeys
! src/share/classes/sun/util/calendar/ZoneInfoFile.java
Changeset: d1bb85f0a45a
Author:coffeys
Date: 2013-11-19 14:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a
8028583: Add helper methods to test libraries
Reviewed-by: chegar
! test/java/rmi/testlibrary/TestLibrary.java
!
Changeset: f2ccd3530476
Author:coffeys
Date: 2013-11-19 16:22 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476
8016728: TEST_BUG:
test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing
intermittently
Reviewed-by: chegar
!
Changeset: d34c5e860d5f
Author:aefimov
Date: 2013-10-24 17:23 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f
8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing
Reviewed-by: okutsu, mfang, alanb
! test/ProblemList.txt
!
Changeset: a90e9efa4264
Author:coffeys
Date: 2013-10-23 16:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264
5036554: unmarshal error on CORBA alias type in CORBA any
Reviewed-by: chegar, smarks
! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java
Changeset: ee7f1c78bec7
Author:coffeys
Date: 2013-10-23 20:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7
8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly
aurora test runs
Reviewed-by: chegar
!
Changeset: 60e3cdbe8cdf
Author:aefimov
Date: 2013-10-13 14:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf
8025255: (tz) Support tzdata2013g
Reviewed-by: okutsu, mfang
! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
!
Changeset: 5920155dd080
Author:coffeys
Date: 2013-09-03 22:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5920155dd080
8017195: Introduce option to setKeepAlive parameter on CORBA sockets
Reviewed-by: chegar, msheppar
+ test/com/sun/corba/transport/KeepAliveSockets.java
Changeset: 92a66af7f834
Author:igerasim
Date: 2013-08-26 18:26 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834
8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions
Reviewed-by: alanb, chegar
!
Changeset: 83c2976ef8ee
Author:coffeys
Date: 2013-07-09 16:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee
8019979: Replace CheckPackageAccess test with better one from closed repo
Reviewed-by: mullan
! test/java/lang/SecurityManager/CheckPackageAccess.java
Changeset: 659828443145
Author:coffeys
Date: 2013-06-14 15:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145
8015978: Incorrect transformation of XPath expression string(-0)
Reviewed-by: darcy, joehw
Contributed-by: aleksej.efi...@oracle.com
!
Changeset: c4480e0d9f53
Author:coffeys
Date: 2013-06-06 14:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4480e0d9f53
8000450: Restrict access to com/sun/corba/se/impl package
Reviewed-by: alanb, chegar, lancea
! src/share/lib/security/java.security-linux
!
Changeset: 5871d7b1673c
Author:coffeys
Date: 2013-04-25 21:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c
8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z
and z pattern letters
Reviewed-by: okutsu
!
Changeset: 885bb24f6018
Author:coffeys
Date: 2013-02-19 14:07 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/885bb24f6018
7197187: Currency.isPastCutoverDate should be made more robust
Reviewed-by: alanb
! src/share/classes/java/util/Currency.java
Changeset: 01b6b0dd2006
Changeset: fecba6a8b78e
Author:coffeys
Date: 2012-10-09 12:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e
7196533: TimeZone.getDefault() slow due to synchronization bottleneck
Reviewed-by: okutsu
! src/share/classes/java/util/TimeZone.java
Changeset: 71de5e31d497
Author:coffeys
Date: 2012-10-09 19:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497
7181793: Socket getOutputStream create streams that cannot be GC'ed until
Socket is closed
Reviewed-by: alanb, chegar
!
Changeset: 679e8ad9874f
Author:coffeys
Date: 2012-10-09 20:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f
7196086: update copyright years for files in corba repository (JDK 8)
Reviewed-by: lancea
! make/common/Defs-bsd.gmk
!
Changeset: fffbb33df102
Author:coffeys
Date: 2012-09-07 21:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fffbb33df102
7180362: RFE: Implement date cutover functionality for currency.properties file
Reviewed-by: naoto
! src/share/classes/java/util/Currency.java
!
Changeset: da1436b21bc2
Author:coffeys
Date: 2012-08-31 12:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da1436b21bc2
7195063: [TEST] jtreg flags com/sun/corba/cachedSocket/7056731.sh with Error
failure.
Reviewed-by: chegar
! test/com/sun/corba/cachedSocket/7056731.sh
Changeset: 18a02ad8dc73
Author:coffeys
Date: 2012-08-16 10:33 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/18a02ad8dc73
7056731: Race condition in CORBA code causes re-use of ABORTed connections
Reviewed-by: lancea
Contributed-by: d.macdon...@auckland.ac.nz
!
Changeset: 56d8756749bd
Author:coffeys
Date: 2012-08-16 10:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d8756749bd
7185965: Build error in javadoc make stage for bundles not containing crypto
package
Reviewed-by: chegar
! make/common/shared/Defs-java.gmk
Changeset: 47adb42076f1
Author:coffeys
Date: 2012-06-27 21:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1
7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8
Reviewed-by: lancea
!
Changeset: 00c9d6cce3ec
Author:coffeys
Date: 2012-06-15 14:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00c9d6cce3ec
7156963: Incorrect copyright header in java/io/SerialCallbackContext
Reviewed-by: weijun, coffeys
Contributed-by: edvard.wende...@oracle.com
!
Changeset: 3e83229a3779
Author:coffeys
Date: 2012-05-11 10:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779
7167359: (tz) SEGV on solaris if TZ variable not set
Reviewed-by: okutsu
! src/solaris/native/java/util/TimeZone_md.c
Changeset: fdf5e15293e6
Author:coffeys
Date: 2012-05-10 10:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf5e15293e6
7163470: Build fails if javax.crypto src files not present
Reviewed-by: valeriep
! make/com/oracle/security/ucrypto/Makefile
!
Changeset: 9cdcc0152526
Author:coffeys
Date: 2012-04-20 17:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9cdcc0152526
7161925: sjava files in corba don't have copyright string and legal notice
Reviewed-by: chegar
Contributed-by: misha.by...@oracle.com
!
Changeset: 6bbafa8404eb
Author:coffeys
Date: 2012-03-13 11:01 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbafa8404eb
7149608: Default TZ detection fails on linux when symbolic links to non default
location used.
Reviewed-by: alanb, okutsu
!
Changeset: 134d9f4f9498
Author:coffeys
Date: 2012-03-12 11:30 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134d9f4f9498
7148584: Jar tools fails to generate manifest correctly when boundary condition
hit
Reviewed-by: alanb, sherman
!
Changeset: a589a8dbde79
Author:coffeys
Date: 2012-02-24 09:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79
7133138: Improve io performance around timezone lookups
Reviewed-by: okutsu
! make/tools/src/build/tools/javazic/Mappings.java
!
Changeset: 0a350fb8b174
Author:coffeys
Date: 2012-02-24 09:17 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174
7144488: Infinite recursion for some equals tests in Collections
Reviewed-by: alanb, dholmes, mduigou
! src/share/classes/java/util/Collections.java
+
Changeset: d27f0b2f1476
Author:coffeys
Date: 2011-11-23 14:55 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27f0b2f1476
7102369: remove java.rmi.server.codebase property parsing from registyimpl
7094468: rmiregistry clean up
Reviewed-by: smarks
!
Changeset: 44c269731425
Author:coffeys
Date: 2011-11-11 10:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/44c269731425
7091388: Regular unexplained npe's from corba libs after system has been
running for days
Reviewed-by: alanb
!
Changeset: e0c1282a0ead
Author:coffeys
Date: 2011-09-13 11:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0c1282a0ead
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file
descriptor be closed when still in use
Reviewed-by: alanb
!
Changeset: 3a13b7ab57f7
Author:coffeys
Date: 2011-08-26 10:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a13b7ab57f7
7024697: SessionRef.dispose() should determine if the token referred to by the
token object is still valid
Reviewed-by: valeriep
!
Changeset: ddcb874581eb
Author:coffeys
Date: 2011-08-11 12:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddcb874581eb
7047325: Internal API to improve management of direct buffers
Reviewed-by: alanb, mduigou
! make/com/oracle/Makefile
- make/com/oracle/net/Makefile
!
Changeset: 08fdfdb19ad6
Author:coffeys
Date: 2011-06-14 18:05 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08fdfdb19ad6
7049774: UID construction appears to hang if time changed backwards
Reviewed-by: alanb, dholmes, chegar, mduigou
!
Changeset: 48f659a09ed4
Author:coffeys
Date: 2011-04-22 11:03 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48f659a09ed4
7025227: SSLSocketImpl does not close the TCP layer socket if a close notify
cannot be sent to the peer
6932403: SSLSocketImpl state issue
Reviewed-by:
Changeset: 43ae1a1cc7a4
Author:coffeys
Date: 2010-12-10 15:11 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43ae1a1cc7a4
6998583: NativeSeedGenerator is making 8192 byte read requests from entropy
pool on each init.
Reviewed-by: wetmore, andrew, vinnie
!
Changeset: aed81a97aae3
Author:coffeys
Date: 2010-11-05 13:52 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aed81a97aae3
6696028: JMXServiceURL like service:jmx:rmi:///jndi/iiop:// should be rejected
by the RMI conn provider.
6984520: NPE IN RMIConnector.connect
Changeset: 5de001f5f8b4
Author:coffeys
Date: 2010-11-05 17:15 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5de001f5f8b4
6957378: JMX memory leak
Reviewed-by: emcmanus, kevinw
! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
+
49 matches
Mail list logo
