Re: Fix for Javadoc errors in java.base

2020-09-02 Thread Vipin Sharma
Hi Sean, All 3 instances of @exception in DHPrivateKey are now replaced with @throws, added ProviderException similar to other constructor of DHPrivateKey. Updated patch: --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-08-14 23:55:40.921599987 +0530 +++ new

Re: Need sponsor to fix Javadoc warnings

2020-04-15 Thread Vipin Sharma
that incremental patch. That's good. >> >> I couldn't resist fixing a couple of typos in the already affected >> jdk.internal.icu >> (International Components for Unicode) package. Once this has been cleared by >> experts in that area, we are good to go. >>

Re: Need sponsor to fix Javadoc warnings

2020-04-15 Thread Vipin Sharma
oded response. + * @param tsReply A buffer containing the ASN.1 BER encoded response. * @throws IOException The exception is thrown if a problem is encountered * parsing the timestamp response. */ >> On 8 Apr 2020, at 17:35, Vipin Sharma wrote: >> >>

Re: Need sponsor to fix Javadoc warnings

2020-04-08 Thread Vipin Sharma
> On Apr 8, 2020, at 6:57 PM, Pavel Rappo wrote: > > Why assume something that sophisticated where it can be adequately explained > by > a simpler thing? :) I bet it was an IDE inspection. > > -Pavel Yes, it was IDE inspection in java.base, it looked like the best way to start contributing