Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Joe Darcy
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 language feature - "Catching Multiple > Exception Types". > It simplifies code. Reduces duplication. > Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' > statement Core libs changes

Integrated: JDK-8282686: Add constructors taking a cause to SocketException

2022-03-07 Thread Joe Darcy
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote: > Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Ple

Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v3]

2022-03-07 Thread Joe Darcy
.net/browse/JDK-8282688 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Improve test. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7705/files - new: https://git.openjdk.java.net/jdk/pull/7705/files/978b379d..da

Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v2]

2022-03-07 Thread Joe Darcy
.net/browse/JDK-8282688 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Add regression

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Joe Darcy
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

RFR: JDK-8282686: Add constructors taking a cause to SocketException

2022-03-04 Thread Joe Darcy
Please review this small API enhancement to add the usual constructors taking a cause to SocketException and then update uses of initiCause on creating SocketException to instead pass the cause via the constructor. Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-31 Thread Joe Darcy
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively

Integrated: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c11

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]

2022-01-24 Thread Joe Darcy
> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits si

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Joe Darcy
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This should be the (near) final step to fully enable all doclint checks during the javac portion of the build. The "reference" doclint check is currently disabled

RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
Use presumed syntax that will be introduced by JDK-8280488. - Commit messages: - JDK-8280492: Address remaining doclint issues in JDK build Changes: https://git.openjdk.java.net/jdk/pull/7189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7189=00 Issue:

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Joe Darcy
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API

Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-02 Thread Joe Darcy
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place

Re: RFR: 8274835: Remove unnecessary castings in java.base

2021-10-06 Thread Joe Darcy
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to select only casts which are definitely safe to remove. Also didn't > touch primitive types casts. Curious. The JDK build is done with javac

Integrated: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

2021-10-05 Thread Joe Darcy
On Tue, 5 Oct 2021 18:55:09 GMT, Joe Darcy wrote: > Augmentations to javac's Xlint:serial checking are out for review (#5709) and > the sun.net classes in this PR would need some changes to pass under the > expanded checks. > > The changes are to suppress warnings where non-t

RFR: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

2021-10-05 Thread Joe Darcy
Augmentations to javac's Xlint:serial checking are out for review (#5709) and the sun.net classes in this PR would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Joe Darcy
On 8/18/2021 6:20 AM, Roger Riggs wrote: On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) 34

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Darcy
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Joe Darcy
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a terminator, to mark

Integrated: 8250564: Remove terminally deprecated constructor in GSSUtil

2021-01-06 Thread Joe Darcy
On Tue, 5 Jan 2021 21:02:21 GMT, Joe Darcy wrote: > Back in JDK 16, two unintended default constructors were identified and > deprecated for removal. The time has come to remove them. > > Please also review the corresponding CSRs: > > JDK-8258521 Remove terminally depr

RFR: 8250564: Remove terminally deprecated constructor in GSSUtil

2021-01-05 Thread Joe Darcy
Back in JDK 16, two unintended default constructors were identified and deprecated for removal. The time has come to remove them. Please also review the corresponding CSRs: JDK-8258521 Remove terminally deprecated constructor in GSSUtil https://bugs.openjdk.java.net/browse/JDK-8258521

Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Joe Darcy
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/814

Re: JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net

2020-07-24 Thread Joe Darcy
Hi Alan, On 7/24/2020 3:34 AM, Alan Bateman wrote: On 24/07/2020 01:33, Joe Darcy wrote: Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors:     webrev: http://cr.openjdk.java.net/~darcy/8250244.0/     CSR: https

JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net

2020-07-23 Thread Joe Darcy
Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors:     webrev: http://cr.openjdk.java.net/~darcy/8250244.0/     CSR: https://bugs.openjdk.java.net/browse/JDK-8250245 (This is part of a larger effort to remove

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

2019-10-02 Thread Joe Darcy
Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Cheers, -Joe On 10/2/2019 4:26 PM, Ivan Gerasimov wrote: Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't

JDK 12 RFR of JDK-8213911: Use example.com in java.net and other examples

2018-11-26 Thread joe darcy
Hello, Please review a simple doc-only change to address:     JDK-8213911: Use example.com in java.net and other examples     http://cr.openjdk.java.net/~darcy/8213911.0/ Patch below. Thanks, -Joe --- old/src/java.base/share/classes/java/net/HostPortrange.java 2018-11-26

Re: Temporarily remove java/net/httpclient from jdk_net test group

2016-10-25 Thread joe darcy
Looks fine Chris; thanks, -Joe On 10/25/2016 5:55 AM, Chris Hegarty wrote: Hi, There are some intermittent test failures in java/net/httpclient. Since development is ongoing over in the sandbox [1], then it is probably best to exclude these tests from the jdk_net test group, in the JDK 9

JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption

2015-02-09 Thread joe darcy
Hello, Please review these straightforward changes to address some doclint issues in java.net: JDK-8041395: Doclint regression in java.net.SocketOption http://cr.openjdk.java.net/~darcy/8041395.0/ Patch below. Thanks, -Joe ---

JDK 9 RFR of 8031326: Use Class? rather than Class in java.net method signatures

2014-01-07 Thread Joe Darcy
Hello, Please review these changes to remove use of raw Class in some method signatures in java.net: JDK-8031326: Use Class? rather than Class in java.net method signatures Patch below. Thanks, -Joe --- a/src/share/classes/java/net/URL.javaTue Jan 07 09:17:56 2014 -0800 +++

JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net

2014-01-06 Thread Joe Darcy
Hello, Please review the simple patch below to address JDK-8031201: Fix casting lint issues in java.net (The various ObjectInputStream.GetField.get methods which have a default parameter, have an property-typed return value already.) Thanks, -Joe diff -r 9af7c1225730

hg: jdk8/tl/jdk: 8030212: Several api.java.util.stream tests got NaN value instead of Infinity or -Infinity

2014-01-03 Thread joe . darcy
Changeset: 68de5492a06d Author:darcy Date: 2014-01-03 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d 8030212: Several api.java.util.stream tests got NaN value instead of Infinity or -Infinity Reviewed-by: mduigou, psandoz !

hg: jdk8/tl/langtools: 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model)

2013-12-17 Thread joe . darcy
Changeset: 6d1f9d1fd585 Author:darcy Date: 2013-12-17 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d1f9d1fd585 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model) Reviewed-by: jfranck !

hg: jdk8/tl/jdk: 8023471: Add compatibility note to AnnotatedElement

2013-12-06 Thread joe . darcy
Changeset: f8da1f34c65c Author:darcy Date: 2013-12-06 11:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8da1f34c65c 8023471: Add compatibility note to AnnotatedElement Reviewed-by: smarks, jfranck, abuckley ! src/share/classes/java/lang/annotation/Annotation.java !

hg: jdk8/tl/jdk: 8029478: Fix more doclint issues in javax.script

2013-12-03 Thread joe . darcy
Changeset: 1c3d58caa7da Author:darcy Date: 2013-12-03 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c3d58caa7da 8029478: Fix more doclint issues in javax.script Reviewed-by: chegar, mduigou ! src/share/classes/javax/script/ScriptEngineFactory.java

hg: jdk8/tl/jdk: 8029475: Fix more doclint issues in javax.security

2013-12-03 Thread joe . darcy
Changeset: cd4aabc40f72 Author:darcy Date: 2013-12-03 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4aabc40f72 8029475: Fix more doclint issues in javax.security Reviewed-by: juh ! src/share/classes/javax/crypto/Cipher.java !

hg: jdk8/tl/jdk: 8006572: DoubleStream.sum() DoubleSummaryStats implementations that reduce numerical errors

2013-12-01 Thread joe . darcy
Changeset: ca911e383e26 Author:darcy Date: 2013-12-01 23:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca911e383e26 8006572: DoubleStream.sum() DoubleSummaryStats implementations that reduce numerical errors Reviewed-by: psandoz, mduigou !

hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent

2013-11-13 Thread joe . darcy
Changeset: e6333788b117 Author:darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java !

hg: jdk8/tl/jdk: 8028229: Fix more raw types lint warning in core libraries

2013-11-12 Thread joe . darcy
Changeset: 69432cb5bca2 Author:darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck !

hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes

2013-11-08 Thread joe . darcy
Changeset: 11376ad23e21 Author:darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb !

hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types

2013-11-07 Thread joe . darcy
Changeset: e39bd9401ea5 Author:darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel !

hg: jdk8/tl/jdk: 8005294: Consider default methods for additions to AnnotatedElement

2013-10-30 Thread joe . darcy
Changeset: e8894e3224d9 Author:darcy Date: 2013-10-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9 8005294: Consider default methods for additions to AnnotatedElement Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel !

hg: jdk8/tl/jdk: 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager}

2013-10-22 Thread joe . darcy
Changeset: 9a32af82bd1e Author:darcy Date: 2013-10-22 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Reviewed-by: chegar, forax, alanb, mduigou !

hg: jdk8/tl/jdk: 8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread joe . darcy
Changeset: c1700125d041 Author:darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java !

hg: jdk8/tl/langtools: 8026984: Clarity intended use of jdk.Exported

2013-10-21 Thread joe . darcy
Changeset: b82982ac3ca2 Author:darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java

hg: jdk8/tl/langtools: 8026838: Fix new doclint issues in javax.annotation.processing

2013-10-17 Thread joe . darcy
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java

hg: jdk8/tl/jdk: 8026840: Fix new doclint issues in javax.naming

2013-10-17 Thread joe . darcy
Changeset: 8a7b1b615100 Author:darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java !

hg: jdk8/tl/jdk: 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation

2013-10-09 Thread joe . darcy
Changeset: c13309f658e1 Author:darcy Date: 2013-10-09 18:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Reviewed-by: mduigou, briangoetz !

hg: jdk8/tl/langtools: 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer

2013-10-07 Thread joe . darcy
Changeset: 4dd7ffbf01fb Author:darcy Date: 2013-10-07 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8025913: Rename jdk.Supported to jdk.Exported

2013-10-04 Thread joe . darcy
Changeset: 379c04c090cf Author:darcy Date: 2013-10-04 10:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf 8025913: Rename jdk.Supported to jdk.Exported Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg !

hg: jdk8/tl/jdk: 8023827: Fix doclint issues in javax.net.ssl

2013-08-27 Thread joe . darcy
Changeset: 51151b440e95 Author:darcy Date: 2013-08-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51151b440e95 8023827: Fix doclint issues in javax.net.ssl Reviewed-by: wetmore, xuelei ! src/share/classes/javax/net/ssl/SNIHostName.java !

hg: jdk8/tl/langtools: 8023826: Typo in warning about obsolete source / target values

2013-08-27 Thread joe . darcy
Changeset: 662a5188bded Author:darcy Date: 2013-08-27 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/662a5188bded 8023826: Typo in warning about obsolete source / target values Reviewed-by: jjg, wmdietl !

hg: jdk8/tl/jdk: 8023587: Fix lone remaining doclint issue in java.util.regex

2013-08-22 Thread joe . darcy
Changeset: b7c4094be729 Author:darcy Date: 2013-08-22 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7c4094be729 8023587: Fix lone remaining doclint issue in java.util.regex Reviewed-by: jjg ! src/share/classes/java/util/regex/Pattern.java

hg: jdk8/tl/jdk: 8022990: Fix dep_ann lint warnings in swing code

2013-08-14 Thread joe . darcy
Changeset: 444a7edcf367 Author:darcy Date: 2013-08-14 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/444a7edcf367 8022990: Fix dep_ann lint warnings in swing code Reviewed-by: alexsch ! src/share/classes/com/sun/java/swing/Painter.java !

Re: RFR 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-07 Thread Joe Darcy
Hello, Source incompatible changes of this magnitude (if not exact character), have been made in major release before. IMO, release notes are the proper mechanism to inform users of such a change rather than the constructor javadoc. (Putting such time-sensitive notes in javadoc tends to age

hg: jdk8/tl/jdk: 8022454: Fixed various serializations and deprecation warnings in java.util, java.net and sun.tools

2013-08-07 Thread joe . darcy
Changeset: c1f129f62f36 Author:lagergren Date: 2013-08-07 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1f129f62f36 8022454: Fixed various serializations and deprecation warnings in java.util, java.net and sun.tools Reviewed-by: darcy Contributed-by:

hg: jdk8/tl/jdk: 8022174: Fix doclint warnings in javax.sound; ...

2013-08-06 Thread joe . darcy
Changeset: 98643f3ddf40 Author:darcy Date: 2013-08-06 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98643f3ddf40 8022174: Fix doclint warnings in javax.sound 8022404: Fix doclint issues in java.applet Reviewed-by: prr !

hg: jdk8/tl/jdk: 8022406: Fix doclint issues in java.beans

2013-08-06 Thread joe . darcy
Changeset: d5694d78ebc6 Author:darcy Date: 2013-08-06 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5694d78ebc6 8022406: Fix doclint issues in java.beans Reviewed-by: prr ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/Beans.java

hg: jdk8/tl/jdk: 8022453: Fix doclint issues in javax.accessibility

2013-08-06 Thread joe . darcy
Changeset: 6cc8c2ad9804 Author:darcy Date: 2013-08-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc8c2ad9804 8022453: Fix doclint issues in javax.accessibility Reviewed-by: prr ! src/share/classes/javax/accessibility/Accessible.java !

Re: RFR:JDK-8022478 - Fix Warnings In sun.net.www.protocol.http Package

2013-08-06 Thread Joe Darcy
Hi Dan, As we discussed in person, since you are adding serial version uid that matches the existing type, this is fine. Approved to go back. Thanks, -Joe On 08/06/2013 05:57 PM, Dan Xu wrote: Hi All, Please review the [serial] warning fix inside sun.net.www.protocol.http package.

hg: jdk8/tl/jdk: 8022190: Fix varargs lint warnings in the JDK

2013-08-05 Thread joe . darcy
Changeset: 80da091343af Author:darcy Date: 2013-08-05 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80da091343af 8022190: Fix varargs lint warnings in the JDK Reviewed-by: alanb, lancea, alexsch ! src/share/classes/java/util/stream/Stream.java !

hg: jdk8/tl/jdk: 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion

2013-08-02 Thread joe . darcy
Changeset: 33617583c545 Author:bpb Date: 2013-07-31 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33617583c545 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion Summary: Update specification to match implementation. Reviewed-by:

Re: Remaining doclint issues in java.net

2013-08-01 Thread Joe Darcy
On 08/01/2013 03:08 PM, Alan Bateman wrote: On 01/08/2013 14:18, Stuart Marks wrote: : To my eye the InetAddress/port constructors are used quite a bit more often than the SocketAddress ones. I did a web search for java DatagramPacket example and looked at all the examples on the first page

hg: jdk8/tl/jdk: 8021609: Fix doclint issues in java.nio.charset

2013-07-27 Thread joe . darcy
Changeset: eb1dc65162e8 Author:darcy Date: 2013-07-27 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb1dc65162e8 8021609: Fix doclint issues in java.nio.charset Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template

Re: RFR doclint issues in java.net

2013-07-25 Thread Joe Darcy
FWIW, I've filed a bug against doclint to allow ordered lists of the form ol = a JDK-8021324 [doclint] Doclint need not warn over use of ordered lists with styles In any case, the changes below look fine to go back; if you want to leave the ol = a in java.net, that would be fine by me

hg: jdk8/tl/jdk: 8021408: Fix misc doclint issues in java.util and java.io

2013-07-25 Thread joe . darcy
Changeset: 21120e3682ef Author:darcy Date: 2013-07-25 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21120e3682ef 8021408: Fix misc doclint issues in java.util and java.io Reviewed-by: dholmes, chegar, psandoz ! src/share/classes/java/io/ObjectInputStream.java !

hg: jdk8/tl/jdk: 8021429: Fix lint warnings in java.lang.ref

2013-07-25 Thread joe . darcy
Changeset: 86a827321c39 Author:darcy Date: 2013-07-25 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86a827321c39 8021429: Fix lint warnings in java.lang.ref Reviewed-by: lancea, mduigou, alanb ! src/share/classes/java/lang/ref/FinalReference.java !

hg: jdk8/tl/jdk: 8021109: Add serialVersionUID to LambdaConversionException.java

2013-07-22 Thread joe . darcy
Changeset: 7716beb127d4 Author:darcy Date: 2013-07-22 22:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7716beb127d4 8021109: Add serialVersionUID to LambdaConversionException.java Reviewed-by: jrose ! src/share/classes/java/lang/invoke/LambdaConversionException.java

hg: jdk8/tl/jdk: 8020971: Fix doclint issues in java.nio.*

2013-07-20 Thread joe . darcy
Changeset: 4bd04969a228 Author:darcy Date: 2013-07-20 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bd04969a228 8020971: Fix doclint issues in java.nio.* Reviewed-by: lancea ! src/share/classes/java/nio/channels/package-info.java !

hg: jdk8/tl/jdk: 8020948: Fix doclint issues in misc package-info.java files

2013-07-19 Thread joe . darcy
Changeset: e013b32118af Author:darcy Date: 2013-07-19 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e013b32118af 8020948: Fix doclint issues in misc package-info.java files Reviewed-by: dholmes, chegar ! src/share/classes/java/nio/file/attribute/package-info.java !

hg: jdk8/tl/jdk: 8020409: Clean up doclint problems in java.util package, part 1

2013-07-15 Thread joe . darcy
Changeset: 94e1a4b10811 Author:bpb Date: 2013-07-15 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94e1a4b10811 8020409: Clean up doclint problems in java.util package, part 1 Summary: Clean up doclint problems in java.util package, part 1 Reviewed-by: darcy

hg: jdk8/tl/jdk: 8010679: Clarify present and annotation ordering in Core Reflection for Annotations

2013-07-12 Thread joe . darcy
Changeset: af62c6175f92 Author:darcy Date: 2013-07-12 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af62c6175f92 8010679: Clarify present and annotation ordering in Core Reflection for Annotations Reviewed-by: abuckley, jfranck !

Re: [8] Request for review: 8020318: Fix doclint issues in java.net

2013-07-10 Thread Joe Darcy
Hi Jason, Looks good; approved to go back. Thanks, -Joe On 07/10/2013 05:00 PM, Jason Uh wrote: Hi Joe, Please review this changeset, which fixes doclint issues in java.net. Webrev: http://cr.openjdk.java.net/~juh/8020318/webrev.00/ No undesirable changes detected by specdiff. Thanks,

hg: jdk8/tl/jdk: 8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread joe . darcy
Changeset: eab8f4e29f5e Author:darcy Date: 2013-07-08 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab8f4e29f5e 8020095: Fix doclint warnings in java.util.regex Reviewed-by: mchung ! src/share/classes/java/util/regex/MatchResult.java !

hg: jdk8/tl/jdk: 8019857: Fix doclint errors in java.util.Format*

2013-07-03 Thread joe . darcy
Changeset: a49208237599 Author:bpb Date: 2013-07-03 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a49208237599 8019857: Fix doclint errors in java.util.Format* Summary: Fix doclint errors in java.util.Format*. Reviewed-by: darcy Contributed-by: Brian Burkhalter

hg: jdk8/tl/jdk: 8019862: Fix doclint errors in java.lang.*.

2013-07-03 Thread joe . darcy
Changeset: 043b2eb76b0e Author:bpb Date: 2013-07-03 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/043b2eb76b0e 8019862: Fix doclint errors in java.lang.*. Summary: Fix doclint errors in java.lang.* Reviewed-by: darcy Contributed-by: Brian Burkhalter

hg: jdk8/tl/langtools: 7162089: Add support for repeating annotations to javax.annotation.processing

2013-07-01 Thread joe . darcy
Changeset: 1908e86ee49a Author:darcy Date: 2013-07-01 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1908e86ee49a 7162089: Add support for repeating annotations to javax.annotation.processing Reviewed-by: abuckley, jjg, jfranck !

hg: jdk8/tl/jdk: 8019529: Fix doclint issues in java.util.spi

2013-07-01 Thread joe . darcy
Changeset: 8e5376324e4b Author:darcy Date: 2013-07-01 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5376324e4b 8019529: Fix doclint issues in java.util.spi Reviewed-by: lancea ! src/share/classes/java/util/spi/LocaleServiceProvider.java

hg: jdk8/tl/jdk: 8019466: Fix doclint issues in java.util.function

2013-06-30 Thread joe . darcy
Changeset: bf650fee4983 Author:darcy Date: 2013-06-30 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf650fee4983 8019466: Fix doclint issues in java.util.function Reviewed-by: briangoetz ! src/share/classes/java/util/function/BinaryOperator.java !

hg: jdk8/tl/jdk: 8019467: Fix doclint issues in java.util.jar.Pack200

2013-06-30 Thread joe . darcy
Changeset: 9eaeb1a0aa46 Author:darcy Date: 2013-06-30 17:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9eaeb1a0aa46 8019467: Fix doclint issues in java.util.jar.Pack200 Reviewed-by: lancea, ksrini ! src/share/classes/java/util/jar/Pack200.java

hg: jdk8/tl/jdk: 8019407: Fix doclint issues in javax.naming.*

2013-06-28 Thread joe . darcy
Changeset: 9d175c6cb527 Author:darcy Date: 2013-06-28 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d175c6cb527 8019407: Fix doclint issues in javax.naming.* Reviewed-by: lancea ! src/share/classes/javax/naming/CompositeName.java !

hg: jdk8/tl/jdk: 8019304: Fix doclint issues in java.util.prefs

2013-06-27 Thread joe . darcy
Changeset: 1c31082f0a51 Author:darcy Date: 2013-06-27 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c31082f0a51 8019304: Fix doclint issues in java.util.prefs Reviewed-by: lancea ! src/share/classes/java/util/prefs/AbstractPreferences.java !

hg: jdk8/tl/langtools: 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion

2013-06-27 Thread joe . darcy
Changeset: 065f8cb7bd89 Author:darcy Date: 2013-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/065f8cb7bd89 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion Reviewed-by: jjg !

hg: jdk8/tl/jdk: 8019315: Fix doclint issues in java.util.logging

2013-06-27 Thread joe . darcy
Changeset: b8f16cb2d95b Author:darcy Date: 2013-06-27 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8f16cb2d95b 8019315: Fix doclint issues in java.util.logging Reviewed-by: lancea ! src/share/classes/java/util/logging/Handler.java !

hg: jdk8/tl/jdk: 8019320: Fix doclint issues in javax.script

2013-06-27 Thread joe . darcy
Changeset: 1099fe14fb65 Author:darcy Date: 2013-06-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1099fe14fb65 8019320: Fix doclint issues in javax.script Reviewed-by: lancea ! src/share/classes/javax/script/Invocable.java !

hg: jdk8/tl/jdk: 7018139: Fix HTML accessibility and doclint issues in java.math

2013-06-26 Thread joe . darcy
Changeset: 1fda8fa7ae97 Author:darcy Date: 2013-06-26 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fda8fa7ae97 7018139: Fix HTML accessibility and doclint issues in java.math Reviewed-by: lancea, bpb ! src/share/classes/java/math/BigDecimal.java !

hg: jdk8/tl/jdk: 8019223: Fix doclint warnings in java.rmi.server

2013-06-26 Thread joe . darcy
Changeset: a5aa57eb85b6 Author:darcy Date: 2013-06-26 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5aa57eb85b6 8019223: Fix doclint warnings in java.rmi.server Reviewed-by: smarks ! src/share/classes/java/rmi/server/RMIClassLoader.java

hg: jdk8/tl/jdk: 8017550: Fix doclint issues in java.lang and subpackages

2013-06-25 Thread joe . darcy
Changeset: 82e7682c17e2 Author:darcy Date: 2013-06-24 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82e7682c17e2 8017550: Fix doclint issues in java.lang and subpackages Reviewed-by: alanb, chegar ! src/share/classes/java/lang/Boolean.java !

hg: jdk8/tl/langtools: 8016779: Fix doclint warnings in javax.lang.model

2013-06-17 Thread joe . darcy
Changeset: b7a10bc02e7a Author:darcy Date: 2013-06-17 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7a10bc02e7a 8016779: Fix doclint warnings in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/ElementScanner6.java !

hg: jdk8/tl/langtools: 8014836: Have GenericDeclaration extend AnnotatedElement

2013-05-24 Thread joe . darcy
Changeset: 0f8e9a0e5d9a Author:darcy Date: 2013-05-24 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f8e9a0e5d9a 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: jfranck ! src/share/sample/language/model/CoreReflectionFactory.java

hg: jdk8/tl/langtools: 8010680: Clarify present and annotation ordering in javax.lang.model

2013-05-22 Thread joe . darcy
Changeset: 3bd22f99d408 Author:darcy Date: 2013-05-22 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3bd22f99d408 8010680: Clarify present and annotation ordering in javax.lang.model Reviewed-by: abuckley, jjg !

hg: jdk8/tl/jdk: 8014836: Have GenericDeclaration extend AnnotatedElement

2013-05-22 Thread joe . darcy
Changeset: e764bb01567e Author:darcy Date: 2013-05-22 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e764bb01567e 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/Class.java !

hg: jdk8/tl/langtools: 8004133: Provide javax.lang.model.* implementation backed by core reflection

2013-05-15 Thread joe . darcy
Changeset: bcd927639039 Author:darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP

hg: jdk8/tl/jdk: 8014365: Restore Objects.requireNonNull(T, SupplierString)

2013-05-13 Thread joe . darcy
Changeset: a50bad038f31 Author:darcy Date: 2013-05-13 22:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50bad038f31 8014365: Restore Objects.requireNonNull(T, SupplierString) Reviewed-by: mduigou ! src/share/classes/java/util/Objects.java !

hg: jdk8/tl/jdk: 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.*

2013-05-10 Thread joe . darcy
Changeset: f84b5498b2bb Author:darcy Date: 2013-05-10 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f84b5498b2bb 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Reviewed-by: mchung !

hg: jdk8/tl/langtools: 8014365: Restore Objects.requireNonNull(T, SupplierString)

2013-05-10 Thread joe . darcy
Changeset: 1c43236f6d69 Author:darcy Date: 2013-05-10 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1c43236f6d69 8014365: Restore Objects.requireNonNull(T, SupplierString) Reviewed-by: jjg ! makefiles/BuildLangtools.gmk

hg: jdk8/tl/jdk: 8012044: Give more information about self-suppression from Throwable.addSuppressed

2013-04-25 Thread joe . darcy
Changeset: 4da1d43f5843 Author:darcy Date: 2013-04-25 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4da1d43f5843 8012044: Give more information about self-suppression from Throwable.addSuppressed Reviewed-by: alanb, dholmes !

hg: jdk8/tl/jdk: 8011800: Add java.util.Objects.requireNonNull(T, SupplierString)

2013-04-15 Thread joe . darcy
Changeset: baaa706d7677 Author:darcy Date: 2013-04-15 18:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/baaa706d7677 8011800: Add java.util.Objects.requireNonNull(T, SupplierString) Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/util/Objects.java !

hg: jdk8/tl/jdk: 8011930: Long.parseLong(String, int) has inaccurate limit on radix for using 'L'

2013-04-10 Thread joe . darcy
Changeset: b0458dd21ba6 Author:darcy Date: 2013-04-10 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0458dd21ba6 8011930: Long.parseLong(String, int) has inaccurate limit on radix for using 'L' Reviewed-by: smarks ! src/share/classes/java/lang/Long.java

  1   2   3   >