Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Thanks Arthur! I think this is fine. I have done some testing and observed no regression. I believe you should also add the noreg-hard label to 8222562 - since it requires a special set-up to verify that the issue has been fixed. As far as I'm concerned you're good to go with this one! best

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

On Wed, Apr 24, 2019 at 9:03 AM mark sheppard wrote: > an observation on IPv4_supported and IPV6_supported for your consideration > > > > both, IPv4_support and IPv6_support use socket creation in the > appropriate AF domain as a > a verification of support, but the v6 version also checks that

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

10:40 To: Arthur Eubanks; Chris Hegarty Cc: OpenJDK Network Dev list Subject: Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0) Hi Arthur, The jdk.changeset file in your webrev looks completely wrong. http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Hi Arthur, The jdk.changeset file in your webrev looks completely wrong. http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02/jdk.changeset I assume it's just garbage and we should ignore it. Can you confirm? WRT to the individual files changes listed at

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Arthur, > On 23 Apr 2019, at 16:54, Arthur Eubanks wrote: > > ... > New webrev: > http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.02/index.html > Looks good to me. -Chris.

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

On 23/04/2019 16:54, Arthur Eubanks wrote: I believe that `DONT_ENABLE_IPV4`is not strictly required. Maybe just drop it?  Is it an initial attempt to support an IPv6-only JDK build? If so, then maybe we separate out that requirement. It was in the IPv6 code right below so I just

Re: [ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Arthur, On 23/04/2019 11:20, Chris Hegarty wrote: Arthur, On 22/04/2019 19:19, Arthur Eubanks wrote: Here's a new webrev that entirely skips the setting of IPV6_V6ONLY option to 0 if IPv4 isn't enabled. http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.01/index.html This looks

[ipv6] Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Arthur, On 22/04/2019 19:19, Arthur Eubanks wrote: Here's a new webrev that entirely skips the setting of IPV6_V6ONLY option to 0 if IPv4 isn't enabled. http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.01/index.html This looks reasonable to me. -Chris.

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

On Wed, Apr 17, 2019 at 10:58 AM Arthur Eubanks wrote: > It turns out these patches only apply to a modified kernel which has > patches to turn off IPv4. This specific patch doesn't make sense to submit > if the kernel patches are not upstream. > I disagree a little. Google may be decades

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

om: net-dev on behalf of Arthur Eubanks Sent: Wednesday 17 April 2019 17:57 To: Chris Hegarty Cc: OpenJDK Network Dev list Subject: Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0) It turns out these patches only apply to a modified kernel which has patches to turn of

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

It turns out these patches only apply to a modified kernel which has patches to turn off IPv4. This specific patch doesn't make sense to submit if the kernel patches are not upstream. Maybe the entire call to setsockopt(IPV6_V6ONLY, 0) could be skipped if IPv4 is disabled. I'll look into Daniel's

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Arthur, On 16/04/2019 22:34, Arthur Eubanks wrote: Hi, Copied from the bug https://bugs.openjdk.java.net/browse/JDK-8222562: Some of the networking code tries to support dual socket support. However, it doesn't work with IPv6 only systems. setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, 0)

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

Hi Arthur, On 17/04/2019 07:54, Alan Bateman wrote: On 16/04/2019 22:34, Arthur Eubanks wrote: Hi, Copied from the bug https://bugs.openjdk.java.net/browse/JDK-8222562: Some of the networking code tries to support dual socket support. However, it doesn't work with IPv6 only systems.

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

On 16/04/2019 22:34, Arthur Eubanks wrote: Hi, Copied from the bug https://bugs.openjdk.java.net/browse/JDK-8222562: Some of the networking code tries to support dual socket support. However, it doesn't work with IPv6 only systems. setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, 0) returns a