Hi Pavel,
Thanks for the review!
On 07/08/2020 13:49, Pavel Rappo wrote:
May I suggest we use this?
ChannelState s;
assert (s = writeState.get()) == CLOSED : s;
Or better still,
ChannelState s = writeState.get();
assert s == CLOSED : s;
I'll do that before pushing.
t; But as a consequence - I am no longer planning to push it to
> 15 as it also changes some source files:
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8249786/webrev.02/
>
> best regards,
>
> -- daniel
>
> On 21/07/2020 18:53, Daniel Fuchs wrote:
>> Hi,
>> P
Thanks Chris!
best regards,
-- daniel
On 07/08/2020 09:44, Chris Hegarty wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8249786/webrev.02/
LGTM - extending repeatable to cover Windows platforms too.
( the previous problems with these tests came flooding back
when reading the comment in
Daniel,
> On 23 Jul 2020, at 16:02, Daniel Fuchs wrote:
>
> Hi,
>
> More testing revealed that some other tests of the same family
> kept on failing intermittently, though my changes to
> PendingOperation.java should have fixed them.
>
> So here is a broader fix - which seems to have fixed
as it also changes some source files:
http://cr.openjdk.java.net/~dfuchs/webrev_8249786/webrev.02/
best regards,
-- daniel
On 21/07/2020 18:53, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8249786: java/net/httpclient/websocket/PendingPingTextClose.java
fails very
Hi,
Please find below a fix for:
8249786: java/net/httpclient/websocket/PendingPingTextClose.java
fails very infrequently
https://bugs.openjdk.java.net/browse/JDK-8249786
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8249786/webrev.00/
This test has been observed failing
