Re: Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c

2012-10-19 Thread Chris Hegarty
On 10/18/2012 11:27 PM, Kurchi Hazra wrote: Hi John, This change looks good to me. +1, and pushed... http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27f854a1e5c5 -Chris. Thanks, - Kurchi On 18.10.2012 14:18, Dmitry Samersoff wrote: John, Looks good for me. -Dmitry On 2012-10-19 00:59,

Re: Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c

2012-10-18 Thread Kurchi Hazra
Hi John, This change looks good to me. Thanks, - Kurchi On 18.10.2012 14:18, Dmitry Samersoff wrote: John, Looks good for me. -Dmitry On 2012-10-19 00:59, John Zavgren wrote: Greetings: I'm proposing the following change: http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ becau

Re: Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c

2012-10-18 Thread Dmitry Samersoff
John, Looks good for me. -Dmitry On 2012-10-19 00:59, John Zavgren wrote: > Greetings: > I'm proposing the following change: > > http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ > > because it simplifies the code by eliminating an unnecessary union data > structure. This change elim

Change to: ./src/solaris/native/java/net/PlainDatagramSocketImpl.c

2012-10-18 Thread John Zavgren
Greetings: I'm proposing the following change: http://cr.openjdk.java.net/~khazra/john/8000206/webrev.00/ because it simplifies the code by eliminating an unnecessary union data structure. This change eliminates a false positive from our static code analyzer: parfait. This modification doesn't