Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Alan Bateman
Chris Hegarty wrote: : b[] is a char array and not a byte array, so we should be fine here. Thanks for the review. Sorry about that, I guess calling the char[] "b" tricked me into thinking it was a byte[]. -Alan.

Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Chris Hegarty
On 18/10/2010 16:25, Alan Bateman wrote: Chris Hegarty wrote: Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris. Looks okay to except I wonder a

Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Alan Bateman
Chris Hegarty wrote: Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris. Looks okay to except I wonder about Headers.normalize - shouldn't that

Code Review 6992545: find bugs issues

2010-10-18 Thread Chris Hegarty
Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris.