Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2012-07-05 Thread Neil Richards
Hi Chris, Some QA folk round these parts observed the problem in 7. I told them of the fix in 8 [1] they expressed interest in it being backported to 7u. I've confirmed that the problem still exists in the jdk7u code. I've uploaded a webrev of the fix applied back onto jdk7u-dev [2], for

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2012-07-05 Thread Kurchi Hazra
Hi Neil, I do not have a problem with you pushing this fix. Thanks for taking this up. - Kurchi On 7/5/2012 8:48 AM, Neil Richards wrote: Hi Chris, Some QA folk round these parts observed the problem in 7. I told them of the fix in 8 [1] they expressed interest in it being backported to

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2012-07-04 Thread Neil Richards
On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote: Hi, The CookieStore.add() method throws a Null Pointer Exception when null is passed as the uri parameter, although this is allowed according to the method spec. The exception is thrown because uri.getHost() is called on

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2012-07-04 Thread Chris Hegarty
Seems like a reasonable candidate for a backport. Are you encountering it in 7? -Chris On 4 Jul 2012, at 15:19, Neil Richards neil.richa...@ngmr.net wrote: On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote: Hi, The CookieStore.add() method throws a Null Pointer Exception when

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2011-10-03 Thread Chris Hegarty
Thumbs up from me too. -Chris. On 30/09/2011 18:35, Mike Duigou wrote: This fix looks correct. I ran into this bug and this is the same fix I believed would fix the problem. Mike On Sep 30 2011, at 10:08 , Kurchi Hazra wrote: Hi, The CookieStore.add() method throws a Null Pointer

Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2011-09-30 Thread Kurchi Hazra
Hi, The CookieStore.add() method throws a Null Pointer Exception when null is passed as the uri parameter, although this is allowed according to the method spec. The exception is thrown because uri.getHost() is called on a null uri in an effort to add it to the uriIndex, one of

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2011-09-30 Thread Mike Duigou
This fix looks correct. I ran into this bug and this is the same fix I believed would fix the problem. Mike On Sep 30 2011, at 10:08 , Kurchi Hazra wrote: Hi, The CookieStore.add() method throws a Null Pointer Exception when null is passed as the uri parameter, although this is