Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-10 Thread Chris Hegarty
On 10/08/12 17:28, Alan Bateman wrote: On 10/08/2012 17:10, Chris Hegarty wrote: Christian, I finally got back to this. Since init() is only ever called from the class initializer it is implicitly single threaded, so we only need to add the synchronized keyword to getSystemProxy(). I also

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-03 Thread Chris Hegarty
On 02/08/12 16:47, Andrew Hughes wrote: - Original Message - Thanks for the cross post David. Yes, net-dev is the best place to discuss this issue ( bcc'ing off jdk7u-dev ). Thanks for reporting this issue Christian. I haven't looked at the proposed patch yet, but I agree we may want

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread David Holmes
Hi Christian, Probably best to discuss this on the net-dev@openjdk.java.net list (cc'd). Two comments from me (I'm not on net-dev): 1. CHECK_NULL does a return so you will be leaving the monitor locked if you encounter any nulls. 2. Is it simpler to add synchronization at the Java level? (I

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread Andrew Hughes
- Original Message - Thanks for the cross post David. Yes, net-dev is the best place to discuss this issue ( bcc'ing off jdk7u-dev ). Thanks for reporting this issue Christian. I haven't looked at the proposed patch yet, but I agree we may want to simplify this if possible (

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread Christian Schulte
Am 08/02/12 17:27, schrieb Chris Hegarty: Thanks for the cross post David. Yes, net-dev is the best place to discuss this issue ( bcc'ing off jdk7u-dev ). Thanks for reporting this issue Christian. I haven't looked at the proposed patch yet, but I agree we may want to simplify this if possible