Here is the JDK8 changeset, to close the loop on this one. Note, the
change is slightly different to the patch posted.
Changeset: 5c1f90dd0405
Author:chegar
Date: 2011-08-22 14:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c1f90dd0405
7023713: HttpCookie.domainMatches
Thank you very much!
2011/8/19 Chris Hegarty
> Hi Sean,
>
> I submitted a JPRT job with you patch. If all builds and tests are
> successful I'll push this change for you.
>
> diff -r 46b53f80ab0a src/share/classes/java/net/**HttpCookie.java
> --- a/src/share/classes/java/net/**HttpCookie.java
Hi Sean,
I submitted a JPRT job with you patch. If all builds and tests are
successful I'll push this change for you.
diff -r 46b53f80ab0a src/share/classes/java/net/HttpCookie.java
--- a/src/share/classes/java/net/HttpCookie.javaFri Aug 19
10:55:05 2011 +0100
+++ b/src/share/classes/
Sorry for the delay on this Sean, I owe you a reply. I'll try to get to
this in the next few days.
-Chris.
On 8/4/2011 8:09 AM, Sean Chou wrote:
Hi all,
I checked with java8, this problem still exists; and I checked the
patch, it is still working.
The bug was filed with id 7023713 for
Hi all,
I checked with java8, this problem still exists; and I checked the patch,
it is still working.
The bug was filed with id 7023713 for java7, and the patch is here. So,
would anyone like to
take a look at it again? Thanks.
2011/2/22 Sean Chou
> Hi,
>I find that HttpCookie.domainMat
Hi guys,
Is there any update to this bug? or is it targeted to java8?
2011/3/17 Chris Hegarty
> Hi Sean,
>
> I applied your patch to my local repo and it doesn't compile, startWith ->
> startsWith ;-)
>
> More critically it doesn't resolve the problem, isLocalDomain will be false
> for 'host
Hi Chris,
Is there any progress on this issue?
--
Best Regards,
Sean Chou
Thank Chris.
Here is an alternative fix, with the TestHttpCookie.java updated
together.
diff -r 554adcfb615e src/share/classes/java/net/HttpCookie.java
--- a/src/share/classes/java/net/HttpCookie.java Wed Mar 16 15:01:07 2011
-0700
+++ b/src/share/classes/java/net/HttpCookie.java Thu Mar 17 1
Hi Sean,
I applied your patch to my local repo and it doesn't compile, startWith
-> startsWith ;-)
More critically it doesn't resolve the problem, isLocalDomain will be
false for 'hostname.local'.
I am working on an alternative fix ( please feel free to work on an
alternative fix also). Ad
Hi,
Is there any update to this issue? If not, I have a simple patch as
follows:
diff -r e947a98ea3c1 src/share/classes/java/net/HttpCookie.java
--- a/src/share/classes/java/net/HttpCookie.javaThu Mar 10 17:11:08 2011
-0800
+++ b/src/share/classes/java/net/HttpCookie.javaMon Mar 14 16:
On 03/ 2/11 01:50 AM, Sean Chou wrote:
Hi,
If there's no different opinions or objection, can someone raise a
bug on the Oracle bug system for me please?
Sorry, I though I replied to this.
It would appear to be a bug. I filed CR 7023713,
"HttpCookie.domainMatches("hostname.local", "hostna
Hi,
If there's no different opinions or objection, can someone raise a bug on
the Oracle bug system for me please?
Thanks.
2011/2/22 Sean Chou
> Hi,
>I find that HttpCookie.domainMatches("hostname.local", "hostname")
> returns false, which may be a bug.
>According to spec, the eff
Hi,
I find that HttpCookie.domainMatches("hostname.local", "hostname")
returns false, which may be a bug.
According to spec, the effective host name of "hostname" is
"hostname.local", which is string
exactly the same with the first parameter. Thus the method should return
true for this invoca
13 matches
Mail list logo
