Thanks Pavel, I will keep this in mind for future patches.
> On Apr 15, 2020, at 10:22 PM, Pavel Rappo wrote:
>
> Vipin,
>
> After a private exchange with Naoto Sato, who is fluent in that area, I
> decided
> to leave out all the changes to the jdk.internal.icu package from the
> changeset.
>
Hi Pavel,
> On Apr 9, 2020, at 2:45 AM, Pavel Rappo wrote:
>
> If your new patch addresses a similar type of problem, please send it in
> reply to this email,
> so that I could merge it with the existing patch. Let's try to minimize
> process overhead if possible.
>
This is additional patch:
Vipin,
After a private exchange with Naoto Sato, who is fluent in that area, I decided
to leave out all the changes to the jdk.internal.icu package from the changeset.
The reason is quite simple. A significant portion of code in jdk.internal.icu
comes from an upstream project, ICU4J. Making OpenJ
Vipin,
I saw that Max had already reviewed that incremental patch. That's good.
I couldn't resist fixing a couple of typos in the already affected
jdk.internal.icu
(International Components for Unicode) package. Once this has been cleared by
experts in that area, we are good to go.
Here's the c
The additional patch looks fine to me.
Thanks,
Max
> On Apr 12, 2020, at 3:23 AM, Vipin Sharma wrote:
>
> Hi Pavel,
>
>> On Apr 9, 2020, at 2:45 AM, Pavel Rappo wrote:
>>
>> If your new patch addresses a similar type of problem, please send it in
>> reply to this email,
>> so that I could m
Hi Pavel,
On 8/04/2020 11:23 pm, Pavel Rappo wrote:
Hey David,
Where exactly? In the files affected by this changeset? If so, then we will
introduce inconsistency. Otherwise it's a huge change. From what I can see there
are some 250 occurrences of `@exception` in
src/java.base/share/classes/co
If your new patch addresses a similar type of problem, please send it in reply
to this email,
so that I could merge it with the existing patch. Let's try to minimize process
overhead if possible.
> On 8 Apr 2020, at 17:35, Vipin Sharma wrote:
>
>
>
>> On Apr 8, 2020, at 6:57 PM, Pavel Rappo
> On Apr 8, 2020, at 6:57 PM, Pavel Rappo wrote:
>
> Why assume something that sophisticated where it can be adequately explained
> by
> a simpler thing? :) I bet it was an IDE inspection.
>
> -Pavel
Yes, it was IDE inspection in java.base, it looked like the best way to start
contributing
On 08/04/2020 12:50, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
Hi Pavel,
That looks good to me.
WRT to the @exception changes I'll leave that responsibility
to Sean ;-)
best regards,
Why assume something that sophisticated where it can be adequately explained by
a simpler thing? :) I bet it was an IDE inspection.
-Pavel
> On 8 Apr 2020, at 14:14, Alan Bateman wrote:
>
> On 08/04/2020 14:07, Daniel Fuchs wrote:
>> Hi Pavel,
>>
>> On 08/04/2020 13:56, David Holmes wrote:
>>>
Hey David,
Where exactly? In the files affected by this changeset? If so, then we will
introduce inconsistency. Otherwise it's a huge change. From what I can see there
are some 250 occurrences of `@exception` in
src/java.base/share/classes/com/sun/{crypto, security}
and some 7,300 in src.
Person
On 08/04/2020 14:07, Daniel Fuchs wrote:
Hi Pavel,
On 08/04/2020 13:56, David Holmes wrote:
and `@exception` tags for checked exceptions that were neither thrown
nor imported
Hopefully that's only on internal classes.
From a quick scan, the changes are to internal classes and a few
non-publi
The security changes look fine to me.
--Sean
On 4/8/20 7:50 AM, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a ty
Hi Pavel,
On 08/04/2020 13:56, David Holmes wrote:
and `@exception` tags for checked exceptions that were neither thrown
nor imported
Hopefully that's only on internal classes.
It might be prudent to separate this out in a different
changeset. It's not always obvious where an exception
is thro
Hi Pavel,
Not a review ...
On 8/04/2020 9:50 pm, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a typo, and `@excep
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a typo, and `@exception` tags for checked exceptions that were neither thrown
nor imported.
16 matches
Mail list logo
