RE: PING: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

2016-07-22 Thread Langer, Christoph
s.hega...@oracle.com] > Sent: Donnerstag, 21. Juli 2016 17:15 > To: Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net > Subject: Re: PING: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and > improvements for network interface listing > > Hi Chr

Re: PING: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

2016-07-21 Thread Chris Hegarty
Hi Christoph, On 19/07/16 14:48, Langer, Christoph wrote: Hi all, can I please get a review for my change: http://cr.openjdk.java.net/~clanger/webrevs/8160174.3/ ? This really hard to review, since so many parts of the code are moving around, but we did put this off a few times already so

PING: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

2016-07-19 Thread Langer, Christoph
Hi all, can I please get a review for my change: http://cr.openjdk.java.net/~clanger/webrevs/8160174.3/ ? I made some minor updates in place, mostly formatting, to the version from one week ago. The only real change I made is that I now set the scope id of IPv6 addresses to the interface