RE: RFR(L): 8167295: Further cleanup to the native parts of libnet/libnio

2016-10-10 Thread Langer, Christoph
regards Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Montag, 10. Oktober 2016 14:08 > To: Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net > Cc: nio-...@openjdk.java.net > Subject: Re: RFR(L):

Re: RFR(L): 8167295: Further cleanup to the native parts of libnet/libnio

2016-10-10 Thread Chris Hegarty
Hi Christoph, On 07/10/16 16:17, Langer, Christoph wrote: Hi again, I have respun my patch a little bit: http://cr.openjdk.java.net/~clanger/webrevs/8167295.1/ This is a nice cleanup and an improvement to the code. Specifically, adding 'struct sockaddr sa' to SOCKETADDRESS allows for the

RE: RFR(L): 8167295: Further cleanup to the native parts of libnet/libnio

2016-10-07 Thread Langer, Christoph
Hi again, I have respun my patch a little bit: http://cr.openjdk.java.net/~clanger/webrevs/8167295.1/ The reason is that the naming of the members of SOCKETADDRESS should be changed to 'sa' instead of 'him' as the fields are of type 'struct sockaddr...'. I also did a careful inspection of the