RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

...@oracle.com] > >> Sent: Donnerstag, 12. Mai 2016 12:43 > >> To: Langer, Christoph <christoph.lan...@sap.com> > >> Cc: Alan Bateman <alan.bate...@oracle.com>; Dmitry Samersoff > >> <dmitry.samers...@oracle.com>; Mark Sheppard > >> <mark.sh

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

m>; Dmitry Samersoff >> <dmitry.samers...@oracle.com>; Mark Sheppard >> <mark.shepp...@oracle.com>; net-dev@openjdk.java.net >> Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c >> >> On 11 May 2016, at 22:27, Langer, Christoph

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

..@oracle.com>; net-dev@openjdk.java.net > Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c > > On 11 May 2016, at 22:27, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > > Hi again, > > > > I'm done with the new ve

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

t: Mittwoch, 11. Mai 2016 12:25 >> To: Langer, Christoph <christoph.lan...@sap.com> >> Cc: Alan Bateman <alan.bate...@oracle.com>; Dmitry Samersoff >> <dmitry.samers...@oracle.com>; net-dev@openjdk.java.net >> Subject: Re: RFR(S): 8156521: Minor Fixes and clean

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

12:25 > To: Langer, Christoph <christoph.lan...@sap.com> > Cc: Alan Bateman <alan.bate...@oracle.com>; Dmitry Samersoff > <dmitry.samers...@oracle.com>; net-dev@openjdk.java.net > Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

the declaration in of plen (also scope and dad_status) as an int in enumIPv6Interfaces would appear to be done to align with its use in fscanf, even though it is a two character conversion. So would it not be more appropriate to cast it as a short when passed to addif ? the name plen would

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

On 11 May 2016, at 10:21, Langer, Christoph wrote: > Hi, > > @Chris: As for your points: > >> I agree with the replacement of strcpy with strncpy, but I think we should >> explicitly null terminate in case the src is greater or equal to the dst >> buffer >> size.

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

Hi, @Chris: As for your points: > I agree with the replacement of strcpy with strncpy, but I think we should > explicitly null terminate in case the src is greater or equal to the dst > buffer > size. This is done elsewhere in this file too, e.g. > >strncpy(buf, input, sizeof(buf) - 1); >

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

On 11/05/2016 09:50, Chris Hegarty wrote: Hi Christoph, On 11 May 2016, at 08:43, Dmitry Samersoff wrote: ... bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ I think this is mainly

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

Hi Christoph, On 11 May 2016, at 08:43, Dmitry Samersoff wrote: >> ... >> bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 >> >> webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ I think this is mainly fine, and good to have such cleanup in

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

Christoph, Looks good for me (Reviewed). Few more space nits (no need to re-review) 1141 Missed space around = in i=0 1890 extra space after ( 2068 wrong indent -Dmitry On 2016-05-10 12:54, Langer, Christoph wrote: > Hi all, > > > > can I please get a review for a change to

RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

Hi all, can I please get a review for a change to NetworkInterface.c bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ Apart from quite a few whitespace changes to clean up the coding, I went through and replaced all