Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Ok. Will do 03.10.16 17:22, Chris Hegarty wrote: On 03/10/16 15:19, Sergei Kovalev wrote: Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ This looks fine. Reviewed. No need to generate the webrev, but can you please check that you list the java.* modules before the jdk.* on

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Chris Hegarty
On 03/10/16 15:19, Sergei Kovalev wrote: Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ This looks fine. Reviewed. No need to generate the webrev, but can you please check that you list the java.* modules before the jdk.* ones. Thanks, -Chris. 03.10.16 17:07, Alan Bateman

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ 03.10.16 17:07, Alan Bateman wrote: On 03/10/2016 15:05, Sergei Kovalev wrote: Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/packag

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Alan Bateman
On 03/10/2016 15:05, Sergei Kovalev wrote: Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED. -- With best regar

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Chris Hegarty
On 03/10/16 14:43, Sergei Kovalev wrote: Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ java.compiler already exports javax.tools so no need for the explicit export in the @modules tag. Otherwise this is fine. -Chris. 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:3

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test E

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Alan Bateman
On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CB

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Hi Chris, Thank you for looking this. 03.10.16 16:05, Chris Hegarty wrote: Sergei, On 03/10/16 11:08, Sergei Kovalev wrote: Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.n

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Chris Hegarty
Sergei, On 03/10/16 11:08, Sergei Kovalev wrote: Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webr

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed

RFR(s): 8166791: Fix module dependencies for networking component tests

2016-09-27 Thread Sergei Kovalev
Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option.