Re: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-15 Thread Chris Hegarty
On 01/15/2013 08:29 AM, Alan Bateman wrote: On 14/01/2013 22:24, Mark Sheppard wrote: Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support in various packages to utilize the base64 support from java.util.Base64. This is

Re: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-15 Thread Alan Bateman
On 14/01/2013 22:24, Mark Sheppard wrote: Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support in various packages to utilize the base64 support from java.util.Base64. This is the modification of com.sun.net.httpserver.B

Re: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-14 Thread Kurchi Subhra Hazra
The change looks ok. You might want to move the comments on this bug to 8006153 for the sake of book-keeping. Thanks, Kurchi On 1/14/13 2:24 PM, Mark Sheppard wrote: Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support i

RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-14 Thread Mark Sheppard
Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support in various packages to utilize the base64 support from java.util.Base64. This is the modification of com.sun.net.httpserver.BasicAuthenticator.java to use java.util.Bas

Re: Fwd: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-11 Thread Alan Bateman
On 11/01/2013 21:54, Chris Hegarty wrote: The source changes look fine to me Mark. I think you may the the wrong bug number, or synopsis. The changes are in the basic and negotiate authenticators used by the Http client, HttpURLConnection. Anyway, the source changes look good to me. I can sp

Re: Fwd: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-11 Thread Chris Hegarty
The source changes look fine to me Mark. I think you may the the wrong bug number, or synopsis. The changes are in the basic and negotiate authenticators used by the Http client, HttpURLConnection. Anyway, the source changes look good to me. I can sponsor this for you. -Chris. On 11/01/2013

Fwd: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-11 Thread Mark Sheppard
A review request for JDK-8005406: HTTP server implementation should use Base64 API Description: jdk8 has java.util.Base64 to define a standard API for base64 encoding/decoding. It would be good to investigate whether this API could be used in the com.sun.net.httpserver implementation to replac