Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-12 Thread Alan Bateman
On 11/12/2017 17:24, Martin Buchholz wrote: There's now a Martin-style benchmark at http://cr.openjdk.java.net/~martin/webrevs/jdk/URLMicroBenchmark/ that suggests the code is ~ 25% faster with default JVM flags (C2) but ~ 25

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-12 Thread Chris Hegarty
Martin, I think your changes are good. Thanks for sharing your benchmark and results. -Chris. On 11/12/17 17:24, Martin Buchholz wrote: There's now a Martin-style benchmark at http://cr.openjdk.java.net/~martin/webrevs/jdk/URLMicroBenchmark/ that suggests the code is ~ 25% faster with default

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-11 Thread Martin Buchholz
There's now a Martin-style benchmark at http://cr.openjdk.java.net/~martin/webrevs/jdk/URLMicroBenchmark/ that suggests the code is ~ 25% faster with default JVM flags (C2) but ~ 25% slower with C1, as you might expect with multiple String concatenation. I think we want to optimize for the default

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-05 Thread Alan Bateman
On 05/12/2017 04:01, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/ The style is interesting but I don't see anything obvious wrong. -Alan

Re: RFR: 8193034: Optimize URL.toExternalForm

2017-12-05 Thread Chris Hegarty
> On 5 Dec 2017, at 04:01, Martin Buchholz wrote: > > http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/ Since the motivation for this change is performance, do you have any performance numbers / benchmarks that you can share? -Chris.

RFR: 8193034: Optimize URL.toExternalForm

2017-12-04 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/