Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-16 Thread mark sheppard
/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic Hi Mark, AFAIU the test wants to verify that connections are reused. It does that by creating N (N=5) threads that will hammer at the server concurrently. Because there are N threads, then there can't be more t

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-16 Thread Daniel Fuchs
Hi Mark, AFAIU the test wants to verify that connections are reused. It does that by creating N (N=5) threads that will hammer at the server concurrently. Because there are N threads, then there can't be more than N concurrent requests, and therefore there should not be more than N connections a

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-15 Thread mark sheppard
grep "client 4: read" MTHUCT-4.out | wc​ 20 100 500 ____ From: net-dev on behalf of Daniel Fuchs Sent: Wednesday 15 May 2019 17:49 To: Chris Hegarty; OpenJDK Network Dev list Subject: Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadT

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-15 Thread Daniel Fuchs
On 15/05/2019 16:17, Chris Hegarty wrote: I believe workers should be volatile/synchronized, as it is written and read from different threads, no? Thanks Chris. workers is a concurrent queue, but the variable should be final. I'll do it before pushing. best regards, -- daniel -Chris.

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-15 Thread Chris Hegarty
Daniel On 13/05/2019 19:29, Daniel Fuchs wrote: ... http://cr.openjdk.java.net/~dfuchs/webrev_8223716/webrev.00/ I think the approach of pushing this improvement, and filing a separate issue to track the minor loosening of the constraints is reasonable. I believe workers should be volatile/sy

RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

2019-05-13 Thread Daniel Fuchs
Hi, Please find below a fix for: [1] 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic Occasionally a test server may receive traffic that doesn't originate from the client in the test. If the client makes requests that are recogn