Re: RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-05 Thread Alan Bateman
On 05/12/2019 15:14, Julia Boes wrote: Hi, I wonder however if the links to the deprecated setInterface method should remain in the two args joinGroup/leaveGroup, since the behavior is still in effect should you call that method. Agreed, I updated the webrev and specdiff accordingly. http

Re: RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-05 Thread Daniel Fuchs
Looks good to me Julia! Best regards, -- daniel On 05/12/2019 15:14, Julia Boes wrote: Hi, I wonder however if the links to the deprecated setInterface method should remain in the two args joinGroup/leaveGroup, since the behavior is still in effect should you call that method. Agreed, I up

Re: RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-05 Thread Julia Boes
Hi, I wonder however if the links to the deprecated setInterface method should remain in the two args joinGroup/leaveGroup, since the behavior is still in effect should you call that method. Agreed, I updated the webrev and specdiff accordingly. http://cr.openjdk.java.net/~jboes/webrevs/82333

Re: RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-04 Thread Daniel Fuchs
Hi Julia, Looks good to me. I wonder however if the links to the deprecated setInterface method should remain in the two args joinGroup/leaveGroup, since the behavior is still in effect should you call that method. best regards -- daniel On 04/12/2019 16:40, Julia Boes wrote: Hi, Please see

Re: RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-04 Thread Chris Hegarty
Julia, On 04/12/2019 16:40, Julia Boes wrote: Hi, Please see this fix that deprecates methods of MulticastSocket. These methods either operate on InetAddress instead of NetworkInterface or work with SocketOptions.IP_MULTICAST_LOOP instead of StandardSocketOptions.IP_MULTICAST_LOOP. Bug: ht

RFR: 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress

2019-12-04 Thread Julia Boes
Hi, Please see this fix that deprecates methods of MulticastSocket. These methods either operate on InetAddress instead of NetworkInterface or work with SocketOptions.IP_MULTICAST_LOOP instead of StandardSocketOptions.IP_MULTICAST_LOOP. Bug: https://bugs.openjdk.java.net/browse/JDK-8233319