Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-23 Thread Daniel Fuchs
On Mon, 13 Sep 2021 11:44:17 GMT, Masanori Yano wrote: >> I have run this change on one of our machines that support SCTP. I did get >> some intermittent failures with the other SCTP tests - they don't seem much >> stable - but the new proposed test was failing all the time. I suspect that >>

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v4]

2021-09-23 Thread Daniel Fuchs
On Wed, 22 Sep 2021 12:27:03 GMT, Masanori Yano wrote: >> Please review this change to the Unix implementations of >> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() >> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a >> check for the ST_KILLED state.) >

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-22 Thread Masanori Yano
On Thu, 16 Sep 2021 10:33:09 GMT, Daniel Fuchs wrote: >> I pushed a fix to run the test in othervm mode. Please test again. > > Meanwhile I did some experiment and was puzzled by the fact that the new test > still failed intermittently - while the corresponding > SctpMultiChannel/CloseDescripto

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v4]

2021-09-22 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request incrementally with

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-16 Thread Daniel Fuchs
On Tue, 14 Sep 2021 10:14:45 GMT, Masanori Yano wrote: >> test/jdk/com/sun/nio/sctp/SctpChannel/CloseDescriptors.java line 29: >> >>> 27: * @summary Potential leak file descriptor for SCTP >>> 28: * @requires (os.family == "linux") >>> 29: * @run main CloseDescriptors >> >> The test SctpMult

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v3]

2021-09-14 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request incrementally with

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-14 Thread Masanori Yano
On Mon, 13 Sep 2021 13:18:10 GMT, Daniel Fuchs wrote: >> Masanori Yano has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commi

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-13 Thread Daniel Fuchs
On Mon, 13 Sep 2021 11:48:22 GMT, Masanori Yano wrote: >> Please review this change to the Unix implementations of >> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() >> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a >> check for the ST_KILLED state.) >

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-13 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request with a new target

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-13 Thread Masanori Yano
On Thu, 2 Sep 2021 14:24:24 GMT, Daniel Fuchs wrote: >> Please review this change to the Unix implementations of >> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() >> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a >> check for the ST_KILLED state.) > >

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-02 Thread Daniel Fuchs
On Fri, 27 Aug 2021 08:37:46 GMT, Masanori Yano wrote: > Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) I ha

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-08-28 Thread Alan Bateman
On Fri, 27 Aug 2021 08:37:46 GMT, Masanori Yano wrote: > Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) As t

RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-08-27 Thread Masanori Yano
Please review this change to the Unix implementations of sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a check for the ST_KILLED state.) - Commit messages: - 8238274: (sctp) JDK-7118373 is not