Re: RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-28 Thread Mark Sheppard
On Tue, 27 Oct 2020 12:12:47 GMT, Michael McMahon wrote: >> A small improvement to avoid extra string copy. >> >> [Tests] >> Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. >> No new failure found. > > LGTM In the original the copy would appear to be a way of enforcing t

Re: RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-27 Thread Michael McMahon
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu wrote: > A small improvement to avoid extra string copy. > > [Tests] > Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. > No new failure found. LGTM - Marked as reviewed by michaelm (Reviewer). PR: https://git.ope

Re: RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-27 Thread Michael McMahon
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu wrote: > A small improvement to avoid extra string copy. > > [Tests] > Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. > No new failure found. src/java.base/unix/native/libnet/NetworkInterface.c line 232: > 230: // if it i

Re: RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-26 Thread Eric Liu
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu wrote: > A small improvement to avoid extra string copy. > > [Tests] > Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. > No new failure found. @kimbarrett Could you help to take look at this trivial patch? - PR: h

RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-22 Thread Eric Liu
A small improvement to avoid extra string copy. [Tests] Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. No new failure found. - Commit messages: - 8254871: Remove unnecessary string copy in NetworkInterface.c Changes: https://git.openjdk.java.net/jdk/pull/82