Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-04 Thread Andrey Turbanov
On Fri, 4 Dec 2020 10:14:19 GMT, Daniel Fuchs wrote: >> @dfuch, are you still good with this? Please submit your formal review here >> :) > > Thanks for running the tests Andrei. I will sponsor. Few tests failed with `make test-tier2`: == Test summary ===

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-04 Thread Daniel Fuchs
On Fri, 4 Dec 2020 08:47:16 GMT, Aleksey Shipilev wrote: >> Looks good to me. > > @dfuch, are you still good with this? Please submit your formal review here :) Thanks for running the tests Andrei. I will sponsor. - PR: https://git.openjdk.java.net/jdk/pull/1495

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-04 Thread Aleksey Shipilev
On Fri, 4 Dec 2020 08:36:36 GMT, Aleksey Shipilev wrote: >> Incorrect format string was found by IntelliJ IDEA inspection `Java | >> Probable bugs | Malformed format string` > > Looks good to me. @dfuch, are you still good with this? Please submit your formal review here :) - PR:

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-04 Thread Aleksey Shipilev
On Sat, 28 Nov 2020 19:42:01 GMT, Andrey Turbanov wrote: > Incorrect format string was found by IntelliJ IDEA inspection `Java | > Probable bugs | Malformed format string` Looks good to me. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1495

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Aleksey Shipilev
On Fri, 4 Dec 2020 06:33:35 GMT, Aleksey Shipilev wrote: >> make test-tier2 fails with error on my machine: :( >> user@WORK-PC /cygdrive/f/Projects/official_openjdk >> $ make test-tier2 >> Building target 'test-tier2' in configuration 'windows-x86_64-server-release' >> Compiling 127 files for jav

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Aleksey Shipilev
On Thu, 3 Dec 2020 20:05:36 GMT, Andrey Turbanov wrote: > === Output from failing command(s) repeated here === > * For target > hotspot_variant-server_libjvm_objs_bytecodeInterpreterWithChecks.obj: > bytecodeInterpreterWithChecks.cpp > ./build/windows-x86_64-server-release/hotspot/variant-serve

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Andrey Turbanov
On Thu, 3 Dec 2020 19:01:12 GMT, Daniel Fuchs wrote: >> Submitted: https://bugs.openjdk.java.net/browse/JDK-8257707 -- rename this >> PR to "8257707: Fix incorrect format string in Http1HeaderParser" to get it >> hooked here. Also, merge from master to get Windows builds fixed and >> re-tested

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Daniel Fuchs
On Thu, 3 Dec 2020 17:42:00 GMT, Aleksey Shipilev wrote: >> Incorrect format string was found by IntelliJ IDEA inspection `Java | >> Probable bugs | Malformed format string` > > Submitted: https://bugs.openjdk.java.net/browse/JDK-8257707 -- rename this PR > to "8257707: Fix incorrect format str

RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Turbanov Andrey
Incorrect format string was found by IntelliJ IDEA inspection `Java | Probable bugs | Malformed format string` - Commit messages: - [PATCH] Fix incorrect format string in Http1HeaderParser Changes: https://git.openjdk.java.net/jdk/pull/1495/files Webrev: https://webrevs.openjdk.ja

Re: RFR: 8257707: Fix incorrect format string in Http1HeaderParser

2020-12-03 Thread Aleksey Shipilev
On Sat, 28 Nov 2020 19:42:01 GMT, Turbanov Andrey wrote: > Incorrect format string was found by IntelliJ IDEA inspection `Java | > Probable bugs | Malformed format string` Submitted: https://bugs.openjdk.java.net/browse/JDK-8257707 -- rename this PR to "8257707: Fix incorrect format string in