Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:58:12 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> com

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
On Tue, 1 Jun 2021 17:46:10 GMT, Alan Bateman wrote: >> Sorry about that. I've changed it now. See 2f179b5 > > This still looks a bit messy because you've got 3 different styles in the one > switch statement. It's okay to drop FileTime from the patch if you want as > it's not worth spending tim

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w