Re: RFR: 8277120: Use Optional.isEmpty instead of !Optional.isPresent in java.net.http

2021-12-07 Thread Alan Bateman
On Mon, 15 Nov 2021 13:20:30 GMT, Daniel Fuchs wrote: >> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty >> method. >> It's makes code a bit easier to read. > > LGTM I suspect @dfuch will sponsor this once he's had a chance to run the tests. - PR:

Re: RFR: 8277120: Use Optional.isEmpty instead of !Optional.isPresent in java.net.http

2021-11-15 Thread Daniel Fuchs
On Mon, 18 Oct 2021 07:55:52 GMT, Andrey Turbanov wrote: > I propose to replace usages of !Optional.isPresent() with Optional.isEmpty > method. > It's makes code a bit easier to read. LGTM - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5985

RFR: 8277120: Use Optional.isEmpty instead of !Optional.isPresent in java.net.http

2021-11-15 Thread Andrey Turbanov
I propose to replace usages of !Optional.isPresent() with Optional.isEmpty method. It's makes code a bit easier to read. - Commit messages: - [PATCH] Use Optional.isEmpty instead of !Optional.isPresent in java.net.http Changes: https://git.openjdk.java.net/jdk/pull/5985/files