Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-20 Thread Daniel Fuchs
On Sat, 16 Apr 2022 11:06:21 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling requ

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-20 Thread Michael McMahon
On Sat, 16 Apr 2022 11:06:21 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling requ

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-16 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v8]

2022-04-16 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v7]

2022-04-15 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v6]

2022-04-15 Thread Daniel Fuchs
On Fri, 15 Apr 2022 14:35:33 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling requ

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v6]

2022-04-15 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v5]

2022-04-15 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v4]

2022-04-08 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-04-08 Thread Michael McMahon
On Thu, 10 Mar 2022 11:17:26 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling requ

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-03-11 Thread Jaikiran Pai
On Thu, 10 Mar 2022 11:17:26 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling requ

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-03-10 Thread Daniel Fuchs
On Thu, 10 Mar 2022 10:44:45 GMT, Jaikiran Pai wrote: >> The acquire() method will return true the first time it's been called. And >> it is called only once. So we only need to check whether `acquired` is true >> at places where we are in doubt about whether the method has been called. >> The

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-03-10 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-03-10 Thread Jaikiran Pai
On Thu, 10 Mar 2022 10:41:23 GMT, Daniel Fuchs wrote: > The acquire() method will return true the first time it's been called. And it > is called only once. So we only need to check whether acquired is true at > places where we are in doubt about whether the method has been called. I see what

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-10 Thread Jaikiran Pai
On Wed, 9 Mar 2022 16:54:58 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling reque

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-10 Thread Daniel Fuchs
On Thu, 10 Mar 2022 10:08:16 GMT, Jaikiran Pai wrote: >> tryRelease can be called multiple time - it will only decrement the ref >> counting once. It could happen when different threads notice that the >> operation is finished (usually due to some exceptions being propagated) and >> try concur

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-10 Thread Jaikiran Pai
On Wed, 9 Mar 2022 12:09:48 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java >> line 179: >> >>> 177: } catch (Throwable t) { >>> 178: errorHandler.accept(command, t); >>> 179: ASYNC_POOL.execute(co

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-10 Thread Jaikiran Pai
On Wed, 9 Mar 2022 11:55:27 GMT, Daniel Fuchs wrote: > Here we don't need to check whether it's been acquired because we know it's > been acquired if we reach here. Hello Daniel, may be I am misreading the diff but from what I can see, the `acquire()` method now returns a `boolean` which we ar

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v2]

2022-03-09 Thread Daniel Fuchs
> These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests that are in flight >3. calling onError on BodySubscr

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Daniel Fuchs
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote: > These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Daniel Fuchs
On Wed, 9 Mar 2022 10:04:57 GMT, Jaikiran Pai wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling reque

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-03-09 Thread Jaikiran Pai
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote: > These changes make sure that pending requests are terminated if the selector > manager thread exits due to exceptions. > This includes: >1. completing CompletableFutures that were returned to the caller code >2. cancelling requests

RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-01-24 Thread Daniel Fuchs
This changes makes sure that pending requests are terminated if the selector manager thread exits due to exceptions. This includes: 1. completing CompletableFutures that were returned to the caller code 2. cancelling requests that are in flight 3. calling onError on BodySubscribers that m