Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-08 Thread Roger Riggs
On Tue, 8 Mar 2022 05:51:21 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204: >> >>> 202: } catch (GeneralSecurityException | java.io.IOException e) >>> { >>> 203: throw new SSLHandshakeException( >>> 204:

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:34:02 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204: > >> 202:

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:36:41 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java line > 263: > >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:24:08 GMT, Rajan Halade wrote: > Update following for SSLPeerUnverifiedException - > > https://github.com/openjdk/jdk/blob/master/src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java#L439 Hm, I will check more usage out of the JSSE implementation

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constructors accordingly. >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Bradford Wetmore
On Mon, 7 Mar 2022 20:39:44 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java >> line 158: >> >>> 156: } catch (GeneralSecurityException gse) { >>> 157: throw new SSLHandshakeException( >>> 158:

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:30:07 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java > line 158: >

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Bradford Wetmore
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constructors accordingly. >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Bradford Wetmore
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constructors accordingly. >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Rajan Halade
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constructors accordingly. >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Rajan Halade
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constructors accordingly. >>

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
> Please review this small API enhancement to add the usual constructors taking > a cause to javax.net.ssl exceptions. The use of initCause in the JSSE > implementation code is updated to use the new constructors accordingly. > > Please review the CSR: